Re: RFR: 8292758: put support for UNSIGNED5 format into its own header file [v2]

2022-09-08 Thread John R Rose
On Sat, 3 Sep 2022 07:48:50 GMT, Dean Long wrote: >> John R Rose has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two additional >> commits since

Re: RFR: 8292758: put support for UNSIGNED5 format into its own header file [v5]

2022-09-07 Thread Dean Long
On Wed, 7 Sep 2022 01:05:38 GMT, John R Rose wrote: >> Refactor code from inside of CompressedStream into its own unit. >> >> This code is likely to be used in future refactorings, such as JDK-8292818 >> (replace 96-bit representation for field metadata with variable-sized >> streams). >> >>

Re: RFR: 8292758: put support for UNSIGNED5 format into its own header file [v5]

2022-09-07 Thread Coleen Phillimore
On Wed, 7 Sep 2022 01:05:38 GMT, John R Rose wrote: >> Refactor code from inside of CompressedStream into its own unit. >> >> This code is likely to be used in future refactorings, such as JDK-8292818 >> (replace 96-bit representation for field metadata with variable-sized >> streams). >> >>

Re: RFR: 8292758: put support for UNSIGNED5 format into its own header file [v5]

2022-09-07 Thread Coleen Phillimore
On Wed, 7 Sep 2022 01:05:38 GMT, John R Rose wrote: >> Refactor code from inside of CompressedStream into its own unit. >> >> This code is likely to be used in future refactorings, such as JDK-8292818 >> (replace 96-bit representation for field metadata with variable-sized >> streams). >> >>

Re: RFR: 8292758: put support for UNSIGNED5 format into its own header file [v5]

2022-09-06 Thread John R Rose
> Refactor code from inside of CompressedStream into its own unit. > > This code is likely to be used in future refactorings, such as JDK-8292818 > (replace 96-bit representation for field metadata with variable-sized > streams). > > Add gtests. John R Rose has updated the pull request increme

Re: RFR: 8292758: put support for UNSIGNED5 format into its own header file [v4]

2022-09-06 Thread John R Rose
> Refactor code from inside of CompressedStream into its own unit. > > This code is likely to be used in future refactorings, such as JDK-8292818 > (replace 96-bit representation for field metadata with variable-sized > streams). > > Add gtests. John R Rose has updated the pull request increme

Re: RFR: 8292758: put support for UNSIGNED5 format into its own header file [v3]

2022-09-05 Thread Coleen Phillimore
On Sat, 3 Sep 2022 23:46:41 GMT, John R Rose wrote: >> Refactor code from inside of CompressedStream into its own unit. >> >> This code is likely to be used in future refactorings, such as JDK-8292818 >> (replace 96-bit representation for field metadata with variable-sized >> streams). >> >>

Re: RFR: 8292758: put support for UNSIGNED5 format into its own header file [v2]

2022-09-03 Thread Chris Plummer
On Sat, 3 Sep 2022 07:48:50 GMT, Dean Long wrote: > Wouldn't the SA stack walk fail when attaching to a core dump from an earlier > JVM that does not exclude nulls? I'm not sure how important compatibility is with older JVMs. SA is capable of (if properly maintained) connecting to any JVM. You

Re: RFR: 8292758: put support for UNSIGNED5 format into its own header file [v3]

2022-09-03 Thread John R Rose
> Refactor code from inside of CompressedStream into its own unit. > > This code is likely to be used in future refactorings, such as JDK-8292818 > (replace 96-bit representation for field metadata with variable-sized > streams). > > Add gtests. John R Rose has updated the pull request increme

Re: RFR: 8292758: put support for UNSIGNED5 format into its own header file [v2]

2022-09-03 Thread Dean Long
On Fri, 2 Sep 2022 00:04:17 GMT, John R Rose wrote: >> Refactor code from inside of CompressedStream into its own unit. >> >> This code is likely to be used in future refactorings, such as JDK-8292818 >> (replace 96-bit representation for field metadata with variable-sized >> streams). >> >>

Re: RFR: 8292758: put support for UNSIGNED5 format into its own header file [v2]

2022-09-02 Thread John R Rose
On Fri, 2 Sep 2022 23:28:38 GMT, Dean Long wrote: > I suggest splitting this up into the straight-forward refactor (without the > excluded bytes change), then adding excluded bytes as a follow-up. Yes, that is a slight change. Splitting is not necessary for the reason you mention because this

Re: RFR: 8292758: put support for UNSIGNED5 format into its own header file [v2]

2022-09-02 Thread Dean Long
On Fri, 2 Sep 2022 00:04:17 GMT, John R Rose wrote: >> Refactor code from inside of CompressedStream into its own unit. >> >> This code is likely to be used in future refactorings, such as JDK-8292818 >> (replace 96-bit representation for field metadata with variable-sized >> streams). >> >>

Re: RFR: 8292758: put support for UNSIGNED5 format into its own header file [v2]

2022-09-01 Thread Dean Long
On Fri, 2 Sep 2022 00:04:17 GMT, John R Rose wrote: >> Refactor code from inside of CompressedStream into its own unit. >> >> This code is likely to be used in future refactorings, such as JDK-8292818 >> (replace 96-bit representation for field metadata with variable-sized >> streams). >> >>

Re: RFR: 8292758: put support for UNSIGNED5 format into its own header file [v2]

2022-09-01 Thread John R Rose
On Fri, 2 Sep 2022 00:04:17 GMT, John R Rose wrote: >> Refactor code from inside of CompressedStream into its own unit. >> >> This code is likely to be used in future refactorings, such as JDK-8292818 >> (replace 96-bit representation for field metadata with variable-sized >> streams). >> >>

Re: RFR: 8292758: put support for UNSIGNED5 format into its own header file [v2]

2022-09-01 Thread John R Rose
> Refactor code from inside of CompressedStream into its own unit. > > This code is likely to be used in future refactorings, such as JDK-8292818 > (replace 96-bit representation for field metadata with variable-sized > streams). > > Add gtests. John R Rose has updated the pull request with a

Re: RFR: 8292758: put support for UNSIGNED5 format into its own header file

2022-09-01 Thread John R Rose
On Mon, 29 Aug 2022 18:20:42 GMT, John R Rose wrote: > Refactor code from inside of CompressedStream into its own unit. > > This code is likely to be used in future refactorings, such as JDK-8292818 > (replace 96-bit representation for field metadata with variable-sized > streams). > > Add gt

RFR: 8292758: put support for UNSIGNED5 format into its own header file

2022-09-01 Thread John R Rose
Refactor code from inside of CompressedStream into its own unit. This code is likely to be used in future refactorings, such as JDK-8292818 (replace 96-bit representation for field metadata with variable-sized streams). Add gtests. - Commit messages: - 8292758: put support for UNS