Re: RFR: 8292741: Convert JvmtiTagMapTable to ResourceHashtable [v10]

2023-01-16 Thread David Holmes
On Mon, 12 Dec 2022 00:44:29 GMT, David Holmes wrote: >> src/hotspot/share/prims/jvmtiTagMapTable.cpp line 88: >> >>> 86: } >>> 87: >>> 88: JvmtiTagMapTable::~JvmtiTagMapTable() { >> >> Is this the only use of `clear`? If so we can just inline its code here and >> remove it from the API. > >

Re: RFR: 8292741: Convert JvmtiTagMapTable to ResourceHashtable [v10]

2023-01-16 Thread David Holmes
On Wed, 11 Jan 2023 10:49:59 GMT, Afshin Zafari wrote: >> test of tier1-5 passed. > > Afshin Zafari has updated the pull request incrementally with one additional > commit since the last revision: > > 8292741: Convert JvmtiTagMapTable to ResourceHashtable Still have a couple of nits regardin

Re: RFR: 8292741: Convert JvmtiTagMapTable to ResourceHashtable [v10]

2023-01-16 Thread Coleen Phillimore
On Wed, 11 Jan 2023 10:49:59 GMT, Afshin Zafari wrote: >> test of tier1-5 passed. > > Afshin Zafari has updated the pull request incrementally with one additional > commit since the last revision: > > 8292741: Convert JvmtiTagMapTable to ResourceHashtable I have no further comments. This pa

Re: RFR: 8292741: Convert JvmtiTagMapTable to ResourceHashtable [v10]

2023-01-11 Thread Afshin Zafari
> test of tier1-5 passed. Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision: 8292741: Convert JvmtiTagMapTable to ResourceHashtable - Changes: - all: https://git.openjdk.org/jdk/pull/11288/files - new: https://git.open