Re: RFR: 8292302: Windows GetLastError value overwritten by ThreadLocalStorage::thread [v3]

2022-09-12 Thread Kevin Walls
> This is an MR which partially reverts JDK-8289091 such that > JavaThread::threadObj() does not call Thread::current(). > > A JVMTI operation could call threadObj() and clear the Windows GetLastError > value. > > Partial, because I haven't reverted changes in JavaThread::print_on_error(), > t

Re: RFR: 8292302: Windows GetLastError value overwritten by ThreadLocalStorage::thread [v2]

2022-09-12 Thread Kevin Walls
On Tue, 6 Sep 2022 08:42:13 GMT, Kevin Walls wrote: >> This is an MR which partially reverts JDK-8289091 such that >> JavaThread::threadObj() does not call Thread::current(). >> >> A JVMTI operation could call threadObj() and clear the Windows GetLastError >> value. >> >> Partial, because I h

Re: RFR: 8292302: Windows GetLastError value overwritten by ThreadLocalStorage::thread [v2]

2022-09-09 Thread Daniel D . Daugherty
On Tue, 6 Sep 2022 08:42:13 GMT, Kevin Walls wrote: >> This is an MR which partially reverts JDK-8289091 such that >> JavaThread::threadObj() does not call Thread::current(). >> >> A JVMTI operation could call threadObj() and clear the Windows GetLastError >> value. >> >> Partial, because I h

Re: RFR: 8292302: Windows GetLastError value overwritten by ThreadLocalStorage::thread [v2]

2022-09-06 Thread Kevin Walls
On Sat, 3 Sep 2022 11:05:18 GMT, Kevin Walls wrote: >> src/hotspot/share/runtime/javaThread.cpp line 165: >> >>> 163: oop JavaThread::threadObj() const { >>> 164: // Using Thread::current_or_null_safe() here risks that calling >>> threadObj() can >>> 165: // overwrite a native thread local,

Re: RFR: 8292302: Windows GetLastError value overwritten by ThreadLocalStorage::thread [v2]

2022-09-06 Thread Kevin Walls
> This is an MR which partially reverts JDK-8289091 such that > JavaThread::threadObj() does not call Thread::current(). > > A JVMTI operation could call threadObj() and clear the Windows GetLastError > value. > > Partial, because I haven't reverted changes in JavaThread::print_on_error(), > t

Re: RFR: 8292302: Windows GetLastError value overwritten by ThreadLocalStorage::thread

2022-09-03 Thread Kevin Walls
On Fri, 2 Sep 2022 20:33:37 GMT, David Holmes wrote: >> This is an MR which partially reverts JDK-8289091 such that >> JavaThread::threadObj() does not call Thread::current(). >> >> A JVMTI operation could call threadObj() and clear the Windows GetLastError >> value. >> >> Partial, because I

Re: RFR: 8292302: Windows GetLastError value overwritten by ThreadLocalStorage::thread

2022-09-02 Thread David Holmes
On Fri, 2 Sep 2022 14:47:35 GMT, Kevin Walls wrote: > This is an MR which partially reverts JDK-8289091 such that > JavaThread::threadObj() does not call Thread::current(). > > A JVMTI operation could call threadObj() and clear the Windows GetLastError > value. > > Partial, because I haven't

Re: RFR: 8292302: Windows GetLastError value overwritten by ThreadLocalStorage::thread

2022-09-02 Thread Chris Plummer
On Fri, 2 Sep 2022 14:47:35 GMT, Kevin Walls wrote: > This is an MR which partially reverts JDK-8289091 such that > JavaThread::threadObj() does not call Thread::current(). > > A JVMTI operation could call threadObj() and clear the Windows GetLastError > value. > > Partial, because I haven't

RFR: 8292302: Windows GetLastError value overwritten by ThreadLocalStorage::thread

2022-09-02 Thread Kevin Walls
This is an MR which partially reverts JDK-8289091 such that JavaThread::threadObj() does not call Thread::current(). A JVMTI operation could call threadObj() and clear the Windows GetLastError value. Partial, because I haven't reverted changes in JavaThread::print_on_error(), they aren't conne