On Wed, 26 Apr 2023 16:07:33 GMT, Daniel D. Daugherty
wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unnecessary comments
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/Threads.java line
On Wed, 26 Apr 2023 18:35:45 GMT, Thomas Stuefe wrote:
>> src/hotspot/cpu/arm/sharedRuntime_arm.cpp line 649:
>>
>>> 647:
>>> 648: __ flush();
>>> 649: return AdapterHandlerLibrary::new_entry(fingerprint, i2c_entry,
>>> c2i_entry, c2i_unverified_entry);
>>
>> This change seems out of plac
On Wed, 26 Apr 2023 18:33:28 GMT, Roman Kennke wrote:
>> src/hotspot/share/logging/logTag.hpp line 80:
>>
>>> 78: LOG_TAG(exceptions) \
>>> 79: LOG_TAG(exit) \
>>> 80: LOG_TAG(fastlock2) \
>>
>> So why 'fastlock2'? Where's 'fastlock1'? Or 'fastlock'?
>
> It's currently only used in the ar
On Wed, 26 Apr 2023 11:00:33 GMT, Quan Anh Mai wrote:
>> How would I check if we are emitting code?
>>
>> I am not sure I understand. The check for ANONYMOUS is only relevant when we
>> observe an already-inflated monitor. I think this is the right place to put
>> it.
>
> The entry barrier doe
On Wed, 26 Apr 2023 18:29:36 GMT, Thomas Stuefe wrote:
>> src/hotspot/cpu/arm/macroAssembler_arm.cpp line 1803:
>>
>>> 1801: #ifdef ASSERT
>>> 1802: // Poison scratch regs
>>> 1803: POISON_REGS((~savemask), t1, t2, t3, 0x1001);
>>
>> Should this poison value be: 0x2002
>
> The poiso
On Mon, 24 Apr 2023 22:51:10 GMT, Daniel D. Daugherty
wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unnecessary comments
>
> src/hotspot/cpu/arm/macroAssembler_arm.cpp line 1803:
>
>> 1801: #ifdef ASSERT
On Mon, 24 Apr 2023 22:51:10 GMT, Daniel D. Daugherty
wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unnecessary comments
>
> src/hotspot/cpu/arm/macroAssembler_arm.cpp line 1803:
>
>> 1801: #ifdef ASSERT
On Wed, 26 Apr 2023 10:43:48 GMT, Roman Kennke wrote:
>> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 701:
>>
>>> 699: // ZFlag == 0 count in slow path
>>> 700: jccb(Assembler::notZero, NO_COUNT); // jump if ZFlag == 0
>>> 701:
>>
>> `DONE_LABEL` is conditionally jumped into from a l
On Thu, 20 Apr 2023 11:15:47 GMT, Roman Kennke wrote:
>> This change adds a fast-locking scheme as an alternative to the current
>> stack-locking implementation. It retains the advantages of stack-locking
>> (namely fast locking in uncontended code-paths), while avoiding the overload
>> of the
On Wed, 26 Apr 2023 03:09:53 GMT, Quan Anh Mai wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unnecessary comments
>
> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 691:
>
>> 689: jccb(Assembler::no
On Wed, 26 Apr 2023 10:52:29 GMT, Roman Kennke wrote:
>> This stub has 2 instructions, and it seems not really uncommon, is it worth
>> it to have a stub here?
>
> Ok I will change the value.
> Yes, this path is relatively uncommon (monitors are inflated only once, and
> not necessarily via ANO
On Wed, 26 Apr 2023 09:03:07 GMT, Quan Anh Mai wrote:
>> src/hotspot/cpu/x86/c2_CodeStubs_x86.cpp line 81:
>>
>>> 79: // C2CodeStubList::emit() will throw an assertion and report the
>>> actual size that
>>> 80: // is needed.
>>> 81: return 33;
>>
>> This should be 36 with `ASSERT` and 2
On Wed, 26 Apr 2023 08:12:41 GMT, Quan Anh Mai wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unnecessary comments
>
> src/hotspot/cpu/x86/c2_CodeStubs_x86.cpp line 81:
>
>> 79: // C2CodeStubList::emit()
On Thu, 20 Apr 2023 11:15:47 GMT, Roman Kennke wrote:
>> This change adds a fast-locking scheme as an alternative to the current
>> stack-locking implementation. It retains the advantages of stack-locking
>> (namely fast locking in uncontended code-paths), while avoiding the overload
>> of the
On Thu, 20 Apr 2023 11:15:47 GMT, Roman Kennke wrote:
>> This change adds a fast-locking scheme as an alternative to the current
>> stack-locking implementation. It retains the advantages of stack-locking
>> (namely fast locking in uncontended code-paths), while avoiding the overload
>> of the
> This change adds a fast-locking scheme as an alternative to the current
> stack-locking implementation. It retains the advantages of stack-locking
> (namely fast locking in uncontended code-paths), while avoiding the overload
> of the mark word. That overloading causes massive problems with Li
16 matches
Mail list logo
