Re: RFR: 8291555: Implement alternative fast-locking scheme [v4]

2023-01-30 Thread Roman Kennke
On Thu, 26 Jan 2023 13:45:35 GMT, Robbin Ehn wrote: > > > I always change the flags in code for the reasons David state and I can't > > > forget to add any flags. > > > (Test batch is stilling running, no failures except > > > MonitorInflationTest.java) > > > > > > Ok, right. > > I just re-ra

Re: RFR: 8291555: Implement alternative fast-locking scheme [v4]

2023-01-30 Thread Roman Kennke
On Wed, 25 Jan 2023 20:02:35 GMT, Daniel D. Daugherty wrote: >> Roman Kennke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert UseFastLocking to default to off > > src/hotspot/share/oops/markWord.hpp line 183: > >> 181: } >> 182

Re: RFR: 8291555: Implement alternative fast-locking scheme [v4]

2023-01-30 Thread Roman Kennke
On Wed, 25 Jan 2023 17:42:23 GMT, Daniel D. Daugherty wrote: >> Roman Kennke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert UseFastLocking to default to off > > src/hotspot/share/runtime/objectMonitor.cpp line 1141: > >> 1139:

Re: RFR: 8291555: Implement alternative fast-locking scheme [v4]

2023-01-27 Thread Daniel D . Daugherty
On Wed, 18 Jan 2023 20:10:21 GMT, Roman Kennke wrote: >> This change adds a fast-locking scheme as an alternative to the current >> stack-locking implementation. It retains the advantages of stack-locking >> (namely fast locking in uncontended code-paths), while avoiding the overload >> of the

Re: RFR: 8291555: Implement alternative fast-locking scheme [v4]

2023-01-26 Thread Robbin Ehn
On Thu, 19 Jan 2023 12:09:27 GMT, Roman Kennke wrote: > > I always change the flags in code for the reasons David state and I can't > > forget to add any flags. > > (Test batch is stilling running, no failures except > > MonitorInflationTest.java) > > Ok, right. > > I just re-ran tier1-3 with

Re: RFR: 8291555: Implement alternative fast-locking scheme [v4]

2023-01-25 Thread Daniel D . Daugherty
On Wed, 18 Jan 2023 20:10:21 GMT, Roman Kennke wrote: >> This change adds a fast-locking scheme as an alternative to the current >> stack-locking implementation. It retains the advantages of stack-locking >> (namely fast locking in uncontended code-paths), while avoiding the overload >> of the

Re: RFR: 8291555: Implement alternative fast-locking scheme [v4]

2023-01-19 Thread Roman Kennke
On Thu, 19 Jan 2023 08:19:54 GMT, Robbin Ehn wrote: > I always change the flags in code for the reasons David state and I can't > forget to add any flags. > > (Test batch is stilling running, no failures except MonitorInflationTest.java) Ok, right. I just re-ran tier1-3 with the flag changed

Re: RFR: 8291555: Implement alternative fast-locking scheme [v4]

2023-01-19 Thread Robbin Ehn
On Wed, 18 Jan 2023 20:10:21 GMT, Roman Kennke wrote: >> This change adds a fast-locking scheme as an alternative to the current >> stack-locking implementation. It retains the advantages of stack-locking >> (namely fast locking in uncontended code-paths), while avoiding the overload >> of the

Re: RFR: 8291555: Implement alternative fast-locking scheme [v4]

2023-01-18 Thread Roman Kennke
> This change adds a fast-locking scheme as an alternative to the current > stack-locking implementation. It retains the advantages of stack-locking > (namely fast locking in uncontended code-paths), while avoiding the overload > of the mark word. That overloading causes massive problems with Li