Re: RFR: 8291237: Encapsulate nmethod Deoptimization logic [v2]

2022-08-08 Thread Dean Long
On Mon, 1 Aug 2022 04:58:49 GMT, Axel Boldt-Christmas wrote: >> The proposal is to encapsulate the nmethod mark for deoptimization logic in >> one place and only allow access to the `mark_for_deoptimization` from a >> closure object: >> ```C++ >> class DeoptimizationMarkerClosure : StackObj { >

Re: RFR: 8291237: Encapsulate nmethod Deoptimization logic [v2]

2022-08-04 Thread Erik Österlund
On Wed, 3 Aug 2022 20:42:59 GMT, Erik Österlund wrote: >> Axel Boldt-Christmas has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Add assertions >> - Fix marked logic >> - Erik refactorings > > Also, in DeoptimizationContext::deopt_co

Re: RFR: 8291237: Encapsulate nmethod Deoptimization logic [v2]

2022-08-04 Thread Dean Long
On Wed, 3 Aug 2022 20:42:59 GMT, Erik Österlund wrote: >> Axel Boldt-Christmas has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Add assertions >> - Fix marked logic >> - Erik refactorings > > Also, in DeoptimizationContext::deopt_co

Re: RFR: 8291237: Encapsulate nmethod Deoptimization logic [v2]

2022-08-03 Thread Erik Österlund
On Mon, 1 Aug 2022 04:58:49 GMT, Axel Boldt-Christmas wrote: >> The proposal is to encapsulate the nmethod mark for deoptimization logic in >> one place and only allow access to the `mark_for_deoptimization` from a >> closure object: >> ```C++ >> class DeoptimizationMarkerClosure : StackObj { >

Re: RFR: 8291237: Encapsulate nmethod Deoptimization logic [v2]

2022-08-03 Thread Erik Österlund
On Mon, 1 Aug 2022 04:58:49 GMT, Axel Boldt-Christmas wrote: >> The proposal is to encapsulate the nmethod mark for deoptimization logic in >> one place and only allow access to the `mark_for_deoptimization` from a >> closure object: >> ```C++ >> class DeoptimizationMarkerClosure : StackObj { >

Re: RFR: 8291237: Encapsulate nmethod Deoptimization logic [v2]

2022-08-03 Thread Dean Long
On Mon, 1 Aug 2022 04:58:49 GMT, Axel Boldt-Christmas wrote: >> The proposal is to encapsulate the nmethod mark for deoptimization logic in >> one place and only allow access to the `mark_for_deoptimization` from a >> closure object: >> ```C++ >> class DeoptimizationMarkerClosure : StackObj { >

Re: RFR: 8291237: Encapsulate nmethod Deoptimization logic [v2]

2022-08-03 Thread Axel Boldt-Christmas
On Mon, 1 Aug 2022 04:58:49 GMT, Axel Boldt-Christmas wrote: >> The proposal is to encapsulate the nmethod mark for deoptimization logic in >> one place and only allow access to the `mark_for_deoptimization` from a >> closure object: >> ```C++ >> class DeoptimizationMarkerClosure : StackObj { >

Re: RFR: 8291237: Encapsulate nmethod Deoptimization logic [v2]

2022-08-02 Thread Dean Long
On Mon, 1 Aug 2022 04:58:49 GMT, Axel Boldt-Christmas wrote: >> The proposal is to encapsulate the nmethod mark for deoptimization logic in >> one place and only allow access to the `mark_for_deoptimization` from a >> closure object: >> ```C++ >> class DeoptimizationMarkerClosure : StackObj { >

Re: RFR: 8291237: Encapsulate nmethod Deoptimization logic [v2]

2022-08-02 Thread Axel Boldt-Christmas
On Mon, 1 Aug 2022 04:58:49 GMT, Axel Boldt-Christmas wrote: >> The proposal is to encapsulate the nmethod mark for deoptimization logic in >> one place and only allow access to the `mark_for_deoptimization` from a >> closure object: >> ```C++ >> class DeoptimizationMarkerClosure : StackObj { >

Re: RFR: 8291237: Encapsulate nmethod Deoptimization logic [v2]

2022-07-31 Thread Axel Boldt-Christmas
> The proposal is to encapsulate the nmethod mark for deoptimization logic in > one place and only allow access to the `mark_for_deoptimization` from a > closure object: > ```C++ > class DeoptimizationMarkerClosure : StackObj { > public: > virtual void marker_do(Deoptimization::MarkFn mark_fn)