Re: RFR: 8290497: some tests in com/sun/jdi fail on localized Windows platform [v2]

2022-08-01 Thread Serguei Spitsyn
On Mon, 1 Aug 2022 06:51:28 GMT, KIRIYAMA Takuya wrote: >> @tkiriyama Normally, two reviews are required in Serviceability area. > > @sspitsyn > Can I ask you again to integrate this fix? @tkiriyama I've sponsored your fix. It will be integrated now, I hope. - PR: https://git.openj

Re: RFR: 8290497: some tests in com/sun/jdi fail on localized Windows platform [v2]

2022-07-31 Thread KIRIYAMA Takuya
On Wed, 20 Jul 2022 07:41:42 GMT, Serguei Spitsyn wrote: >> @sspitsyn >> Thank you for your review. Coud you integrate this fix, please? > > @tkiriyama Normally, two reviews are required in Serviceability area. @sspitsyn Can I ask you again to integrate this fix? - PR: https://git

Re: RFR: 8290497: some tests in com/sun/jdi fail on localized Windows platform [v2]

2022-07-26 Thread Alex Menkov
On Tue, 26 Jul 2022 06:29:12 GMT, KIRIYAMA Takuya wrote: >> Failed tests call java.lang.ProcessBuilder in direct, so not used command >> options specified when jtreg command run. >> To run non-localized tests, the locale options should be added in >> ProcessBuilder. >> >> Could you review thi

Re: RFR: 8290497: some tests in com/sun/jdi fail on localized Windows platform [v2]

2022-07-26 Thread Chris Plummer
On Tue, 26 Jul 2022 06:29:12 GMT, KIRIYAMA Takuya wrote: >> Failed tests call java.lang.ProcessBuilder in direct, so not used command >> options specified when jtreg command run. >> To run non-localized tests, the locale options should be added in >> ProcessBuilder. >> >> Could you review thi

Re: RFR: 8290497: some tests in com/sun/jdi fail on localized Windows platform [v2]

2022-07-25 Thread KIRIYAMA Takuya
> Failed tests call java.lang.ProcessBuilder in direct, so not used command > options specified when jtreg command run. > To run non-localized tests, the locale options should be added in > ProcessBuilder. > > Could you review this fix, please? KIRIYAMA Takuya has updated the pull request incr