On Wed, 27 Jul 2022 09:45:25 GMT, Axel Boldt-Christmas wrote:
>> Currently the `RegisterMap` constructor uses implicit boolean arguments to
>> configure its function. Implicit boolean arguments makes code harder to
>> understand and reason about at the call site. Using explicit scoped enums
>>
> Currently the `RegisterMap` constructor uses implicit boolean arguments to
> configure its function. Implicit boolean arguments makes code harder to
> understand and reason about at the call site. Using explicit scoped enums
> instead makes it both clear what is being configured and the type s
On Tue, 26 Jul 2022 16:25:04 GMT, Thomas Schatzl wrote:
>> Currently the `RegisterMap` constructor uses implicit boolean arguments to
>> configure its function. Implicit boolean arguments makes code harder to
>> understand and reason about at the call site. Using explicit scoped enums
>> inste
On Mon, 11 Jul 2022 14:58:07 GMT, Axel Boldt-Christmas wrote:
> Currently the `RegisterMap` constructor uses implicit boolean arguments to
> configure its function. Implicit boolean arguments makes code harder to
> understand and reason about at the call site. Using explicit scoped enums
> ins
On Mon, 11 Jul 2022 14:58:07 GMT, Axel Boldt-Christmas wrote:
> 8290074: Remove implicit arguments for RegisterMap constructor
Looks good except for a spurious semicolon. Don't need another review for that.
src/hotspot/share/runtime/frame.cpp line 85:
> 83: RegisterMap::RegisterMap(oop continu
8290074: Remove implicit arguments for RegisterMap constructor
-
Commit messages:
- Fix spurious semicolon
- Change to scoped enum
- 8290074: Remove implicit arguments for RegisterMap constructor
- 8290074: Remove implicit arguments for RegisterMap constructor
- 8290074: Remove i
