Re: RFR: 8289610: Degrade Thread.stop [v4]

2022-09-22 Thread Alan Bateman
On Thu, 22 Sep 2022 04:36:08 GMT, Joe Darcy wrote: > Consider using an implSpec tag here. implSpec is usually for default methods or overrideable methods. In this case, Thread.stop is final so code that extends Thread can't override and change the behavior. So it's not clear to me that implSpe

Re: RFR: 8289610: Degrade Thread.stop [v4]

2022-09-21 Thread Joe Darcy
On Sat, 17 Sep 2022 08:41:19 GMT, Alan Bateman wrote: >> Degrade Thread.stop to throw UOE unconditionally, deprecate ThreadDeath for >> removal, and remove the remaining special handling of ThreadDeath from the >> JDK. >> >> Thread.stop is inherently unsafe and has been deprecated since JDK 1.

Re: RFR: 8289610: Degrade Thread.stop [v4]

2022-09-21 Thread Alan Bateman
On Wed, 21 Sep 2022 06:43:50 GMT, David Holmes wrote: > Okay I will defer to your views here. Thanks. Thank you, I'll get the CSR moving again and we'll try to get this done. - PR: https://git.openjdk.org/jdk/pull/10230

Re: RFR: 8289610: Degrade Thread.stop [v4]

2022-09-20 Thread David Holmes
On Tue, 20 Sep 2022 16:29:08 GMT, Stuart Marks wrote: >>> Good to see this finally become non-functional but as long as the >>> debugger/JVMTI can trigger throwing an async ThreadDeath then I have to >>> question the potential change in behaviour introduced by removing all the >>> `catch (Thre

Re: RFR: 8289610: Degrade Thread.stop [v4]

2022-09-20 Thread Stuart Marks
On Tue, 20 Sep 2022 06:00:14 GMT, Alan Bateman wrote: >> src/java.base/share/classes/java/io/FilterOutputStream.java line 195: >> >>> 193:// evaluate possible precedence of flushException >>> over closeException >>> 194:if ((flushException instanceof Thre

Re: RFR: 8289610: Degrade Thread.stop [v4]

2022-09-19 Thread Alan Bateman
On Tue, 20 Sep 2022 04:21:39 GMT, David Holmes wrote: >> Alan Bateman has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 12 additional >> commits s

Re: RFR: 8289610: Degrade Thread.stop [v4]

2022-09-19 Thread David Holmes
On Sat, 17 Sep 2022 08:41:19 GMT, Alan Bateman wrote: >> Degrade Thread.stop to throw UOE unconditionally, deprecate ThreadDeath for >> removal, and remove the remaining special handling of ThreadDeath from the >> JDK. >> >> Thread.stop is inherently unsafe and has been deprecated since JDK 1.

Re: RFR: 8289610: Degrade Thread.stop [v4]

2022-09-17 Thread Alan Bateman
> Degrade Thread.stop to throw UOE unconditionally, deprecate ThreadDeath for > removal, and remove the remaining special handling of ThreadDeath from the > JDK. > > Thread.stop is inherently unsafe and has been deprecated since JDK 1.2 (1998) > with a link to a supplementary page that explains