Re: RFR: 8289400: Improve com/sun/jdi/TestScaffold error reporting [v2]

2022-09-02 Thread Chris Plummer
On Thu, 1 Sep 2022 21:11:09 GMT, Chris Plummer wrote: >> com/sun/jdi tests report errors by calling TestScaffold.failure(msg), which >> prints the failure message and sets the testFailed flag. At some later point >> the failure is detected and an exception is thrown. The end result is the >> e

Re: RFR: 8289400: Improve com/sun/jdi/TestScaffold error reporting [v2]

2022-09-02 Thread Leonid Mesnik
On Thu, 1 Sep 2022 21:11:09 GMT, Chris Plummer wrote: >> com/sun/jdi tests report errors by calling TestScaffold.failure(msg), which >> prints the failure message and sets the testFailed flag. At some later point >> the failure is detected and an exception is thrown. The end result is the >> e

Re: RFR: 8289400: Improve com/sun/jdi/TestScaffold error reporting [v2]

2022-09-01 Thread Chris Plummer
On Fri, 2 Sep 2022 05:40:38 GMT, Alan Bateman wrote: >> Chris Plummer has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add curly braces. > > test/jdk/com/sun/jdi/TestScaffold.java line 459: > >> 457: for (StackTraceElement traceE

Re: RFR: 8289400: Improve com/sun/jdi/TestScaffold error reporting [v2]

2022-09-01 Thread Alan Bateman
On Thu, 1 Sep 2022 21:11:09 GMT, Chris Plummer wrote: >> com/sun/jdi tests report errors by calling TestScaffold.failure(msg), which >> prints the failure message and sets the testFailed flag. At some later point >> the failure is detected and an exception is thrown. The end result is the >> e

Re: RFR: 8289400: Improve com/sun/jdi/TestScaffold error reporting [v2]

2022-09-01 Thread Alex Menkov
On Thu, 1 Sep 2022 21:11:09 GMT, Chris Plummer wrote: >> com/sun/jdi tests report errors by calling TestScaffold.failure(msg), which >> prints the failure message and sets the testFailed flag. At some later point >> the failure is detected and an exception is thrown. The end result is the >> e

Re: RFR: 8289400: Improve com/sun/jdi/TestScaffold error reporting [v2]

2022-09-01 Thread Chris Plummer
On Thu, 1 Sep 2022 20:15:04 GMT, Alex Menkov wrote: >> Chris Plummer has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add curly braces. > > test/jdk/com/sun/jdi/TestScaffold.java line 457: > >> 455: println(str); >> 456:

Re: RFR: 8289400: Improve com/sun/jdi/TestScaffold error reporting [v2]

2022-09-01 Thread Chris Plummer
> com/sun/jdi tests report errors by calling TestScaffold.failure(msg), which > prints the failure message and sets the testFailed flag. At some later point > the failure is detected and an exception is thrown. The end result is the > exception has just has a vanilla message that says something