Re: RFR: 8288752: Split thread implementation files [v7]

2022-06-22 Thread Coleen Phillimore
On Wed, 22 Jun 2022 19:06:35 GMT, Daniel D. Daugherty wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More GHA fixes. > > src/hotspot/share/prims/jvmtiDeferredUpdates.hpp line 36: > >> 34: template class Gr

Re: RFR: 8288752: Split thread implementation files [v9]

2022-06-22 Thread Daniel D . Daugherty
On Wed, 22 Jun 2022 01:05:47 GMT, Coleen Phillimore wrote: >> This changes splits thread.hpp/cpp into javaThread, and threads files. >> >> I left the commits intact to see better the progression of changes, but most >> files are include file changes. The only tricky parts are that some files

Re: RFR: 8288752: Split thread implementation files [v7]

2022-06-22 Thread Coleen Phillimore
On Tue, 21 Jun 2022 23:38:23 GMT, Daniel D. Daugherty wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More GHA fixes. > > src/hotspot/cpu/zero/stack_zero.cpp line 29: > >> 27: #include "interpreter/interpret

Re: RFR: 8288752: Split thread implementation files [v9]

2022-06-22 Thread Coleen Phillimore
On Wed, 22 Jun 2022 01:05:47 GMT, Coleen Phillimore wrote: >> This changes splits thread.hpp/cpp into javaThread, and threads files. >> >> I left the commits intact to see better the progression of changes, but most >> files are include file changes. The only tricky parts are that some files

Re: RFR: 8288752: Split thread implementation files [v9]

2022-06-22 Thread Daniel D . Daugherty
On Wed, 22 Jun 2022 12:47:03 GMT, Coleen Phillimore wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Merge and testing in progress. > > Guidance says no copyright update. Thanks for reviewing. @coleenp's comme

Re: RFR: 8288752: Split thread implementation files [v7]

2022-06-22 Thread Daniel D . Daugherty
On Tue, 21 Jun 2022 23:02:49 GMT, Coleen Phillimore wrote: >> This changes splits thread.hpp/cpp into javaThread, and threads files. >> >> I left the commits intact to see better the progression of changes, but most >> files are include file changes. The only tricky parts are that some files

Re: RFR: 8288752: Split thread implementation files [v9]

2022-06-22 Thread Coleen Phillimore
On Wed, 22 Jun 2022 01:05:47 GMT, Coleen Phillimore wrote: >> This changes splits thread.hpp/cpp into javaThread, and threads files. >> >> I left the commits intact to see better the progression of changes, but most >> files are include file changes. The only tricky parts are that some files

Re: RFR: 8288752: Split thread implementation files [v9]

2022-06-22 Thread Coleen Phillimore
On Wed, 22 Jun 2022 01:05:47 GMT, Coleen Phillimore wrote: >> This changes splits thread.hpp/cpp into javaThread, and threads files. >> >> I left the commits intact to see better the progression of changes, but most >> files are include file changes. The only tricky parts are that some files

Re: RFR: 8288752: Split thread implementation files [v9]

2022-06-22 Thread David Holmes
On Wed, 22 Jun 2022 01:05:47 GMT, Coleen Phillimore wrote: >> This changes splits thread.hpp/cpp into javaThread, and threads files. >> >> I left the commits intact to see better the progression of changes, but most >> files are include file changes. The only tricky parts are that some files

Re: RFR: 8288752: Split thread implementation files [v9]

2022-06-22 Thread Thomas Stuefe
On Wed, 22 Jun 2022 01:05:47 GMT, Coleen Phillimore wrote: >> This changes splits thread.hpp/cpp into javaThread, and threads files. >> >> I left the commits intact to see better the progression of changes, but most >> files are include file changes. The only tricky parts are that some files

Re: RFR: 8288752: Split thread implementation files [v7]

2022-06-21 Thread Coleen Phillimore
On Tue, 21 Jun 2022 23:28:17 GMT, Daniel D. Daugherty wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More GHA fixes. > > My three fixes have been sync'ed from JDK19 to JDK20. @dcubed-ojdk Your changes are n

Re: RFR: 8288752: Split thread implementation files [v9]

2022-06-21 Thread Coleen Phillimore
> This changes splits thread.hpp/cpp into javaThread, and threads files. > > I left the commits intact to see better the progression of changes, but most > files are include file changes. The only tricky parts are that some files > were included in thread.hpp, like mutexLocker.cpp, which has to

Re: RFR: 8288752: Split thread implementation files [v8]

2022-06-21 Thread Coleen Phillimore
> This changes splits thread.hpp/cpp into javaThread, and threads files. > > I left the commits intact to see better the progression of changes, but most > files are include file changes. The only tricky parts are that some files > were included in thread.hpp, like mutexLocker.cpp, which has to

Re: RFR: 8288752: Split thread implementation files [v7]

2022-06-21 Thread Daniel D . Daugherty
On Tue, 21 Jun 2022 23:02:49 GMT, Coleen Phillimore wrote: >> This changes splits thread.hpp/cpp into javaThread, and threads files. >> >> I left the commits intact to see better the progression of changes, but most >> files are include file changes. The only tricky parts are that some files

Re: RFR: 8288752: Split thread implementation files [v7]

2022-06-21 Thread Coleen Phillimore
> This changes splits thread.hpp/cpp into javaThread, and threads files. > > I left the commits intact to see better the progression of changes, but most > files are include file changes. The only tricky parts are that some files > were included in thread.hpp, like mutexLocker.cpp, which has to

Re: RFR: 8288752: Split thread implementation files [v2]

2022-06-21 Thread Daniel D . Daugherty
On Tue, 21 Jun 2022 15:25:00 GMT, Coleen Phillimore wrote: > Also I'm waiting for @dcubed-ojdk changes to JDK 19 to be integrated and > merged into JDK 20 first. My three fixes have been integrated into JDK19. They have not yet been sync'ed to JDK20. Thank you very much for waiting. --

Re: RFR: 8288752: Split thread implementation files [v5]

2022-06-21 Thread Coleen Phillimore
On Tue, 21 Jun 2022 19:38:31 GMT, Coleen Phillimore wrote: >> This changes splits thread.hpp/cpp into javaThread, and threads files. >> >> I left the commits intact to see better the progression of changes, but most >> files are include file changes. The only tricky parts are that some files

Re: RFR: 8288752: Split thread implementation files [v6]

2022-06-21 Thread Coleen Phillimore
> This changes splits thread.hpp/cpp into javaThread, and threads files. > > I left the commits intact to see better the progression of changes, but most > files are include file changes. The only tricky parts are that some files > were included in thread.hpp, like mutexLocker.cpp, which has to

Re: RFR: 8288752: Split thread implementation files [v5]

2022-06-21 Thread Coleen Phillimore
On Tue, 21 Jun 2022 19:38:31 GMT, Coleen Phillimore wrote: >> This changes splits thread.hpp/cpp into javaThread, and threads files. >> >> I left the commits intact to see better the progression of changes, but most >> files are include file changes. The only tricky parts are that some files

Re: RFR: 8288752: Split thread implementation files [v5]

2022-06-21 Thread Coleen Phillimore
> This changes splits thread.hpp/cpp into javaThread, and threads files. > > I left the commits intact to see better the progression of changes, but most > files are include file changes. The only tricky parts are that some files > were included in thread.hpp, like mutexLocker.cpp, which has to

Re: RFR: 8288752: Split thread implementation files [v4]

2022-06-21 Thread Coleen Phillimore
> This changes splits thread.hpp/cpp into javaThread, and threads files. > > I left the commits intact to see better the progression of changes, but most > files are include file changes. The only tricky parts are that some files > were included in thread.hpp, like mutexLocker.cpp, which has to

Re: RFR: 8288752: Split thread implementation files [v3]

2022-06-21 Thread Ioi Lam
On Mon, 20 Jun 2022 23:56:51 GMT, David Holmes wrote: > Hi Coleen, > > The changes in themselves seem fine to me - I only skimmed things, mainly > looking at the new files. It is a very large refactoring so there will be an > impact on backports naturally. > > I'm not sure this will save much

Re: RFR: 8288752: Split thread implementation files [v3]

2022-06-21 Thread Ioi Lam
On Tue, 21 Jun 2022 15:32:15 GMT, Coleen Phillimore wrote: >> This changes splits thread.hpp/cpp into javaThread, and threads files. >> >> I left the commits intact to see better the progression of changes, but most >> files are include file changes. The only tricky parts are that some files

Re: RFR: 8288752: Split thread implementation files [v2]

2022-06-21 Thread Coleen Phillimore
On Tue, 21 Jun 2022 12:22:46 GMT, Coleen Phillimore wrote: >> This changes splits thread.hpp/cpp into javaThread, and threads files. >> >> I left the commits intact to see better the progression of changes, but most >> files are include file changes. The only tricky parts are that some files

Re: RFR: 8288752: Split thread implementation files [v3]

2022-06-21 Thread Coleen Phillimore
> This changes splits thread.hpp/cpp into javaThread, and threads files. > > I left the commits intact to see better the progression of changes, but most > files are include file changes. The only tricky parts are that some files > were included in thread.hpp, like mutexLocker.cpp, which has to

Re: RFR: 8288752: Split thread implementation files [v2]

2022-06-21 Thread Robbin Ehn
On Tue, 21 Jun 2022 12:22:46 GMT, Coleen Phillimore wrote: >> This changes splits thread.hpp/cpp into javaThread, and threads files. >> >> I left the commits intact to see better the progression of changes, but most >> files are include file changes. The only tricky parts are that some files

Re: RFR: 8288752: Split thread implementation files [v2]

2022-06-21 Thread Coleen Phillimore
> This changes splits thread.hpp/cpp into javaThread, and threads files. > > I left the commits intact to see better the progression of changes, but most > files are include file changes. The only tricky parts are that some files > were included in thread.hpp, like mutexLocker.cpp, which has to

Re: RFR: 8288752: Split thread implementation files

2022-06-20 Thread David Holmes
On Mon, 20 Jun 2022 15:49:44 GMT, Coleen Phillimore wrote: > This changes splits thread.hpp/cpp into javaThread, and threads files. > > I left the commits intact to see better the progression of changes, but most > files are include file changes. The only tricky parts are that some files > we

RFR: 8288752: Split thread implementation files

2022-06-20 Thread Coleen Phillimore
This changes splits thread.hpp/cpp into javaThread, and threads files. I left the commits intact to see better the progression of changes, but most files are include file changes. The only tricky parts are that some files were included in thread.hpp, like mutexLocker.cpp, which has to be includ