Re: RFR: 8286030: Avoid JVM crash when containers share the same /tmp dir [v5]

2022-07-12 Thread Thomas Stuefe
On Tue, 12 Jul 2022 18:38:33 GMT, Ioi Lam wrote: >> src/hotspot/os/posix/perfMemory_posix.cpp line 807: >> >>> 805: // Hold the lock until here to prevent other JVMs from using this >>> file >>> 806: // while we are in the middle of deleting it. >>> 807: ::close(fd); >> >> I don't

Re: RFR: 8286030: Avoid JVM crash when containers share the same /tmp dir [v5]

2022-07-12 Thread Ioi Lam
On Mon, 11 Jul 2022 04:53:19 GMT, Thomas Stuefe wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed typo > > src/hotspot/os/posix/perfMemory_posix.cpp line 733: > >> 731: while ((entry = os::readdir(dirp)) != NULL)

Re: RFR: 8286030: Avoid JVM crash when containers share the same /tmp dir [v5]

2022-07-10 Thread Thomas Stuefe
On Sat, 9 Jul 2022 06:49:03 GMT, Ioi Lam wrote: >> Some Kubernetes setups share the /tmp directory across multiple containers. >> On rare occasions, the JVM may crash when it tries to write to >> `/tmp/hsperfdata_/` when a process in a separate container >> decides to do the same thing (becaus

Re: RFR: 8286030: Avoid JVM crash when containers share the same /tmp dir [v5]

2022-07-08 Thread Ioi Lam
> Some Kubernetes setups share the /tmp directory across multiple containers. > On rare occasions, the JVM may crash when it tries to write to > `/tmp/hsperfdata_/` when a process in a separate container decides > to do the same thing (because they happen to have the same namespaced pid). > > T