Re: RFR: 8285364: Remove REF_ enum for java.lang.ref.Reference [v9]

2022-06-28 Thread Stefan Karlsson
On Mon, 27 Jun 2022 22:19:35 GMT, Albert Mingkun Yang wrote: >> Simple rename and some comments update. >> >> Test: build > > Albert Mingkun Yang has updated the pull request incrementally with one > additional commit since the last revision: > > review Scratch my last comment. This crashes

Re: RFR: 8285364: Remove REF_ enum for java.lang.ref.Reference [v9]

2022-06-28 Thread Stefan Karlsson
On Mon, 27 Jun 2022 22:19:35 GMT, Albert Mingkun Yang wrote: >> Simple rename and some comments update. >> >> Test: build > > Albert Mingkun Yang has updated the pull request incrementally with one > additional commit since the last revision: > > review Looks good. +1 on Kim's latest commen

Re: RFR: 8285364: Remove REF_ enum for java.lang.ref.Reference [v9]

2022-06-27 Thread Kim Barrett
On Mon, 27 Jun 2022 22:19:35 GMT, Albert Mingkun Yang wrote: >> Simple rename and some comments update. >> >> Test: build > > Albert Mingkun Yang has updated the pull request incrementally with one > additional commit since the last revision: > > review Looks good. Just a couple of minor "

Re: RFR: 8285364: Remove REF_ enum for java.lang.ref.Reference [v9]

2022-06-27 Thread Albert Mingkun Yang
> Simple rename and some comments update. > > Test: build Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision: review - Changes: - all: https://git.openjdk.org/jdk/pull/8332/files - new: https://git.openjdk.org/jd