Re: RFR: 8283627: Outdated comment in MachineDescriptionTwosComplement.isLP64 [v2]

2022-09-01 Thread Leonid Mesnik
On Thu, 1 Sep 2022 15:07:03 GMT, Daniel Skantz wrote: >> Update MachineDescriptionTwosComplement.java comment to indicate that LP64 >> machines are no longer uncommon. > > Daniel Skantz has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8

Re: RFR: 8283627: Outdated comment in MachineDescriptionTwosComplement.isLP64 [v2]

2022-09-01 Thread Chris Plummer
On Thu, 1 Sep 2022 15:07:03 GMT, Daniel Skantz wrote: >> Update MachineDescriptionTwosComplement.java comment to indicate that LP64 >> machines are no longer uncommon. > > Daniel Skantz has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8

Re: RFR: 8283627: Outdated comment in MachineDescriptionTwosComplement.isLP64 [v2]

2022-09-01 Thread Serguei Spitsyn
On Thu, 1 Sep 2022 15:07:03 GMT, Daniel Skantz wrote: >> Update MachineDescriptionTwosComplement.java comment to indicate that LP64 >> machines are no longer uncommon. > > Daniel Skantz has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8

Re: RFR: 8283627: Outdated comment in MachineDescriptionTwosComplement.isLP64 [v2]

2022-09-01 Thread Daniel Skantz
> Update MachineDescriptionTwosComplement.java comment to indicate that LP64 > machines are no longer uncommon. Daniel Skantz has updated the pull request incrementally with one additional commit since the last revision: JDK-8283627 - Update MachineDescription.java JDK-8283627 - Update c

Re: RFR: 8283627: Outdated comment in MachineDescriptionTwosComplement.isLP64

2022-08-31 Thread Serguei Spitsyn
On Mon, 22 Aug 2022 15:06:31 GMT, Daniel Skantz wrote: > Update MachineDescriptionTwosComplement.java comment to indicate that LP64 > machines are no longer uncommon. This correction looks okay modulo comment from Chris about one more place. Thanks, Serguei - Marked as reviewed by

Re: RFR: 8283627: Outdated comment in MachineDescriptionTwosComplement.isLP64

2022-08-27 Thread Chris Plummer
On Mon, 22 Aug 2022 15:06:31 GMT, Daniel Skantz wrote: > Update MachineDescriptionTwosComplement.java comment to indicate that LP64 > machines are no longer uncommon. How about this one in MachineDescription.java: /** Indicates whether the underlying machine supports the LP64 data mod

RFR: 8283627: Outdated comment in MachineDescriptionTwosComplement.isLP64

2022-08-27 Thread Daniel Skantz
Update MachineDescriptionTwosComplement.java comment to indicate that LP64 machines are no longer uncommon. - Commit messages: - JDK-8283627 Changes: https://git.openjdk.org/jdk/pull/9967/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9967&range=00 Issue: https://bugs.op