Re: RFR: 8280743: HSDB "Monitor Cache Dump" command might throw NPE [v2]

2023-08-23 Thread Chris Plummer
On Mon, 21 Aug 2023 21:26:11 GMT, Chris Plummer wrote: >> ObjectMonitor.object() can be null so we need to defend against it. This bug >> was discovered by code inspection while working on >> [JDK-8280555](https://bugs.openjdk.org/browse/JDK-8280555). We have no test >> for this, and I'm not

Re: RFR: 8280743: HSDB "Monitor Cache Dump" command might throw NPE [v2]

2023-08-22 Thread Serguei Spitsyn
On Mon, 21 Aug 2023 21:26:11 GMT, Chris Plummer wrote: >> ObjectMonitor.object() can be null so we need to defend against it. This bug >> was discovered by code inspection while working on >> [JDK-8280555](https://bugs.openjdk.org/browse/JDK-8280555). We have no test >> for this, and I'm not

Re: RFR: 8280743: HSDB "Monitor Cache Dump" command might throw NPE [v2]

2023-08-21 Thread Chris Plummer
On Mon, 21 Aug 2023 20:41:45 GMT, Kevin Walls wrote: > I see ObjectHeap accepts and handles a null, returning null, so the newOop() > call is OK to pass a null, though it could be moved to inside the else. Ok. I moved it inside the else block. - PR Comment: https://git.openjdk.org

Re: RFR: 8280743: HSDB "Monitor Cache Dump" command might throw NPE [v2]

2023-08-21 Thread Chris Plummer
> ObjectMonitor.object() can be null so we need to defend against it. This bug > was discovered by code inspection while working on > [JDK-8280555](https://bugs.openjdk.org/browse/JDK-8280555). We have no test > for this, and I'm not sure how to reproduce this with HSDB like the > [JDK-8280555