Re: RFR: 8280682: Refactor AOT code source validation checks [v2]

2025-02-19 Thread Calvin Cheung
On Wed, 19 Feb 2025 22:37:57 GMT, Calvin Cheung wrote: >> test/hotspot/jtreg/runtime/cds/appcds/BootClassPathMismatch.java line 243: >> >>> 241: * No error - bootclasspath can be appended during runtime if no >>> -cp is specified. >>> 242: */ >>> 243: public void testBootClassPath

Re: RFR: 8280682: Refactor AOT code source validation checks [v2]

2025-02-19 Thread Calvin Cheung
On Tue, 18 Feb 2025 05:21:09 GMT, Ashutosh Mehra wrote: >> Calvin Cheung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @iklam and @ashu-mehra comment > > src/hotspot/share/runtime/threads.cpp line 27: > >> 25: */ >> 26: >> 27: #incl

Re: RFR: 8280682: Refactor AOT code source validation checks [v2]

2025-02-19 Thread Calvin Cheung
On Tue, 18 Feb 2025 07:08:07 GMT, David Holmes wrote: >> Calvin Cheung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @iklam and @ashu-mehra comment > > src/hotspot/share/cds/aotCodeSource.cpp line 2: > >> 1: /* >> 2: * Copyright (c)

Re: RFR: 8280682: Refactor AOT code source validation checks [v2]

2025-02-17 Thread David Holmes
On Fri, 14 Feb 2025 19:21:32 GMT, Calvin Cheung wrote: >> This changset refactors CDS class paths and module paths validation code >> into a new class `AOTCodeSource` and related class `AOTCodeSourceConfig`. >> Code has been moved from filemap.[c|h]pp, classLoader.[c|h]pp, and >> classLoaderEx

Re: RFR: 8280682: Refactor AOT code source validation checks [v2]

2025-02-17 Thread Ashutosh Mehra
On Fri, 14 Feb 2025 19:21:32 GMT, Calvin Cheung wrote: >> This changset refactors CDS class paths and module paths validation code >> into a new class `AOTCodeSource` and related class `AOTCodeSourceConfig`. >> Code has been moved from filemap.[c|h]pp, classLoader.[c|h]pp, and >> classLoaderEx

Re: RFR: 8280682: Refactor AOT code source validation checks [v2]

2025-02-14 Thread Calvin Cheung
On Thu, 13 Feb 2025 03:55:50 GMT, Ashutosh Mehra wrote: >> Calvin Cheung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @iklam and @ashu-mehra comment > > src/hotspot/share/cds/aotCodeSource.cpp line 762: > >> 760: } >> 761: >> 762:

Re: RFR: 8280682: Refactor AOT code source validation checks [v2]

2025-02-14 Thread Calvin Cheung
On Tue, 11 Feb 2025 05:25:30 GMT, Ioi Lam wrote: >> Calvin Cheung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @iklam and @ashu-mehra comment > > src/hotspot/share/cds/aotCodeSource.cpp line 133: > >> 131: >> 132: // AllCodeSourceSt

Re: RFR: 8280682: Refactor AOT code source validation checks [v2]

2025-02-14 Thread Calvin Cheung
> This changset refactors CDS class paths and module paths validation code into > a new class `AOTCodeSource` and related class `AOTCodeSourceConfig`. Code has > been moved from filemap.[c|h]pp, classLoader.[c|h]pp, and > classLoaderExt.[c|h]pp to aotCodeSource.[c|h]pp. CDS dependencies have bee