On Mon, 24 Feb 2025 00:04:21 GMT, David Holmes wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> rename classes and add vm_exit_during_initialization call
>
> A couple of minor suggestions, but otherwise nothing fur
On Mon, 24 Feb 2025 18:43:27 GMT, Calvin Cheung wrote:
>> This changset refactors CDS class paths and module paths validation code
>> into a new class `AOTCodeSource` and related class `AOTCodeSourceConfig`.
>> Code has been moved from filemap.[c|h]pp, classLoader.[c|h]pp, and
>> classLoaderEx
On Sun, 23 Feb 2025 23:52:59 GMT, David Holmes wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> rename classes and add vm_exit_during_initialization call
>
> src/hotspot/share/cds/aotClassLocation.cpp line 53:
>
>
> This changset refactors CDS class paths and module paths validation code into
> a new class `AOTCodeSource` and related class `AOTCodeSourceConfig`. Code has
> been moved from filemap.[c|h]pp, classLoader.[c|h]pp, and
> classLoaderExt.[c|h]pp to aotCodeSource.[c|h]pp. CDS dependencies have bee
On Fri, 21 Feb 2025 06:19:55 GMT, Calvin Cheung wrote:
>> This changset refactors CDS class paths and module paths validation code
>> into a new class `AOTCodeSource` and related class `AOTCodeSourceConfig`.
>> Code has been moved from filemap.[c|h]pp, classLoader.[c|h]pp, and
>> classLoaderEx
On Fri, 21 Feb 2025 06:19:55 GMT, Calvin Cheung wrote:
>> This changset refactors CDS class paths and module paths validation code
>> into a new class `AOTCodeSource` and related class `AOTCodeSourceConfig`.
>> Code has been moved from filemap.[c|h]pp, classLoader.[c|h]pp, and
>> classLoaderEx
On Thu, 20 Feb 2025 00:35:51 GMT, Vladimir Kozlov wrote:
> Passing by comment. We touched it on recent Leyden meeting. The name
> "AOTCodeSource" is very confusing. Especially when we start caching AOT
> compiled code. Can we rename it to avoid confusion?
Per our discussions, I've renamed "AOT
On Thu, 20 Feb 2025 07:29:07 GMT, David Holmes wrote:
>> How about adding the vm_exit in
>> `ClassLoaderDataShared::ensure_module_entry_table_exist()` instead of assert?
>>
>>
>> void ClassLoaderDataShared::ensure_module_entry_table_exist(oop
>> class_loader) {
>> Handle h_loader(JavaThread
> This changset refactors CDS class paths and module paths validation code into
> a new class `AOTCodeSource` and related class `AOTCodeSourceConfig`. Code has
> been moved from filemap.[c|h]pp, classLoader.[c|h]pp, and
> classLoaderExt.[c|h]pp to aotCodeSource.[c|h]pp. CDS dependencies have bee
On Thu, 20 Feb 2025 07:11:19 GMT, Calvin Cheung wrote:
>> I don't see anything there that does a vm_exit if something has gone wrong.
>> ??
>
> How about adding the vm_exit in
> `ClassLoaderDataShared::ensure_module_entry_table_exist()` instead of assert?
>
>
> void ClassLoaderDataShared::ens
On Thu, 20 Feb 2025 02:15:01 GMT, David Holmes wrote:
>> It is now being handled in
>> `ClassLoaderDataShared::ensure_module_entry_tables_exist()` and
>> `AOTCodeSourceConfig::dumptime_init_helper()`.
>
> I don't see anything there that does a vm_exit if something has gone wrong. ??
How about
On Wed, 19 Feb 2025 22:37:48 GMT, Calvin Cheung wrote:
>> src/hotspot/share/runtime/threads.cpp line 809:
>>
>>> 807:
>>> vm_exit_during_initialization("ClassLoader::initialize_module_path() failed
>>> unexpectedly");
>>> 808: }
>>> 809: #endif
>>
>> Not obvious where this functionality
> This changset refactors CDS class paths and module paths validation code into
> a new class `AOTCodeSource` and related class `AOTCodeSourceConfig`. Code has
> been moved from filemap.[c|h]pp, classLoader.[c|h]pp, and
> classLoaderExt.[c|h]pp to aotCodeSource.[c|h]pp. CDS dependencies have bee
On Thu, 20 Feb 2025 00:18:36 GMT, Calvin Cheung wrote:
>> This changset refactors CDS class paths and module paths validation code
>> into a new class `AOTCodeSource` and related class `AOTCodeSourceConfig`.
>> Code has been moved from filemap.[c|h]pp, classLoader.[c|h]pp, and
>> classLoaderEx
On Wed, 19 Feb 2025 22:37:57 GMT, Calvin Cheung wrote:
>> test/hotspot/jtreg/runtime/cds/appcds/BootClassPathMismatch.java line 243:
>>
>>> 241: * No error - bootclasspath can be appended during runtime if no
>>> -cp is specified.
>>> 242: */
>>> 243: public void testBootClassPath
On Tue, 18 Feb 2025 07:22:00 GMT, David Holmes wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @ashu-mehra and @dholmes-ora comments
>
> src/hotspot/share/runtime/threads.cpp line 809:
>
>> 807:
>> vm_exit_d
On Tue, 18 Feb 2025 05:21:09 GMT, Ashutosh Mehra wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @iklam and @ashu-mehra comment
>
> src/hotspot/share/runtime/threads.cpp line 27:
>
>> 25: */
>> 26:
>> 27: #incl
On Tue, 18 Feb 2025 07:08:07 GMT, David Holmes wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @iklam and @ashu-mehra comment
>
> src/hotspot/share/cds/aotCodeSource.cpp line 2:
>
>> 1: /*
>> 2: * Copyright (c)
> This changset refactors CDS class paths and module paths validation code into
> a new class `AOTCodeSource` and related class `AOTCodeSourceConfig`. Code has
> been moved from filemap.[c|h]pp, classLoader.[c|h]pp, and
> classLoaderExt.[c|h]pp to aotCodeSource.[c|h]pp. CDS dependencies have bee
On Fri, 14 Feb 2025 19:21:32 GMT, Calvin Cheung wrote:
>> This changset refactors CDS class paths and module paths validation code
>> into a new class `AOTCodeSource` and related class `AOTCodeSourceConfig`.
>> Code has been moved from filemap.[c|h]pp, classLoader.[c|h]pp, and
>> classLoaderEx
On Fri, 14 Feb 2025 19:21:32 GMT, Calvin Cheung wrote:
>> This changset refactors CDS class paths and module paths validation code
>> into a new class `AOTCodeSource` and related class `AOTCodeSourceConfig`.
>> Code has been moved from filemap.[c|h]pp, classLoader.[c|h]pp, and
>> classLoaderEx
On Thu, 13 Feb 2025 03:55:50 GMT, Ashutosh Mehra wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @iklam and @ashu-mehra comment
>
> src/hotspot/share/cds/aotCodeSource.cpp line 762:
>
>> 760: }
>> 761:
>> 762:
On Tue, 11 Feb 2025 05:25:30 GMT, Ioi Lam wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @iklam and @ashu-mehra comment
>
> src/hotspot/share/cds/aotCodeSource.cpp line 133:
>
>> 131:
>> 132: // AllCodeSourceSt
> This changset refactors CDS class paths and module paths validation code into
> a new class `AOTCodeSource` and related class `AOTCodeSourceConfig`. Code has
> been moved from filemap.[c|h]pp, classLoader.[c|h]pp, and
> classLoaderExt.[c|h]pp to aotCodeSource.[c|h]pp. CDS dependencies have bee
On Wed, 5 Feb 2025 22:32:58 GMT, Calvin Cheung wrote:
> This changset refactors CDS class paths and module paths validation code into
> a new class `AOTCodeSource` and related class `AOTCodeSourceConfig`. Code has
> been moved from filemap.[c|h]pp, classLoader.[c|h]pp, and
> classLoaderExt.[c|
On Wed, 5 Feb 2025 22:32:58 GMT, Calvin Cheung wrote:
> This changset refactors CDS class paths and module paths validation code into
> a new class `AOTCodeSource` and related class `AOTCodeSourceConfig`. Code has
> been moved from filemap.[c|h]pp, classLoader.[c|h]pp, and
> classLoaderExt.[c|
This changset refactors CDS class paths and module paths validation code into a
new class `AOTCodeSource` and related class `AOTCodeSourceConfig`. Code has
been moved from filemap.[c|h]pp, classLoader.[c|h]pp, and
classLoaderExt.[c|h]pp to aotCodeSource.[c|h]pp. CDS dependencies have been
remov
27 matches
Mail list logo
