Re: RFR: 8257967: JFR: Events for loaded agents [v4]

2023-04-17 Thread Markus Grönlund
On Thu, 9 Mar 2023 00:23:39 GMT, David Holmes wrote: >> No need to load any JFR classes. No change to startup logic. > >> No need to load any JFR classes. > > I thought JFR was all Java-based these days. But if no Java involved then > that is good. > >> No change to startup logic. > > I flag

Re: RFR: 8257967: JFR: Events for loaded agents [v4]

2023-03-09 Thread Markus Grönlund
On Thu, 9 Mar 2023 09:36:28 GMT, Andrew Dinn wrote: > Yes, I appreciate that `dynamic` can be derived from `initializationMethod` > -- and vice versa. However, I was approaching this semantically from the > opposite end. To me the primary characteristic that the user would be > interested in i

Re: RFR: 8257967: JFR: Events for loaded agents [v4]

2023-03-09 Thread Andrew Dinn
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- On Wed, 8 Mar 2023 18:56:55 GMT, Markus Grönlund wr

Re: RFR: 8257967: JFR: Events for loaded agents [v4]

2023-03-09 Thread Markus Grönlund
On Thu, 9 Mar 2023 00:23:39 GMT, David Holmes wrote: > > No need to load any JFR classes. > > I thought JFR was all Java-based these days. But if no Java involved then > that is good. Ehh, no. Far from it. > > No change to startup logic. > > I flagged a change in my comment above. Thanks, p

Re: RFR: 8257967: JFR: Events for loaded agents [v4]

2023-03-09 Thread Markus Grönlund
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- On Wed, 8 Mar 2023 22:56:31 GMT, David Holmes wrote

Re: RFR: 8257967: JFR: Events for loaded agents [v4]

2023-03-09 Thread Markus Grönlund
On Wed, 8 Mar 2023 23:28:52 GMT, Markus Grönlund wrote: >> Markus Grönlund has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - remove JVMPI >> - cleanup > > No need to load any JFR classes. No change to startup logic. > @mgronlun Why mar

Re: RFR: 8257967: JFR: Events for loaded agents [v4]

2023-03-09 Thread Andrew Dinn
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- On Wed, 8 Mar 2023 23:28:52 GMT, Markus Grönlund wr

Re: RFR: 8257967: JFR: Events for loaded agents [v4]

2023-03-08 Thread David Holmes
On Wed, 8 Mar 2023 23:28:52 GMT, Markus Grönlund wrote: > No need to load any JFR classes. I thought JFR was all Java-based these days. But if no Java involved then that is good. > No change to startup logic. I flagged a change in my comment above. - PR: https://git.openjdk.org

Re: RFR: 8257967: JFR: Events for loaded agents [v4]

2023-03-08 Thread Markus Grönlund
On Wed, 8 Mar 2023 18:56:55 GMT, Markus Grönlund wrote: >> Greetings, >> >> We are adding support to let JFR report on Agents. >> >> Design >> >> An Agent is a library that uses any instrumentation or profiling APIs. Most >> agents are started and initialized on the command line, but age

Re: RFR: 8257967: JFR: Events for loaded agents [v4]

2023-03-08 Thread David Holmes
On Wed, 8 Mar 2023 18:56:55 GMT, Markus Grönlund wrote: >> Greetings, >> >> We are adding support to let JFR report on Agents. >> >> Design >> >> An Agent is a library that uses any instrumentation or profiling APIs. Most >> agents are started and initialized on the command line, but age

Re: RFR: 8257967: JFR: Events for loaded agents [v4]

2023-03-08 Thread Markus Grönlund
> Greetings, > > We are adding support to let JFR report on Agents. > > Design > > An Agent is a library that uses any instrumentation or profiling APIs. Most > agents are started and initialized on the command line, but agents can also > be loaded dynamically during runtime. Because comm