Re: RFR: 8257967: JFR: Events for loaded agents [v17]

2023-04-17 Thread Markus Grönlund
On Fri, 14 Apr 2023 22:22:13 GMT, Serguei Spitsyn wrote: >> Ok. the terminology here might be confusing. The concept of an agent being >> "initialized" is introduced and reported by JFR. For example, here is the >> JFR event type definition for a NativeAgent: >> ``` >> > label="Native Agent"

Re: RFR: 8257967: JFR: Events for loaded agents [v17]

2023-04-14 Thread Serguei Spitsyn
On Fri, 14 Apr 2023 09:20:18 GMT, Markus Grönlund wrote: >> src/hotspot/share/prims/jvmtiExport.cpp line 717: >> >>> 715: jvmtiEventVMInit callback = env->callbacks()->VMInit; >>> 716: if (callback != nullptr) { >>> 717: JvmtiAgent* const agent = lookup_uninitialized_agent(en

Re: RFR: 8257967: JFR: Events for loaded agents [v17]

2023-04-14 Thread Markus Grönlund
On Fri, 14 Apr 2023 07:50:39 GMT, Serguei Spitsyn wrote: > Markus, It looks good to me. Overall, it is a nice consolidation of the agent > code, good move in general! Thank you for your patience. I've posted one > minor request though. Thanks, Serguei Thanks for taking a look Serguei, apprecia

Re: RFR: 8257967: JFR: Events for loaded agents [v17]

2023-04-14 Thread Markus Grönlund
On Fri, 14 Apr 2023 07:43:23 GMT, Serguei Spitsyn wrote: >> Markus Grönlund has updated the pull request incrementally with one >> additional commit since the last revision: >> >> line breaks > > src/hotspot/share/prims/jvmtiExport.cpp line 717: > >> 715: jvmtiEventVMInit callback = en

Re: RFR: 8257967: JFR: Events for loaded agents [v17]

2023-04-14 Thread Serguei Spitsyn
On Thu, 13 Apr 2023 12:16:16 GMT, Markus Grönlund wrote: >> Greetings, >> >> We are adding support to let JFR report on Agents. >> >> Design >> >> An Agent is a library that uses any instrumentation or profiling APIs. Most >> agents are started and initialized on the command line, but ag

Re: RFR: 8257967: JFR: Events for loaded agents [v17]

2023-04-14 Thread Serguei Spitsyn
On Thu, 13 Apr 2023 12:16:16 GMT, Markus Grönlund wrote: >> Greetings, >> >> We are adding support to let JFR report on Agents. >> >> Design >> >> An Agent is a library that uses any instrumentation or profiling APIs. Most >> agents are started and initialized on the command line, but ag

Re: RFR: 8257967: JFR: Events for loaded agents [v17]

2023-04-14 Thread Serguei Spitsyn
On Thu, 13 Apr 2023 12:16:16 GMT, Markus Grönlund wrote: >> Greetings, >> >> We are adding support to let JFR report on Agents. >> >> Design >> >> An Agent is a library that uses any instrumentation or profiling APIs. Most >> agents are started and initialized on the command line, but ag

Re: RFR: 8257967: JFR: Events for loaded agents [v17]

2023-04-13 Thread Markus Grönlund
> Greetings, > > We are adding support to let JFR report on Agents. > > Design > > An Agent is a library that uses any instrumentation or profiling APIs. Most > agents are started and initialized on the command line, but agents can also > be loaded dynamically during runtime. Because comm