On Thu, 13 Apr 2023 10:24:55 GMT, Serguei Spitsyn wrote:
>> Markus Grönlund has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> renames
>
> src/hotspot/share/prims/jvmtiAgentList.cpp line 72:
>
>> 70: // there exist an order requirement to
On Thu, 13 Apr 2023 10:15:02 GMT, Serguei Spitsyn wrote:
> Your fix introduced a hidden dependency of this new structure on the
> JPLISEnvironment structure and some Java agents implementation details:
>
> ```
> 202 struct JPLISEnvironmentMirror {
> 203 jvmtiEnv* mJVMTIEnv; // the JVMTI envir
On Thu, 13 Apr 2023 10:07:50 GMT, Serguei Spitsyn wrote:
> What was the reason to clone the classes below ?:
> `JvmtiJavaThreadEventTransition` => `AgentJavaThreadEventTransition`
> `JvmtiThreadEventMark` => `AgentThreadEventMark` `JvmtiEventMark` =>
> `AgentEventMark`
The reason is they are
On Tue, 4 Apr 2023 14:39:19 GMT, Markus Grönlund wrote:
>> Greetings,
>>
>> We are adding support to let JFR report on Agents.
>>
>> Design
>>
>> An Agent is a library that uses any instrumentation or profiling APIs. Most
>> agents are started and initialized on the command line, but age
On Tue, 4 Apr 2023 14:39:19 GMT, Markus Grönlund wrote:
>> Greetings,
>>
>> We are adding support to let JFR report on Agents.
>>
>> Design
>>
>> An Agent is a library that uses any instrumentation or profiling APIs. Most
>> agents are started and initialized on the command line, but age
On Tue, 4 Apr 2023 14:39:19 GMT, Markus Grönlund wrote:
>> Greetings,
>>
>> We are adding support to let JFR report on Agents.
>>
>> Design
>>
>> An Agent is a library that uses any instrumentation or profiling APIs. Most
>> agents are started and initialized on the command line, but age
On Wed, 12 Apr 2023 10:43:31 GMT, Markus Grönlund wrote:
>> src/hotspot/share/prims/jvmtiAgent.cpp line 323:
>>
>>> 321: assert(agent != nullptr, "invariant");
>>> 322: if (!agent->is_loaded()) {
>>> 323: if (!load_agent_from_executable(agent, on_load_symbols,
>>> num_symbol_entries)) {
On Wed, 12 Apr 2023 11:01:43 GMT, Serguei Spitsyn wrote:
>> Markus Grönlund has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> renames
>
> src/hotspot/share/prims/jvmtiAgent.cpp line 357:
>
>> 355: vm_exit_during_initialization("Coul
On Tue, 4 Apr 2023 14:39:19 GMT, Markus Grönlund wrote:
>> Greetings,
>>
>> We are adding support to let JFR report on Agents.
>>
>> Design
>>
>> An Agent is a library that uses any instrumentation or profiling APIs. Most
>> agents are started and initialized on the command line, but age
On Tue, 4 Apr 2023 14:39:19 GMT, Markus Grönlund wrote:
>> Greetings,
>>
>> We are adding support to let JFR report on Agents.
>>
>> Design
>>
>> An Agent is a library that uses any instrumentation or profiling APIs. Most
>> agents are started and initialized on the command line, but age
On Wed, 12 Apr 2023 10:31:37 GMT, Serguei Spitsyn wrote:
>> Markus Grönlund has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> renames
>
> src/hotspot/share/prims/jvmtiAgent.cpp line 323:
>
>> 321: assert(agent != nullptr, "invariant");
On Tue, 4 Apr 2023 14:39:19 GMT, Markus Grönlund wrote:
>> Greetings,
>>
>> We are adding support to let JFR report on Agents.
>>
>> Design
>>
>> An Agent is a library that uses any instrumentation or profiling APIs. Most
>> agents are started and initialized on the command line, but age
On Tue, 4 Apr 2023 14:39:19 GMT, Markus Grönlund wrote:
>> Greetings,
>>
>> We are adding support to let JFR report on Agents.
>>
>> Design
>>
>> An Agent is a library that uses any instrumentation or profiling APIs. Most
>> agents are started and initialized on the command line, but age
On Tue, 11 Apr 2023 16:56:49 GMT, Serguei Spitsyn wrote:
> > Can I please get a second review to close this one out?
>
> Markus, I'm still working on it and close to finish. I have some questions to
> ask. In fact, I gave up to prove this refactoring does not break anything.
> So, we should re
On Tue, 11 Apr 2023 12:33:32 GMT, Markus Grönlund wrote:
> Can I please get a second review to close this one out?
Markus, I'm still working on it and close to finish. I have some questions to
ask.
In fact, I gave up to prove this refactoring does not break anything.
So, we should rely on testi
On Tue, 4 Apr 2023 14:39:19 GMT, Markus Grönlund wrote:
>> Greetings,
>>
>> We are adding support to let JFR report on Agents.
>>
>> Design
>>
>> An Agent is a library that uses any instrumentation or profiling APIs. Most
>> agents are started and initialized on the command line, but age
On Wed, 5 Apr 2023 01:48:19 GMT, David Holmes wrote:
> Renamings look good to me.
Thank you for your review!
-
PR Comment: https://git.openjdk.org/jdk/pull/12923#issuecomment-1497209787
On Tue, 4 Apr 2023 14:39:19 GMT, Markus Grönlund wrote:
>> Greetings,
>>
>> We are adding support to let JFR report on Agents.
>>
>> Design
>>
>> An Agent is a library that uses any instrumentation or profiling APIs. Most
>> agents are started and initialized on the command line, but age
> Greetings,
>
> We are adding support to let JFR report on Agents.
>
> Design
>
> An Agent is a library that uses any instrumentation or profiling APIs. Most
> agents are started and initialized on the command line, but agents can also
> be loaded dynamically during runtime. Because comm
19 matches
Mail list logo
