On Wed, 5 Apr 2023 06:55:16 GMT, Serguei Spitsyn wrote:
>> I changed the names because I found it very hard to understand what the old
>> names represented: "AgentLibrary" vs "Library"? "add_init_agent" vs
>> "add_instrumentation_agent", or even "add_loaded_agent"? Also a bit
>> confusing that
On Mon, 3 Apr 2023 12:59:12 GMT, Markus Grönlund wrote:
>> src/hotspot/share/prims/agentList.cpp line 204:
>>
>>> 202:
>>> 203: // Invokes Agent_OnAttach for agents loaded dynamically during runtime.
>>> 204: jint AgentList::load_agent(const char* agent_name, const char*
>>> absParam,
>>
>> I
On Tue, 4 Apr 2023 14:41:13 GMT, Markus Grönlund wrote:
>> src/hotspot/share/prims/agent.hpp line 1:
>>
>>> 1: /*
>>
>> The name for class and file is too general.
>> I'm thinking if renaming the files to jvmtiAgent and the class to JvmtiAgent
>> would work.
>> In general, there exists a conve
On Sat, 1 Apr 2023 03:31:48 GMT, Serguei Spitsyn wrote:
>> Markus Grönlund has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixes
>
> src/hotspot/share/prims/agent.hpp line 1:
>
>> 1: /*
>
> The name for class and file is too general.
>
On Sat, 1 Apr 2023 03:47:26 GMT, Serguei Spitsyn wrote:
>> Markus Grönlund has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixes
>
> src/hotspot/share/prims/agentList.cpp line 204:
>
>> 202:
>> 203: // Invokes Agent_OnAttach for agents
On Fri, 31 Mar 2023 11:18:23 GMT, Markus Grönlund wrote:
>> Greetings,
>>
>> We are adding support to let JFR report on Agents.
>>
>> Design
>>
>> An Agent is a library that uses any instrumentation or profiling APIs. Most
>> agents are started and initialized on the command line, but ag
On Fri, 31 Mar 2023 11:18:23 GMT, Markus Grönlund wrote:
>> Greetings,
>>
>> We are adding support to let JFR report on Agents.
>>
>> Design
>>
>> An Agent is a library that uses any instrumentation or profiling APIs. Most
>> agents are started and initialized on the command line, but ag
> Greetings,
>
> We are adding support to let JFR report on Agents.
>
> Design
>
> An Agent is a library that uses any instrumentation or profiling APIs. Most
> agents are started and initialized on the command line, but agents can also
> be loaded dynamically during runtime. Because comm
