Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v4]

2022-06-28 Thread Zhengyu Gu
On Mon, 27 Jun 2022 20:56:26 GMT, Chris Plummer wrote: >> Zhengyu Gu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> v5 > > src/jdk.jdwp.agent/share/native/libjdwp/classTrack.c line 48: > >> 46: static jvmtiEnv* trackingEnv; >> 47: >>

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v4]

2022-06-27 Thread Chris Plummer
On Mon, 27 Jun 2022 17:02:04 GMT, Zhengyu Gu wrote: >> Currently, jdi only check and process class unloading event when it detects >> a new GC cycle. >> >> After [JDK-8212879](https://bugs.openjdk.org/browse/JDK-8212879), posting >> class events can overlap with GC finish event, that results,

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v4]

2022-06-27 Thread Zhengyu Gu
On Mon, 27 Jun 2022 15:50:47 GMT, Coleen Phillimore wrote: >> src/hotspot/share/prims/jvmtiTagMap.cpp line 1200: >> >>> 1198: }; >>> 1199: >>> 1200: // PostObjectFree can't be called by JavaThread, so call it from the >>> VM thread. >> >> I wish I'd written why here. I think it's because we

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v4]

2022-06-27 Thread Zhengyu Gu
> Currently, jdi only check and process class unloading event when it detects a > new GC cycle. > > After [JDK-8212879](https://bugs.openjdk.org/browse/JDK-8212879), posting > class events can overlap with GC finish event, that results, sometimes, it > only captures partial or even empty unload