Re: RFR: 8236736: Change notproduct JVM flags to develop flags [v4]

2024-04-03 Thread Coleen Phillimore
On Tue, 2 Apr 2024 19:47:23 GMT, Coleen Phillimore wrote: >> Remove the notproduct distinction for command line options, rather than >> trying to wrestle the macros to fix the bug that they've been treated as >> develop options for some time now. This simplifies the command line option >> mac

Re: RFR: 8236736: Change notproduct JVM flags to develop flags [v4]

2024-04-02 Thread Ioi Lam
On Tue, 2 Apr 2024 20:18:34 GMT, Kim Barrett wrote: > > Thanks for reviewing, Kim. Is your suggestion to not have a JVMFlag object > > for develop flags in PRODUCT builds? Presumably to save some footprint? I'm > > not sure we would win fighting the macros to accomplish this. > > Yes, that's t

Re: RFR: 8236736: Change notproduct JVM flags to develop flags [v4]

2024-04-02 Thread Kim Barrett
On Tue, 2 Apr 2024 19:51:03 GMT, Coleen Phillimore wrote: > Thanks for reviewing, Kim. Is your suggestion to not have a JVMFlag object > for develop flags in PRODUCT builds? Presumably to save some footprint? I'm > not sure we would win fighting the macros to accomplish this. Yes, that's the s

Re: RFR: 8236736: Change notproduct JVM flags to develop flags [v4]

2024-04-02 Thread Coleen Phillimore
On Tue, 2 Apr 2024 19:47:23 GMT, Coleen Phillimore wrote: >> Remove the notproduct distinction for command line options, rather than >> trying to wrestle the macros to fix the bug that they've been treated as >> develop options for some time now. This simplifies the command line option >> mac

Re: RFR: 8236736: Change notproduct JVM flags to develop flags [v4]

2024-04-02 Thread Coleen Phillimore
> Remove the notproduct distinction for command line options, rather than > trying to wrestle the macros to fix the bug that they've been treated as > develop options for some time now. This simplifies the command line option > macros. > > Tested with tier1-4, tier1 on Oracle platforms. Also