Re: RFR: 8236736: Change notproduct JVM flags to develop flags [v3]

2024-04-02 Thread Coleen Phillimore
On Tue, 2 Apr 2024 17:58:16 GMT, Kim Barrett wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix a couple issues pointed out by Stefank. > > test/hotspot/jtreg/runtime/CommandLine/VMOptionWarning.java line 64:

Re: RFR: 8236736: Change notproduct JVM flags to develop flags [v3]

2024-04-02 Thread Kim Barrett
On Tue, 2 Apr 2024 17:25:12 GMT, Coleen Phillimore wrote: >> Remove the notproduct distinction for command line options, rather than >> trying to wrestle the macros to fix the bug that they've been treated as >> develop options for some time now. This simplifies the command line option >> mac

Re: RFR: 8236736: Change notproduct JVM flags to develop flags [v3]

2024-04-02 Thread Vladimir Kozlov
On Tue, 2 Apr 2024 17:25:12 GMT, Coleen Phillimore wrote: >> Remove the notproduct distinction for command line options, rather than >> trying to wrestle the macros to fix the bug that they've been treated as >> develop options for some time now. This simplifies the command line option >> mac

Re: RFR: 8236736: Change notproduct JVM flags to develop flags [v3]

2024-04-02 Thread Coleen Phillimore
On Tue, 2 Apr 2024 17:25:12 GMT, Coleen Phillimore wrote: >> Remove the notproduct distinction for command line options, rather than >> trying to wrestle the macros to fix the bug that they've been treated as >> develop options for some time now. This simplifies the command line option >> mac

Re: RFR: 8236736: Change notproduct JVM flags to develop flags [v3]

2024-04-02 Thread Vladimir Kozlov
On Tue, 2 Apr 2024 17:58:47 GMT, Coleen Phillimore wrote: > For optimized, all the develop and notproduct options are materialized. Okay, I see what you did here. You touched only flags declaration and did not `#ifndef PRODUCT` which guards statistics code, for example. Optimized VM build will

Re: RFR: 8236736: Change notproduct JVM flags to develop flags [v3]

2024-04-02 Thread Vladimir Kozlov
On Tue, 2 Apr 2024 17:25:12 GMT, Coleen Phillimore wrote: >> Remove the notproduct distinction for command line options, rather than >> trying to wrestle the macros to fix the bug that they've been treated as >> develop options for some time now. This simplifies the command line option >> mac

Re: RFR: 8236736: Change notproduct JVM flags to develop flags [v3]

2024-04-02 Thread Coleen Phillimore
On Tue, 2 Apr 2024 17:25:12 GMT, Coleen Phillimore wrote: >> Remove the notproduct distinction for command line options, rather than >> trying to wrestle the macros to fix the bug that they've been treated as >> develop options for some time now. This simplifies the command line option >> mac

Re: RFR: 8236736: Change notproduct JVM flags to develop flags [v3]

2024-04-02 Thread Vladimir Kozlov
On Tue, 2 Apr 2024 17:25:12 GMT, Coleen Phillimore wrote: >> Remove the notproduct distinction for command line options, rather than >> trying to wrestle the macros to fix the bug that they've been treated as >> develop options for some time now. This simplifies the command line option >> mac

Re: RFR: 8236736: Change notproduct JVM flags to develop flags [v3]

2024-04-02 Thread Coleen Phillimore
> Remove the notproduct distinction for command line options, rather than > trying to wrestle the macros to fix the bug that they've been treated as > develop options for some time now. This simplifies the command line option > macros. > > Tested with tier1-4, tier1 on Oracle platforms. Also