On Tue, 2 Apr 2024 19:47:23 GMT, Coleen Phillimore wrote:
>> Remove the notproduct distinction for command line options, rather than
>> trying to wrestle the macros to fix the bug that they've been treated as
>> develop options for some time now. This simplifies the command line option
>> mac
On Tue, 2 Apr 2024 20:18:34 GMT, Kim Barrett wrote:
> > Thanks for reviewing, Kim. Is your suggestion to not have a JVMFlag object
> > for develop flags in PRODUCT builds? Presumably to save some footprint? I'm
> > not sure we would win fighting the macros to accomplish this.
>
> Yes, that's t
On Tue, 2 Apr 2024 19:51:03 GMT, Coleen Phillimore wrote:
> Thanks for reviewing, Kim. Is your suggestion to not have a JVMFlag object
> for develop flags in PRODUCT builds? Presumably to save some footprint? I'm
> not sure we would win fighting the macros to accomplish this.
Yes, that's the s
On Tue, 2 Apr 2024 19:47:23 GMT, Coleen Phillimore wrote:
>> Remove the notproduct distinction for command line options, rather than
>> trying to wrestle the macros to fix the bug that they've been treated as
>> develop options for some time now. This simplifies the command line option
>> mac
> Remove the notproduct distinction for command line options, rather than
> trying to wrestle the macros to fix the bug that they've been treated as
> develop options for some time now. This simplifies the command line option
> macros.
>
> Tested with tier1-4, tier1 on Oracle platforms. Also
On Tue, 2 Apr 2024 17:58:16 GMT, Kim Barrett wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix a couple issues pointed out by Stefank.
>
> test/hotspot/jtreg/runtime/CommandLine/VMOptionWarning.java line 64:
On Tue, 2 Apr 2024 17:25:12 GMT, Coleen Phillimore wrote:
>> Remove the notproduct distinction for command line options, rather than
>> trying to wrestle the macros to fix the bug that they've been treated as
>> develop options for some time now. This simplifies the command line option
>> mac
On Tue, 2 Apr 2024 17:25:12 GMT, Coleen Phillimore wrote:
>> Remove the notproduct distinction for command line options, rather than
>> trying to wrestle the macros to fix the bug that they've been treated as
>> develop options for some time now. This simplifies the command line option
>> mac
On Tue, 2 Apr 2024 17:25:12 GMT, Coleen Phillimore wrote:
>> Remove the notproduct distinction for command line options, rather than
>> trying to wrestle the macros to fix the bug that they've been treated as
>> develop options for some time now. This simplifies the command line option
>> mac
On Tue, 2 Apr 2024 17:58:47 GMT, Coleen Phillimore wrote:
> For optimized, all the develop and notproduct options are materialized.
Okay, I see what you did here. You touched only flags declaration and did not
`#ifndef PRODUCT` which guards statistics code, for example. Optimized VM build
will
On Tue, 2 Apr 2024 17:25:12 GMT, Coleen Phillimore wrote:
>> Remove the notproduct distinction for command line options, rather than
>> trying to wrestle the macros to fix the bug that they've been treated as
>> develop options for some time now. This simplifies the command line option
>> mac
On Tue, 2 Apr 2024 17:25:12 GMT, Coleen Phillimore wrote:
>> Remove the notproduct distinction for command line options, rather than
>> trying to wrestle the macros to fix the bug that they've been treated as
>> develop options for some time now. This simplifies the command line option
>> mac
On Tue, 2 Apr 2024 17:25:12 GMT, Coleen Phillimore wrote:
>> Remove the notproduct distinction for command line options, rather than
>> trying to wrestle the macros to fix the bug that they've been treated as
>> develop options for some time now. This simplifies the command line option
>> mac
> Remove the notproduct distinction for command line options, rather than
> trying to wrestle the macros to fix the bug that they've been treated as
> develop options for some time now. This simplifies the command line option
> macros.
>
> Tested with tier1-4, tier1 on Oracle platforms. Also
On Tue, 2 Apr 2024 16:49:19 GMT, Stefan Karlsson wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Clean up notproduct from tests.
>
> src/hotspot/share/runtime/arguments.cpp line 3420:
>
>> 3418: static void a
On Tue, 2 Apr 2024 16:24:19 GMT, Coleen Phillimore wrote:
>> Remove the notproduct distinction for command line options, rather than
>> trying to wrestle the macros to fix the bug that they've been treated as
>> develop options for some time now. This simplifies the command line option
>> mac
On Tue, 2 Apr 2024 16:24:19 GMT, Coleen Phillimore wrote:
>> Remove the notproduct distinction for command line options, rather than
>> trying to wrestle the macros to fix the bug that they've been treated as
>> develop options for some time now. This simplifies the command line option
>> mac
On Tue, 2 Apr 2024 16:21:15 GMT, Coleen Phillimore wrote:
>> Remove the notproduct distinction for command line options, rather than
>> trying to wrestle the macros to fix the bug that they've been treated as
>> develop options for some time now. This simplifies the command line option
>> mac
On Thu, 28 Mar 2024 22:53:22 GMT, Coleen Phillimore wrote:
> Remove the notproduct distinction for command line options, rather than
> trying to wrestle the macros to fix the bug that they've been treated as
> develop options for some time now. This simplifies the command line option
> macros
> Remove the notproduct distinction for command line options, rather than
> trying to wrestle the macros to fix the bug that they've been treated as
> develop options for some time now. This simplifies the command line option
> macros.
>
> Tested with tier1-4, tier1 on Oracle platforms. Also
On Thu, 28 Mar 2024 22:53:22 GMT, Coleen Phillimore wrote:
> Remove the notproduct distinction for command line options, rather than
> trying to wrestle the macros to fix the bug that they've been treated as
> develop options for some time now. This simplifies the command line option
> macros
Remove the notproduct distinction for command line options, rather than trying
to wrestle the macros to fix the bug that they've been treated as develop
options for some time now. This simplifies the command line option macros.
Tested with tier1-4, tier1 on Oracle platforms. Also built shenand
22 matches
Mail list logo
