On Tue, 28 Nov 2023 12:48:14 GMT, Thomas Stuefe wrote:
> > >
> >
> >
> > @tstuefe 3rd parameter to pass the either of 2 things:
> > ```
> > 1. The JvmTiAgent object "agent", so that after shifting the
> > save_library_signature to os_aix,we can still access the agent object.->
> > For this i
On Tue, 28 Nov 2023 11:08:43 GMT, Thomas Stuefe wrote:
> > > > > i would have to repeat the line 1132 and 1139 in os_aix.cpp again ,
> > > > > if the condition fails for .so files, because i have to reload it
> > > > > again and check if the .a exists. In the shared code i had repeat
> > > > >
On Mon, 27 Nov 2023 11:36:02 GMT, suchismith1993 wrote:
> > > i would have to repeat the line 1132 and 1139 in os_aix.cpp again , if
> > > the condition fails for .so files, because i have to reload it again and
> > > check if the .a exists. In the shared code
On Fri, 24 Nov 2023 14:04:07 GMT, Thomas Stuefe wrote:
> > > i would have to repeat the line 1132 and 1139 in os_aix.cpp again , if
> > > the condition fails for .so files, because i have to reload it again and
> > > check if the .a exists. In the shared code i had repeat less number of
> > >
On Fri, 24 Nov 2023 14:04:07 GMT, Thomas Stuefe wrote:
> > > i would have to repeat the line 1132 and 1139 in os_aix.cpp again , if
> > > the condition fails for .so files, because i have to reload it again and
> > > check if the .a exists. In the shared code i had repeat less number of
> > >
On Thu, 23 Nov 2023 06:03:15 GMT, Thomas Stuefe wrote:
>> suchismith1993 has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> change macro position
>
> src/hotspot/os/aix/os_aix.cpp line 3065:
>
>&
On Thu, 23 Nov 2023 18:26:56 GMT, suchismith1993 wrote:
> > > > I'm not a big fan of this approach. We accumulate more and more "#ifdef
> > > > AIX" in shared code because of many recent AIX additions. No other
> > > > platform has such a la
On Thu, 23 Nov 2023 18:03:33 GMT, Thomas Stuefe wrote:
> > > I'm not a big fan of this approach. We accumulate more and more "#ifdef
> > > AIX" in shared code because of many recent AIX additions. No other
> > > platform has such a large ifdef footprint in shared code.
> > > I argue that all of
On Wed, 22 Nov 2023 16:24:24 GMT, suchismith1993 wrote:
>> J2SE agent does not start and throws error when it tries to find the shared
>> library ibm_16_am.
>> After searching for ibm_16_am.so ,the jvm agent throws and error as dll_load
>> fails.It fails to ide
On Thu, 23 Nov 2023 06:16:54 GMT, Thomas Stuefe wrote:
> If .a is a valid shared object format on AIX, this should be handled in
> `os::dll_load()`, and be done for all shared objects. If not, why do we try
> to load a static archive via dlload in this case but not in other cases?
In AIX, we
On Thu, 23 Nov 2023 05:49:41 GMT, Amit Kumar wrote:
> #16490
The JBS issue with respect to that has been closed. Need to check if that PR is
required. Currently putting it on hold.
-
PR Comment: https://git.openjdk.org/jdk/pull/16604#issuecomment-1823952398
On Wed, 22 Nov 2023 16:35:36 GMT, Thomas Stuefe wrote:
> Hi, is this patch meant for review already? If yes, could you please describe
> the problem you fix, and how you fix it? If no, I suggest working on it in
> draft state till its ready for review.
I have updated the description. Let me kn
> JDK-8320005 : Native library suffix impact on hotspot code in AIX
suchismith1993 has updated the pull request incrementally with one additional
commit since the last revision:
change macro position
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16604/files
-
JDK-8320005 : Native library suffix impact on hotspot code in AIX
-
Commit messages:
- Adapt hotspot coding style
- Improve comments and coding style.
- Remove macro for file extension.
- Move mapping function to aix specific file.
- Introduce new macro for AIX archives.
- Add
14 matches
Mail list logo