On Mon, 20 Jan 2025 21:25:51 GMT, Simon Tooke wrote:
> This fix widens the regex used to determine if a JAVAHEAP line is correct in
> the output of System.map/System.dump_map.
@stooke
Your change (at version 238e9c0b45f7210168dd9a10f661a00b26c5da70) is now ready
to be sponsored by a Committer
On Thu, 14 Nov 2024 21:34:08 GMT, Larry Cable wrote:
> c.f:
> [https://bugs.openjdk.org/browse/JDK-8339420](https://bugs.openjdk.org/browse/JDK-8339420)
>
> Summary
> ---
>
> Add `jcmd Thread.vthread_summary` to print summary information that is
> useful when trying to diagnose issues wi
On Wed, 20 Nov 2024 18:09:08 GMT, Adam Bruce wrote:
> This PR fixes a long-standing bug in JDWP where the access flags of a field
> are not checked before attempting to read it's value.
>
> Prior to this change, attempting to read a non-static field would cause a JVM
> crash, this change corr
On Tue, 14 Jan 2025 17:40:20 GMT, Robert Toyonaga wrote:
>> This is a redo of [JDK-8304824](https://bugs.openjdk.org/browse/JDK-8304824)
>> which was backed out by
>> [JDK-8343726](https://bugs.openjdk.org/browse/JDK-8343726) due to problems
>> documented in [JDK-8343244](https://bugs.openjdk.
On Thu, 14 Nov 2024 12:22:36 GMT, Magnus Ihse Bursie wrote:
> In several (most? all?) of the build system files, the copyright header
> includes the classpath exception. This makes no sense, and should be removed.
>
> I have removed the classpath exception from makefiles, autoconf, shell
> sc
On Thu, 9 Jan 2025 20:48:21 GMT, Simon Tooke wrote:
>> This test fixes an issue with incomplete Windows threads not yet having a
>> stack. A test for a null stack_base is added to guard against the potential
>> null dereference. An additional test using ZGC is added to the jtreg
>> SystemMap
On Wed, 8 Jan 2025 07:45:24 GMT, Ramkumar Sunderbabu
wrote:
>> Trivial logging message change.
>
> Ramkumar Sunderbabu has updated the pull request incrementally with one
> additional commit since the last revision:
>
> incorporated review comments
@rsunderbabu
Your change (at version 28c1
On Thu, 18 Jul 2024 01:49:54 GMT, SendaoYan wrote:
> Hi all,
> The testcase `serviceability/attach/LongArgTest.java` intermittent fails
> `java.lang.NoClassDefFoundError: jdk/test/lib/Utils`. Jtreg doesn't
> automatically compile `jdk/test/lib/Utils.class` and
> `jdk/test/lib/apps/LingeredApp.
On Wed, 25 Dec 2024 02:34:16 GMT, Qizheng Xing wrote:
>> This patch fixes unmatched brackets in some files, mostly in comments, docs
>> and man pages.
>
> Qizheng Xing has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert fix in the CTW M
On Tue, 13 Aug 2024 15:07:17 GMT, Sonia Zaldana Calles
wrote:
> Hi all,
>
> This PR addresses [8204681](https://bugs.openjdk.org/browse/JDK-8204681)
> enabling support for timestamp expansion in filenames specified in
> `-XX:HeapDumpPath` using `%t`.
>
> As mentioned in this comments for t
On Fri, 13 Dec 2024 02:17:33 GMT, Vladimir Ivanov wrote:
>> Optimize constructor to skip extra copy for registers. The tier1 tests are
>> OK. The Specjvm2008 benchmark reports ~1% improvement.
>
> Vladimir Ivanov has updated the pull request with a new target base due to a
> merge or a rebase.
On Tue, 10 Dec 2024 12:41:00 GMT, Simon Tooke wrote:
>> This is a port of #16301 to macOS.
>>
>> System.map and System.dump_map are implemented using the macOS API and
>> provide roughly the same information in the same format. Most of the heavy
>> lifting was implemented by @tstuefe in
>> h
On Fri, 6 Dec 2024 18:02:53 GMT, Fabian Meumertzheim wrote:
>> The return value of Metrics#getCpuSetCpus may change over time, including
>> from non-null to null across the two calls in this method.
>
> Fabian Meumertzheim has updated the pull request incrementally with one
> additional commit
On Mon, 12 Aug 2024 14:01:29 GMT, Robert Toyonaga wrote:
> ### Summary
> This PR splits up NMT memory counter classes into "live" and "flat" versions.
> Currently, the same classes are used and reused in both live (recording) and
> snapshotted (reporting) contexts. However, after counters have
On Tue, 12 Nov 2024 20:39:55 GMT, Larry Cable wrote:
>> the implementation I originally provided does not in fact solve the issue!
>>
>> the attach protocol initiation "handshake" requires that the "attacher" (the
>> caller of this code) and the "attachee"(the target JVM to be "attached" to)
>
On Sun, 17 Nov 2024 04:32:39 GMT, Ramkumar Sunderbabu
wrote:
> Trivial change to exclude the test from running with Xcomp flag.
>
> The test fails because the number of GCs as reported by the MXBean doesn't
> match the expected number. This is due to the additional GC happening due to
> CodeC
On Thu, 7 Nov 2024 08:32:16 GMT, theoweidmannoracle wrote:
>> - Changed several "NULL" in comments to "null"
>> - Changed several `NULL` in code to `nullptr`
>
> theoweidmannoracle has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Fix backsli
On Wed, 30 Oct 2024 17:20:49 GMT, Larry Cable wrote:
>> the implementation I originally provided does not in fact solve the issue!
>>
>> the attach protocol initiation "handshake" requires that the "attacher" (the
>> caller of this code) and the "attachee"(the target JVM to be "attached" to)
>
On Mon, 28 Oct 2024 17:42:41 GMT, Ramkumar Sunderbabu
wrote:
>> Merging vm folder's InMemoryJavaCompiler into jdk folder's merge
>> InMemoryJavaCompiler so that maintenance is easy.
>>
>> Testing done for
>> Tiers 1,2,3
>> test/hotspot/jtreg tests
>
> Ramkumar Sunderbabu has updated the pull r
On Mon, 28 Oct 2024 16:12:39 GMT, Robert Toyonaga wrote:
>> ### Summary
>> This PR just replaces `ThreadCritical` with a lock specific to NMT.
>> `ThreadCritical` is a big lock and is unnecessary for the purposes of NMT.
>> I've implemented the new lock with a semaphore so that it can be used
On Wed, 16 Oct 2024 10:30:48 GMT, Ramkumar Sunderbabu
wrote:
>> Passing "-Xmx1g -Xcomp" to the LingeredApp.
>> Testing: tier1
>
> Ramkumar Sunderbabu has updated the pull request incrementally with one
> additional commit since the last revision:
>
> change othervm to driver, remove -Xmx1g
On Wed, 16 Oct 2024 13:17:48 GMT, Simon Tooke wrote:
>> This PR changes the status of realpath() from a Posix-specific API to a
>> globally available API, i.e. adding it to the "Hotspot Porting API". Code
>> would refer to os::realpath() instead of os::Posix::realpath().
>>
>> This requires a
On Wed, 31 Jul 2024 19:10:41 GMT, Henry Lin wrote:
> Adds a command line option `-redact` to `jcmd` and `-XX:+HeapDumpRedacted`
> enabling redacted heap dumps. When enabled, the output binary heap dump has
> zeroes written out in place of the original primitive values in the object
> fields. T
On Wed, 31 Jul 2024 08:30:47 GMT, Kevin Walls wrote:
> Man page update for jcmd.
>
> Add updates for the filename options/arguments affected by:
> 8334492: DiagnosticCommands (jcmd) should accept %p in output filenames and
> substitute PID
>
> Also:
> In the initial "command" summary, remove t
On Wed, 1 May 2024 21:32:46 GMT, Chris Plummer wrote:
> This PR adds ranked monitor support to the debug agent. The debug agent has a
> large number of monitors, and it's really hard to know which order to grab
> them in, and for that matter which monitors might already be held at any
> given
On Thu, 10 Oct 2024 14:27:08 GMT, Ramkumar Sunderbabu
wrote:
>> The System property "docker.support" defined in VMProps gives a wrong
>> impression that it is tied to docker alone. The property is common for any
>> container runtime. Hence, it needs to be renamed as "container.support".
>>
>>
On Tue, 8 Oct 2024 04:17:31 GMT, Ramkumar Sunderbabu
wrote:
>> JDK-8318668 was not reproducible in repeated runs. Hence, I am pulling it
>> out of problem listing. Additionally I have increased logging so that it is
>> easier to debug when the issue happens again.
>>
>> Testing:
>> tier1,tier
On Mon, 7 Oct 2024 19:37:51 GMT, Sebastian Lövdahl wrote:
>> The fix is twofold.
>>
>> 1. Stop the main container after an iteration is done. The main container is
>> started with its runtime defined as 120 seconds, which means that each
>> iteration takes 120 seconds. In reality, one iteratio
On Tue, 1 Oct 2024 07:01:17 GMT, Ramkumar Sunderbabu
wrote:
>> Cleaning up nsk.share.Log code after the verbose mode was set always true.
>>
>> Tested all the vmTestbase/ tests.
>
> Ramkumar Sunderbabu has updated the pull request incrementally with one
> additional commit since the last revis
On Mon, 30 Sep 2024 14:55:33 GMT, Ramkumar Sunderbabu
wrote:
> Cleaning up nsk.share.Log code after the verbose mode was set always true.
>
> Tested all the vmTestbase/ tests.
@rsunderbabu
Your change (at version a346de1ce3387f99bb3f8d63c64b9c6bc1212bcb) is now ready
to be sponsored by a Com
On Sun, 29 Sep 2024 06:23:34 GMT, Sebastian Lövdahl wrote:
>> 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid
>> (Kubernetes debug container)
>
> Sebastian Lövdahl has updated the pull request with a new target base due to
> a merge or a rebase. The incremental webrev exclu
On Thu, 12 Sep 2024 20:10:45 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
On Fri, 28 Jun 2024 20:34:48 GMT, Chris Plummer wrote:
> The completely unrelated fix to
> [JDK-8335124](https://bugs.openjdk.org/browse/JDK-8335124) led me to believe
> that the issue with sometimes not being able to get the stack trace of the
> SteadyStateThread might be due to the thread be
On Fri, 28 Jun 2024 22:30:52 GMT, Chris Plummer wrote:
> Once the main thread has detected that the spawned thread is in the BLOCKED
> state, the spawned thread's LingeredAppWithLock.lockMethod() should be
> visible on the top of the stack, but it is not, so the "waiting to lock"
> message is
On Mon, 26 Aug 2024 13:54:36 GMT, Joakim Nordström
wrote:
>> Can I get a review of this documentation update to clarify the usage of
>> GetCpuLoad (and inherently deprecated GetSystemCpuLoad) and
>> GetProcessCpuLoad.
>>
>> Calling either of these methods in quick succession can lead to
>> u
On Wed, 4 Sep 2024 10:17:55 GMT, Yagmur Eren wrote:
>> A logic error in the block of code in com.sun.tools.jdi.TargetVM is fixed by
>> putting fromByteArray() method within else statement to prevent invoking it
>> when the array b is empty. See issue:
>> [JDK-8339384](https://bugs.openjdk.org/
On Fri, 8 Mar 2024 01:07:50 GMT, Man Cao wrote:
> Hi all,
>
> Could anyone review this fix to make serial heap dump only write to a single
> file?
> We highly appreciate the work in https://bugs.openjdk.org/browse/JDK-8306441.
> However, many of our customers still need to use serial heap dump
On Mon, 10 Jun 2024 20:05:03 GMT, Evgeny Astigeevich
wrote:
> A Java method can become non-compilable if there are issues with its
> compilation or if its compiled version causes problems. Additionally, a
> method can be marked as non-compilable using a compile command or a compiler
> directi
On Tue, 23 Apr 2024 13:56:32 GMT, Julian Waters wrote:
> WIP
>
> This changeset contains hsdis for Windows/gcc Port. It supports both the
> binutils and capstone backends, though the LLVM backend is left out due to
> compatibility issues encountered during the build. Currently, which gcc
> di
On Thu, 8 Aug 2024 09:31:17 GMT, Jiawei Tang wrote:
>> I add the testcase which can reproduce the crash. I hope that I could get
>> some advise if the codes need changing.
>
> Jiawei Tang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix
On Mon, 22 Jul 2024 15:36:47 GMT, Sonia Zaldana Calles
wrote:
>> Hi all,
>>
>> This is a small patch to address
>> [8327054](https://bugs.openjdk.org/browse/JDK-8327054) making
>> `CodeCache::write_perf_map` aware of which output stream errors and warning
>> message should be going to.
>>
On Sat, 20 Jul 2024 06:33:09 GMT, Daniel Lundén wrote:
>> We are seeing quite a few timeouts for
>> `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing,
>> possibly related to
>> [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should
>> disable running `Clhsd
On Mon, 24 Jun 2024 16:16:29 GMT, SendaoYan wrote:
> Hi all,
> After [JDK-8294960](https://bugs.openjdk.org/browse/JDK-8294960), the
> footprint memory usage increased significantly when run the testcase with
> -Xcomp jvm options, then cause the testcase was killed by docker by OOM.
> Maybe
On Mon, 24 Jun 2024 16:16:29 GMT, SendaoYan wrote:
> Hi all,
> After [JDK-8294960](https://bugs.openjdk.org/browse/JDK-8294960), the
> footprint memory usage increased significantly when run the testcase with
> -Xcomp jvm options, then cause the testcase was killed by docker by OOM.
> Maybe
On Fri, 12 Jul 2024 03:24:42 GMT, SendaoYan wrote:
> Hi all,
> Test TestClhsdbJstackLock.java/TestJhsdbJstackLock.java fails with -Xcomp
> after [JDK-8335743](https://bugs.openjdk.org/browse/JDK-8335743). I think the
> new failures was testcase bug.
>
> https://github.com/openjdk/jdk/blob/627a
On Mon, 8 Jul 2024 12:16:51 GMT, KIRIYAMA Takuya wrote:
>> This bug was introduced by JDK-8284161. "Object.wait (long timeoutMillis)"
>> was changed to call "Object.wait0 (long timeoutMillis)" in JDK-8284161.
>>
>> When "jhdsb jstack" is executed, the stack and lock information are printed
>>
On Fri, 12 Apr 2024 14:40:05 GMT, Sergey Nazarkin wrote:
> An alternative for preemptively switching the W^X thread mode on macOS with
> an AArch64 CPU. This implementation triggers the switch in response to the
> SIGBUS signal if the *si_addr* belongs to the CodeCache area. With this
> approa
On Wed, 27 Mar 2024 17:24:34 GMT, Volker Simonis wrote:
> Diagnostic command for zeroing unused parts of the heap
>
> I propose to add a new diagnostic command `System.zero_unused_memory` which
> zeros out all unused parts of the heap. The name of the command is
> intentionally GC/heap agnosti
On Thu, 4 Jul 2024 14:43:49 GMT, Sonia Zaldana Calles
wrote:
>> Hi all,
>>
>> This PR addresses [8332124](https://bugs.openjdk.org/browse/JDK-8332124)
>> enabling jcmd to recognize options that look like help.
>>
>> Testing:
>> - [x] Added test case passes.
>>
>> Thanks,
>> Sonia
>
> So
On Wed, 14 Feb 2024 22:16:02 GMT, Alex Menkov wrote:
> The fix updates heap dumpers to report correct instance size value for
> HPROF_GC_CLASS_DUMP records (currently it's reported as size of all instance
> fields)
>
> Testing: tier1, tier2, tier5-svc
This pull request has been closed without
On Thu, 17 Nov 2022 09:43:39 GMT, Poison wrote:
>> As the title says, add the volatile modifier.
>
> Poison has updated the pull request incrementally with one additional commit
> since the last revision:
>
> 8297173: usageTicks and totalTicks should be volatile
@tianshuang
Your change (at
On Thu, 17 Nov 2022 06:28:37 GMT, Poison wrote:
> As the title says, add the volatile modifier.
@tianshuang
Your change (at version dd4599661ab209ef1a77c36be066a2af61304156) is now ready
to be sponsored by a Committer.
-
PR Comment: https://git.openjdk.org/jdk/pull/11199#issuecom
On Tue, 23 Jan 2024 13:04:43 GMT, SendaoYan wrote:
>> 8323640: [TESTBUG]testMemoryFailCount in
>> jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail
>> because OOM killed
>
> SendaoYan has updated the pull request incrementally with one additional
> commit since the last rev
On Wed, 8 May 2024 01:19:05 GMT, SendaoYan wrote:
>> Hi,
>> GHA
>> [runner](https://github.com/sendaoYan/jdk-ysd/actions/runs/8881868940/job/24386063136)
>> shows that serviceability/dcmd/gc/RunFinalizationTest.java intermittent
>> fail on macos-aarch64. The testcase has been problemlisted o
On Wed, 1 May 2024 14:14:22 GMT, SendaoYan wrote:
> Hi,
> GHA
> [runner](https://github.com/sendaoYan/jdk-ysd/actions/runs/8881868940/job/24386063136)
> shows that serviceability/dcmd/gc/RunFinalizationTest.java intermittent fail
> on macos-aarch64. The testcase has been problemlisted on
>
On Wed, 31 Jan 2024 14:22:44 GMT, Kevin Walls wrote:
> Introduce the jcmd "VM.inspect" to implement access to detailed JVM object
> information.
>
> Not recommended for live production use. Requires UnlockDiagnosticVMOptions
> and not included in jcmd help output, to remind us this is not a
On Tue, 19 Dec 2023 16:59:05 GMT, Emanuel Peter wrote:
> [JDK-8247755](https://bugs.openjdk.org/browse/JDK-8247755) introduced the
> `GrowableArrayCHeap`. This duplicates the current C-Heap allocation
> capability in `GrowableArray`. I now remove that from `GrowableArray` and
> move all usages
On Wed, 17 Jan 2024 00:14:58 GMT, Jiangli Zhou wrote:
> Please review this PR with a simple solution for resolving duplicate `Thread`
> symbol issue. In https://github.com/openjdk/jdk/pull/14808 comments, there
> was an alternative suggestion to redefine the symbol at build time, such as
> us
On Fri, 1 Dec 2023 07:56:04 GMT, Emanuel Peter wrote:
> Before this patch, we always initialized the GrowableArray up to its
> `capacity`, and not just up to `length`. This is problematic for a few
> reasons:
>
> - It is not expected. `std::vector` also only initializes the elements up to
> i
On Thu, 14 Dec 2023 10:13:51 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to improve the code
> in `get_user_name_slow` function, which is used to identify the target JVM
> owner's user name? This addresses https://bugs.openjdk.org/browse/JDK-8321971.
>
>
On Wed, 9 Aug 2023 07:46:58 GMT, Sergey Bylokhov wrote:
> The test uses this code to create a list of valid addresses for the localhost:
>
> String hostname = "localhost";
> List validAddresses = new LinkedList<>();
> validAddresses.add(hostname);
> Arrays.stream(
On Thu, 21 Sep 2023 20:43:56 GMT, Yi-Fan Tsai wrote:
> `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map:
> `/tmp/perf-%d.map`. This change adds an option for specifying a file name.
>
> The help message of Compiler.perfmap:
>
> Compiler.perfmap
> Write map file for Linux pe
On Fri, 12 May 2023 17:27:25 GMT, Roman Kennke wrote:
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> Main changes:
> - Introduction of the (experimental) flag UseCompactObjectHeaders. All
> changes in this PR are protected by this flag.
> - The compressed K
On Thu, 2 Feb 2023 12:54:06 GMT, Boris Ulasevich wrote:
> This is another pull request to replace
> https://github.com/openjdk/jdk/pull/10025 change which was blocked as not
> acceptable (see
> https://github.com/openjdk/jdk/pull/10025#pullrequestreview-1228216330)
>
> The objections to chang
On Tue, 14 Mar 2023 02:43:41 GMT, Chen Liang wrote:
> Summaries:
> 1. A few recommendations about updating the constant API is made at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html
> and I may update this patch shall the API changes be integrated before
> 2. One
On Thu, 23 Feb 2023 09:04:23 GMT, Justin Lu wrote:
> This PR converts Unicode sequences to UTF-8 native in .properties file.
> (Excluding the Unicode space and tab sequence). The conversion was done using
> native2ascii.
>
> In addition, the build logic is adjusted to support reading in the
>
On Thu, 10 Nov 2022 06:20:41 GMT, Julian Waters wrote:
> After [JDK-8292008](https://bugs.openjdk.org/browse/JDK-8292008) and
> [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283), some C and C++
> code across the JDK can be replaced and simplified with cleaner language
> features that
On Tue, 10 Jan 2023 20:55:12 GMT, Justin King wrote:
> Remove abstraction that is a holdover from Solaris. Direct usages of
> `MmapArrayAllocator` have been switched to normal `malloc`. The justification
> is that none of the code paths are called from signal handlers, so using
> `mmap` direct
On Fri, 21 Oct 2022 21:45:30 GMT, Bill Huang wrote:
> The current non local registry tests require a manual process that runs
> rmiregitrty on a different machine and changes the -Dregistry.host property
> in the source before running the tests on the local machine. This task is
> created to i
On Fri, 2 Dec 2022 16:42:57 GMT, Magnus Ihse Bursie wrote:
> According to [the
> specification](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/Properties.html#load(java.io.Reader))
> trailing whitespaces in the values of properties files are (somewhat
> surprisingly) ac
On Thu, 10 Nov 2022 01:10:13 GMT, Jonathan Gibbons wrote:
> Please review a "somewhat automated" change to insert `@spec` tags into doc
> comments, as appropriate, to leverage the recent new javadoc feature to
> generate a new page listing the references to all external specifications
> listed
On Tue, 10 May 2022 12:29:10 GMT, Severin Gehwolf wrote:
> Please review this change to the cgroup v1 subsystem which makes it more
> resilient on some of the stranger systems. Unfortunately, I wasn't able to
> re-create a similar system as the reporter. The idea of using the longest
> substri
On Wed, 27 Jul 2022 12:55:04 GMT, Axel Boldt-Christmas
wrote:
> The proposal is to encapsulate the nmethod mark for deoptimization logic in
> one place and only allow access to the `mark_for_deoptimization` from a
> closure object:
> ```C++
> class DeoptimizationMarkerClosure : StackObj {
> pu
On Tue, 5 Jul 2022 04:21:55 GMT, xpbob wrote:
> Container configuration information is useful for troubleshooting
> problems,Exposing information in MBeans is ideal for monitoring, jConsole,
> and other scenarios.
> Results the following
>  is wrong.
>
> Currently,
> `NonHeapUsage=CodeCache+Metaspace(ClassTypeSpace+NonClassTypeSpace)+CompressedClassSpace(ClassTypeSpace)`
>
> ==> CodeHeap 'non-n
On Tue, 19 Apr 2022 17:44:10 GMT, XenoAmess wrote:
> These are the changes that too many to be reviewed in 8186958, thus split
> some of them out.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/8301
77 matches
Mail list logo
