Re: RFR: 8359394: GC cause cleanup

2025-06-16 Thread Y . Srinivas Ramakrishna
On Thu, 12 Jun 2025 23:42:41 GMT, William Kemper wrote: > Remove `GCCause::_no_cause_specified` (only referenced by Shenandoah) and add > a case for `_shenandoah_humongous_allocation_failure` in `GCCause::to_string` > and the `SA` analog. Thanks for changing the title/summary to broaden scope.

Re: RFR: 8359394: Shenandoah: GC cause cleanup

2025-06-13 Thread Y . Srinivas Ramakrishna
On Thu, 12 Jun 2025 23:42:41 GMT, William Kemper wrote: > We can remove `GCCause::_no_cause_specified` and need to add a case for > `_shenandoah_humongous_allocation_failure` in `GCCause::to_string`. We are > also missing `_shenandoah_humongous_allocation_failure` in the `SA` analog. Reviewed

Re: [jdk24] RFR: 8345750: Shenandoah: Test TestJcmdHeapDump.java#aggressive intermittent assert(gc_cause() == GCCause::_no_gc) failed: Over-writing cause

2025-01-21 Thread Y . Srinivas Ramakrishna
On Tue, 21 Jan 2025 18:48:13 GMT, William Kemper wrote: > This is a clean backport and addresses a fairly critical issue where in a > mistimed heap dump may cause heap corruption or vm crashes for Shenandoah GC. 🚢 - Marked as reviewed by ysr (Reviewer). PR Review: https://git.ope

Re: RFR: 8345750: Shenandoah: Test TestJcmdHeapDump.java#aggressive intermittent assert(gc_cause() == GCCause::_no_gc) failed: Over-writing cause

2025-01-17 Thread Y . Srinivas Ramakrishna
On Fri, 17 Jan 2025 23:12:14 GMT, William Kemper wrote: > This occurs when an attempt to produce a heap dump conflicts with a > concurrent cycle. The heap dump vm operation attempts to run a cycle directly > on the VM thread with no regard for the state of the concurrent collection. > Although

Re: RFR: 8345750: Shenandoah: Test TestJcmdHeapDump.java#aggressive intermittent assert(gc_cause() == GCCause::_no_gc) failed: Over-writing cause

2025-01-17 Thread Y . Srinivas Ramakrishna
On Fri, 17 Jan 2025 23:12:14 GMT, William Kemper wrote: > This occurs when an attempt to produce a heap dump conflicts with a > concurrent cycle. The heap dump vm operation attempts to run a cycle directly > on the VM thread with no regard for the state of the concurrent collection. > Although

Re: RFR: 8346051: MemoryTest fails when Shenandoah's generational mode is enabled

2024-12-12 Thread Y . Srinivas Ramakrishna
On Thu, 12 Dec 2024 00:01:41 GMT, William Kemper wrote: > This test makes assertions about the number of gc manager beans and the > number of memory pools. The generational mode for Shenandoah adds another > memory pool. test/jdk/java/lang/management/MemoryMXBean/MemoryTest.java line 62: > 60

Re: RFR: 8346051: MemoryTest fails when Shenandoah's generational mode is enabled

2024-12-12 Thread Y . Srinivas Ramakrishna
On Thu, 12 Dec 2024 00:01:41 GMT, William Kemper wrote: > This test makes assertions about the number of gc manager beans and the > number of memory pools. The generational mode for Shenandoah adds another > memory pool. Marked as reviewed by ysr (Reviewer). - PR Review: https://

Re: RFR: 8337511: Implement JEP 404: Generational Shenandoah (Experimental) [v6]

2024-11-26 Thread Y . Srinivas Ramakrishna
On Wed, 20 Nov 2024 00:01:49 GMT, Y. Srinivas Ramakrishna wrote: >> src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp line 474: >> >>> 472: // elision safe. >>> 473: return; >>> 474: } >> >> Why is this safe for Shen

Re: RFR: 8337511: Implement JEP 404: Generational Shenandoah (Experimental) [v8]

2024-11-21 Thread Y . Srinivas Ramakrishna
On Thu, 21 Nov 2024 13:34:51 GMT, Aleksey Shipilev wrote: >> William Kemper has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 524 commits: >> >> - Merge remote-tracking branch 'shenandoah/master' into >> great-genshen-pr-redux >>

Re: RFR: 8337511: Implement JEP 404: Generational Shenandoah (Experimental) [v6]

2024-11-19 Thread Y . Srinivas Ramakrishna
On Wed, 13 Nov 2024 10:51:48 GMT, Aleksey Shipilev wrote: >> William Kemper has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 503 commits: >> >> - Merge openjdk/jdk tip into great-genshen-pr-redux >> - Merge remote-tracking branch

Re: RFR: 8337511: Implement JEP 404: Generational Shenandoah (Experimental) [v3]

2024-11-11 Thread Y . Srinivas Ramakrishna
On Tue, 22 Oct 2024 17:12:38 GMT, Zhengyu Gu wrote: >> Congratulations! Good to see the great progress. I just built this PR for >> some testing and found something unexpected. I ran the genshen VS >> shenandoah(default) with jbb2015 on aarch64 N2 with 8 cores and Xmx8g. The >> critical-jOPS o

Re: RFR: 8337511: Implement JEP-404: Generational Shenandoah (Experimental) [v3]

2024-10-11 Thread Y . Srinivas Ramakrishna
On Thu, 10 Oct 2024 18:07:27 GMT, Roman Kennke wrote: >> William Kemper has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 478 commits: >> >> - Fix merge error >> - Merge remote-tracking branch 'jdk/master' into great-genshen-pr-re

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v9]

2023-06-07 Thread Y . Srinivas Ramakrishna
On Wed, 7 Jun 2023 00:39:52 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v9]

2023-06-07 Thread Y . Srinivas Ramakrishna
On Wed, 7 Jun 2023 00:39:52 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v9]

2023-06-07 Thread Y . Srinivas Ramakrishna
On Wed, 7 Jun 2023 00:39:52 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v9]

2023-06-07 Thread Y . Srinivas Ramakrishna
On Wed, 7 Jun 2023 00:39:52 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v9]

2023-06-07 Thread Y . Srinivas Ramakrishna
On Wed, 7 Jun 2023 00:39:52 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v9]

2023-06-07 Thread Y . Srinivas Ramakrishna
On Wed, 7 Jun 2023 00:39:52 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v9]

2023-06-07 Thread Y . Srinivas Ramakrishna
On Wed, 7 Jun 2023 00:39:52 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v9]

2023-06-07 Thread Y . Srinivas Ramakrishna
On Wed, 7 Jun 2023 00:39:52 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v9]

2023-06-06 Thread Y . Srinivas Ramakrishna
On Wed, 7 Jun 2023 00:39:52 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v4]

2023-06-03 Thread Y . Srinivas Ramakrishna
On Fri, 2 Jun 2023 18:38:41 GMT, Martin Doerr wrote: >> src/hotspot/cpu/riscv/gc/shenandoah/c1/shenandoahBarrierSetC1_riscv.cpp line >> 4: >> >>> 2: * Copyright (c) 2018, 2019, Red Hat, Inc. All rights reserved. >>> 3: * Copyright (c) 2020, 2021, Huawei Technologies Co., Ltd. All rights >>>

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v4]

2023-06-02 Thread Y . Srinivas Ramakrishna
On Fri, 2 Jun 2023 02:49:25 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v4]

2023-06-02 Thread Y . Srinivas Ramakrishna
On Fri, 2 Jun 2023 02:49:25 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v4]

2023-06-02 Thread Y . Srinivas Ramakrishna
On Fri, 2 Jun 2023 02:49:25 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental)

2023-06-01 Thread Y . Srinivas Ramakrishna
On Thu, 1 Jun 2023 12:15:37 GMT, Martin Doerr wrote: > Issues already reported to GenShen engineers: > > gc/shenandoah/TestElasticTLAB.java#generational #  Internal Error > (src\hotspot\share\gc\shenandoah\shenandoahFreeSet.cpp:695), pid=23288, > tid=23784 #  assert(size % CardTable::card_size

Re: RFR: 8306858: Remove some remnants of CMS from SA agent [v2]

2023-04-26 Thread Y . Srinivas Ramakrishna
On Wed, 26 Apr 2023 08:41:30 GMT, Thomas Schatzl wrote: >> Hi all, >> >> please review this change that removes some remaining CMS related stuff. >> >> Testing: tier1-3, gha >> >> Thanks, >> Thomas > > Thomas Schatzl has updated the pull request incrementally with one additional > commit