On Tue, 15 Oct 2024 10:12:21 GMT, Ramkumar Sunderbabu
wrote:
> Passing "-Xmx1g -Xcomp" to the LingeredApp.
> Testing: tier1
The -Xmx1g is probably just copied from ClhsdbPrintAll.java so it could
probably be dropped. Since the point of this test is to exercise nmethod debug
info decoding we
On Fri, 12 Jan 2024 21:26:36 GMT, Tom Rodriguez wrote:
> The changes for JDK-8287061 didn't update the SA decoding logic and there are
> other places where the decoding has gotten out of sync with HotSpot. Some of
> them can't be tested because they are part of JVMCI but I&
On Wed, 17 Jan 2024 19:52:32 GMT, Tom Rodriguez wrote:
>> The changes for JDK-8287061 didn't update the SA decoding logic and there
>> are other places where the decoding has gotten out of sync with HotSpot.
>> Some of them can't be tested because they are pa
code and a more brute force test that tries to
> decode everything.
Tom Rodriguez has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains 10 additional co
On Thu, 14 Mar 2024 10:46:10 GMT, Doug Simon wrote:
> This PR increases a timeout in `MissingClassTest.java` to handle slight
> slower compilation on a fastdebug build when using `-Xcomp`.
> Testing on mach5 shows that the increase from 60 s to 90 s resolves the
> timeouts.
Marked as reviewed
On Fri, 1 Mar 2024 17:24:02 GMT, Doug Simon wrote:
> To account for slightly slower compile times on libgraal + fastdebug +
> `-Xcomp`, this PR increases a timeout in `NotifReconnectDeadlockTest.java`
> from 2000 ms to 3000 ms.
> With this change, the test now reliably passes.
Looks good
On Wed, 17 Jan 2024 19:52:32 GMT, Tom Rodriguez wrote:
>> The changes for JDK-8287061 didn't update the SA decoding logic and there
>> are other places where the decoding has gotten out of sync with HotSpot.
>> Some of them can't be tested because they are pa
On Wed, 17 Jan 2024 19:52:47 GMT, Chris Plummer wrote:
>> No. ClhsdbTestAllocationMerge is using `jstack -v` which doesn't work with
>> ZGC because the `-v` part needs to iterate the heap looking for
>> AbstractQueuedSynchronizers which doesn't work with ZGC and the SA.
>
> It's not -v that is
On Wed, 17 Jan 2024 19:34:29 GMT, Chris Plummer wrote:
>> Tom Rodriguez has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove testdebuginfodecode command
>
> test/hotspot/jtreg/serviceability/sa/Tes
On Wed, 17 Jan 2024 17:35:39 GMT, Tom Rodriguez wrote:
>> The changes for JDK-8287061 didn't update the SA decoding logic and there
>> are other places where the decoding has gotten out of sync with HotSpot.
>> Some of them can't be tested because they are pa
code and a more brute force test that tries to
> decode everything.
Tom Rodriguez has updated the pull request incrementally with one additional
commit since the last revision:
Review comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17407/files
- new: https://
On Wed, 17 Jan 2024 19:40:03 GMT, Chris Plummer wrote:
>> Tom Rodriguez has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove testdebuginfodecode command
>
> test/hotspot/jtreg/ProblemList-generation
code and a more brute force test that tries to
> decode everything.
Tom Rodriguez has updated the pull request incrementally with one additional
commit since the last revision:
Remove testdebuginfodecode command
-
Changes:
- all: https://git.openjdk.org/jdk/p
On Tue, 16 Jan 2024 22:36:55 GMT, Chris Plummer wrote:
>> Tom Rodriguez has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Update
>> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/NMethod.ja
code and a more brute force test that tries to
> decode everything.
Tom Rodriguez has updated the pull request incrementally with two additional
commits since the last revision:
- Update src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/NMethod.java
Co-authored-by: A
code and a more brute force test that tries to
> decode everything.
Tom Rodriguez has updated the pull request incrementally with one additional
commit since the last revision:
Pass the proper options to the lingered app
-
Changes:
- all: https://git.openjdk.org/jdk/p
On Fri, 12 Jan 2024 21:46:13 GMT, Vladimir Kozlov wrote:
>> Tom Rodriguez has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix problem list and correct jtreg arguments
>
> test/h
code and a more brute force test that tries to
> decode everything.
Tom Rodriguez has updated the pull request incrementally with one additional
commit since the last revision:
Fix problem list and correct jtreg arguments
-
Changes:
- all: https://git.openjdk.org/jdk/p
The changes for JDK-8287061 didn't update the SA decoding logic and there are
other places where the decoding has gotten out of sync with HotSpot. Some of
them can't be tested because they are part of JVMCI but I've added a directed
test for the JDK-8287061 code and a more brute force test that
On Wed, 28 Jun 2023 21:21:11 GMT, Doug Simon wrote:
>> The VMSupport class is required for translating an exception between the
>> HotSpot and libgraal heaps.
>> Loading it lazily can result in a loading exception, obscuring the exception
>> being translated.
>> To avoid this, VMSupport is load
On Tue, 27 Jun 2023 21:29:53 GMT, Doug Simon wrote:
>> The VMSupport class is required for translating an exception between the
>> HotSpot and libgraal heaps.
>> Loading it lazily can result in a loading exception, obscuring the exception
>> being translated.
>> To avoid this, VMSupport is load
On Tue, 27 Jun 2023 21:29:53 GMT, Doug Simon wrote:
>> The VMSupport class is required for translating an exception between the
>> HotSpot and libgraal heaps.
>> Loading it lazily can result in a loading exception, obscuring the exception
>> being translated.
>> To avoid this, VMSupport is load
On Tue, 20 Jun 2023 18:05:09 GMT, Tom Rodriguez wrote:
> This is a minor fix to core file reading on macos x. I can confirm that
> after this fix I can run the problem listed SA core file tests on Ventura.
This pull request has now been integrated.
Changeset: 269852b9
Author:
On Mon, 26 Jun 2023 18:09:24 GMT, Tom Rodriguez wrote:
>> This is a minor fix to core file reading on macos x. I can confirm that
>> after this fix I can run the problem listed SA core file tests on Ventura.
>
> Tom Rodriguez has updated the pull request incrementally w
> This is a minor fix to core file reading on macos x. I can confirm that
> after this fix I can run the problem listed SA core file tests on Ventura.
Tom Rodriguez has updated the pull request incrementally with one additional
commit since the last revision:
Update cop
On Mon, 26 Jun 2023 05:06:13 GMT, Chris Plummer wrote:
>> Tom Rodriguez has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Flatten nested ifs
>> - Adjust ordering of message
>> - Adjust print
> This is a minor fix to core file reading on macos x. I can confirm that
> after this fix I can run the problem listed SA core file tests on Ventura.
Tom Rodriguez has updated the pull request incrementally with one additional
commit since the last revision:
Adjust for
On Mon, 26 Jun 2023 13:17:25 GMT, Doug Simon wrote:
>> The VMSupport class is required for translating an exception between the
>> HotSpot and libgraal heaps.
>> Loading it lazily can result in a loading exception, obscuring the exception
>> being translated.
>> To avoid this, VMSupport is load
> This is a minor fix to core file reading on macos x. I can confirm that
> after this fix I can run the problem listed SA core file tests on Ventura.
Tom Rodriguez has updated the pull request incrementally with three additional
commits since the last revision:
- Flatten nest
On Wed, 21 Jun 2023 19:56:58 GMT, Chris Plummer wrote:
>> Tom Rodriguez has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Flatten nested ifs
>> - Adjust ordering of message
>> - Adjust print
This is a minor fix to core file reading on macos x. I can confirm that after
this fix I can run the problem listed SA core file tests on Ventura.
-
Commit messages:
- 8294316: SA core file support is broken on macosx-x64 starting with macOS
12.x
Changes: https://git.openjdk.org/
On Wed, 22 Sep 2021 05:40:40 GMT, Tom Rodriguez wrote:
> This logic no longer seems to be necessary since the adjustCompilationLevel
> callback has been removed.
This pull request has now been integrated.
Changeset: d61720a4
Author: Tom Rodriguez
URL:
https://git.openjdk.o
> This logic no longer seems to be necessary since the adjustCompilationLevel
> callback has been removed.
Tom Rodriguez has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains one commit:
8218885: Restore pop_frame and force_early_
On Wed, 22 Sep 2021 05:40:40 GMT, Tom Rodriguez wrote:
> This logic no longer seems to be necessary since the adjustCompilationLevel
> callback has been removed.
mach5 runs with the requested options on a GraalVM have passed so I'm going to
merge this now. Sound good?
--
34 matches
Mail list logo
