On Mon, 3 Mar 2025 10:41:16 GMT, Thomas Stuefe wrote:
>> Greetings,
>>
>> This is a rewrite of the Compiler Memory Statistic. The primary new feature
>> is the capability to track allocations by C2 phases. This will allow for a
>> much faster, more thorough analysis of footprint issues.
>>
>
On Sun, 2 Mar 2025 07:20:58 GMT, Thomas Stuefe wrote:
>> Greetings,
>>
>> This is a rewrite of the Compiler Memory Statistic. The primary new feature
>> is the capability to track allocations by C2 phases. This will allow for a
>> much faster, more thorough analysis of footprint issues.
>>
>
On Tue, 25 Feb 2025 16:43:21 GMT, Thomas Stuefe wrote:
>> Greetings,
>>
>> This is a rewrite of the Compiler Memory Statistic. The primary new feature
>> is the capability to track allocations by C2 phases. This will allow for a
>> much faster, more thorough analysis of footprint issues.
>>
On Mon, 24 Feb 2025 08:56:51 GMT, Roberto Castañeda Lozano
wrote:
>>> @robcasloz I identified and hopefully fixed a small issue that hit the
>>> "disabled" path. Turns out we allocate arena chunks a lot more frequently
>>> than I thought, and the new uncon
On Tue, 25 Feb 2025 16:43:21 GMT, Thomas Stuefe wrote:
>> Greetings,
>>
>> This is a rewrite of the Compiler Memory Statistic. The primary new feature
>> is the capability to track allocations by C2 phases. This will allow for a
>> much faster, more thorough analysis of footprint issues.
>>
On Thu, 20 Feb 2025 13:14:34 GMT, Thomas Stuefe wrote:
>> Greetings,
>>
>> This is a rewrite of the Compiler Memory Statistic. The primary new feature
>> is the capability to track allocations by C2 phases. This will allow for a
>> much faster, more thorough analysis of footprint issues.
>>
On Thu, 20 Feb 2025 13:14:34 GMT, Thomas Stuefe wrote:
>> Greetings,
>>
>> This is a rewrite of the Compiler Memory Statistic. The primary new feature
>> is the capability to track allocations by C2 phases. This will allow for a
>> much faster, more thorough analysis of footprint issues.
>>
On Thu, 20 Feb 2025 13:14:34 GMT, Thomas Stuefe wrote:
>> Greetings,
>>
>> This is a rewrite of the Compiler Memory Statistic. The primary new feature
>> is the capability to track allocations by C2 phases. This will allow for a
>> much faster, more thorough analysis of footprint issues.
>>
On Thu, 20 Feb 2025 13:59:57 GMT, Roberto Castañeda Lozano
wrote:
> > @robcasloz I identified and hopefully fixed a small issue that hit the
> > "disabled" path. Turns out we allocate arena chunks a lot more frequently
> > than I thought, and the new unconditional
On Wed, 19 Feb 2025 09:49:54 GMT, Roberto Castañeda Lozano
wrote:
>>> > Hi Thomas, this looks very useful, thanks! I will run some
>>> > Oracle-internal functional and performance testing and come back with the
>>> > results next week.
>>>
>&
On Wed, 19 Feb 2025 06:35:38 GMT, Thomas Stuefe wrote:
> > > Hi Thomas, this looks very useful, thanks! I will run some
> > > Oracle-internal functional and performance testing and come back with the
> > > results next week.
> >
> >
> > Functional test results (Oracle internal tier1-tier5) lo
On Fri, 14 Feb 2025 08:55:26 GMT, Roberto Castañeda Lozano
wrote:
> Hi Thomas, this looks very useful, thanks! I will run some Oracle-internal
> functional and performance testing and come back with the results next week.
Functional test results (Oracle internal tier1-tier5) look go
On Sat, 8 Feb 2025 06:56:40 GMT, Thomas Stuefe wrote:
> Greetings,
>
> This is a rewrite of the Compiler Memory Statistic. The primary new feature
> is the capability to track allocations by C2 phases. This will allow for a
> much faster, more thorough analysis of footprint issues.
>
> Track
On Sat, 8 Feb 2025 06:56:40 GMT, Thomas Stuefe wrote:
> Greetings,
>
> This is a rewrite of the Compiler Memory Statistic. The primary new feature
> is the capability to track allocations by C2 phases. This will allow for a
> much faster, more thorough analysis of footprint issues.
>
> Track
On Tue, 8 Oct 2024 16:30:47 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> previ
On Wed, 9 Oct 2024 16:21:53 GMT, Sandhya Viswanathan
wrote:
>> That seems to work, thanks @rkennke!
>>
>> Since the [indexOf
>> changes](https://github.com/openjdk/jdk/pull/20677/files#diff-ae1139bb5342494f9761e04389b090c543391bfdd7817af1625e854357c96e63)
>> are complex and affect the default
On Tue, 8 Oct 2024 16:30:56 GMT, Roman Kennke wrote:
>> Turns out I can also reproduce the issue on my linux-x64 machine (Intel Core
>> i7-9850H), simply running:
>>
>> `make run-test TEST="java/lang/String/IndexOf.java" CONF=linux-x64-debug`
>>
>> In this case I get:
>>
>>
>> #
>> # A fatal
On Tue, 8 Oct 2024 15:44:45 GMT, Roberto Castañeda Lozano
wrote:
>> Thank you, @sviswa7! Yes this fix looks correct. I've intergrated it into
>> this PR and re-enabled the indexOf intrinsic for compact headers.
>
> @rkennke @sviswa7 These changes trigger the foll
On Tue, 8 Oct 2024 07:16:13 GMT, Roman Kennke wrote:
>> @rkennke Thanks for the explanation. I attach here a fix which is an
>> extension of existing way of copying while taking care of the smaller object
>> header. Also there are two instances of this in the intrinsic so I have
>> factored th
On Tue, 1 Oct 2024 15:46:01 GMT, Roman Kennke wrote:
> > test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationNotRun.java:
>
> I think I would disable the tests for now. Is there a good way to say 'run
> this when UCOH is off OR UseSSE>3?
I don't think so, due to a [limitation in the IR fra
On Thu, 12 Sep 2024 13:20:14 GMT, Emanuel Peter wrote:
> Indeed, I could re-enable all tests in:
>
> ```
> test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationMismatchedAccess.java
> test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationNotRun.java
> test/hotspot/jtreg/compiler/loopopts/su
On Thu, 12 Sep 2024 15:42:59 GMT, Thomas Stuefe wrote:
>> src/hotspot/share/opto/machnode.cpp line 390:
>>
>>> 388: t = t->make_ptr();
>>> 389: }
>>> 390: if (t->isa_narrowklass() && CompressedKlassPointers::shift() == 0) {
>>
>> Does this change have any effect? `UseCompressedClassPoin
On Thu, 26 Sep 2024 13:58:02 GMT, Roman Kennke wrote:
> Does this look correct to you? Or better to do it as a follow-up?
I do not feel confident enough to review this part. If you want to include
https://github.com/rkennke/jdk/commit/097c2afa04397773e514552dfb942aa889bfa2c1
in this changeset,
On Thu, 26 Sep 2024 11:39:02 GMT, Roman Kennke wrote:
>> src/hotspot/cpu/x86/stubGenerator_x86_64.cpp line 4008:
>>
>>> 4006: #ifdef COMPILER2
>>> 4007: if ((UseAVX == 2) && EnableX86ECoreOpts &&
>>> !UseCompactObjectHeaders) {
>>> 4008: generate_string_indexof(StubRoutines::_string_index
On Wed, 25 Sep 2024 12:53:17 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Wed, 25 Sep 2024 12:53:17 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Wed, 25 Sep 2024 12:53:17 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Wed, 25 Sep 2024 12:53:17 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Fri, 13 Sep 2024 06:43:34 GMT, Roberto Castañeda Lozano
wrote:
>> I don't remember if this change was a reaction to an error or if I just
>> guarded `CompressedKlassPointers::shift()` with +UseCCP because that is the
>> prerequisite now. Probably the latter. I ca
On Fri, 20 Sep 2024 15:26:36 GMT, Roman Kennke wrote:
>> I tried to reproduce for a few hours now using a custom testcase, with no
>> success.
>> I am pretty sure that this can happen, that is why I added this code.
>> Originally I had an assert there asserting that index is not used. I do
>>
On Wed, 18 Sep 2024 12:08:46 GMT, Roman Kennke wrote:
>> src/hotspot/cpu/aarch64/c2_MacroAssembler_aarch64.cpp line 2576:
>>
>>> 2574: } else {
>>> 2575: lea(dst, Address(obj, index, Address::lsl(scale)));
>>> 2576: ldr(dst, Address(dst, offset));
>>
>> Do you have a reproducer (or, b
On Thu, 19 Sep 2024 11:42:04 GMT, Roman Kennke wrote:
> > > I agree that this is the simplest and least intrusive way of getting
> > > klass loading working in C2 for this experimental version of the feature.
> > > However, the approach seems brittle and error-prone, and it may be hard
> > > t
On Mon, 16 Sep 2024 08:04:43 GMT, Roberto Castañeda Lozano
wrote:
> I agree that this is the simplest and least intrusive way of getting klass
> loading working in C2 for this experimental version of the feature. However,
> the approach seems brittle and error-prone, and it may b
On Fri, 13 Sep 2024 09:03:55 GMT, Antón Seoane wrote:
> Hi all,
>
> Currently, the Unified Logging framework defaults to three decorators
> (uptime, level, tags) whenever the user does not specify otherwise through
> `-Xlog`. This can result in cumbersome input whenever a specific user that
>
On Fri, 13 Sep 2024 09:03:55 GMT, Antón Seoane wrote:
> Hi all,
>
> Currently, the Unified Logging framework defaults to three decorators
> (uptime, level, tags) whenever the user does not specify otherwise through
> `-Xlog`. This can result in cumbersome input whenever a specific user that
>
On Fri, 13 Sep 2024 13:11:45 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Fri, 13 Sep 2024 13:11:45 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Thu, 12 Sep 2024 11:46:35 GMT, Roberto Castañeda Lozano
wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert accidental change of UCOH default
>
> src/hotspot/share/cds/fil
On Thu, 12 Sep 2024 15:38:18 GMT, Thomas Stuefe wrote:
>> src/hotspot/share/opto/lcm.cpp line 272:
>>
>>> 270: const TypePtr* tptr;
>>> 271: if ((UseCompressedOops || UseCompressedClassPointers) &&
>>> 272: (CompressedOops::shift() == 0 ||
>>> CompressedKlassPointers
On Thu, 12 Sep 2024 15:42:59 GMT, Thomas Stuefe wrote:
>> src/hotspot/share/opto/machnode.cpp line 390:
>>
>>> 388: t = t->make_ptr();
>>> 389: }
>>> 390: if (t->isa_narrowklass() && CompressedKlassPointers::shift() == 0) {
>>
>> Does this change have any effect? `UseCompressedClassPoin
On Wed, 11 Sep 2024 17:38:57 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Wed, 11 Sep 2024 17:38:57 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Tue, 10 Sep 2024 19:11:30 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Tue, 10 Sep 2024 19:11:30 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Fri, 27 Oct 2023 09:48:00 GMT, Leo Korinth wrote:
> Update method name after huge renaming conflict
Looks good and trivial.
-
Marked as reviewed by rcastanedalo (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16395#pullrequestreview-1701407759
On Tue, 9 May 2023 12:55:42 GMT, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review the implementation of Generational ZGC, which can be turned on
>> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
>> ZGC is a major rewrite of the non-generational ZGC version tha
46 matches
Mail list logo
