On Sat, 20 Apr 2024 02:04:20 GMT, Lei Zaakjyu wrote:
> follow up 8267941
This pull request has now been integrated.
Changeset: 985b9ce7
Author: Lei Zaakjyu
Committer: Kim Barrett
URL:
https://git.openjdk.org/jdk/commit/985b9ce79a2d620a8b8675d1ae6c9730d72a757f
Stats: 1003 li
On Fri, 24 May 2024 13:04:14 GMT, Lei Zaakjyu wrote:
>> follow up 8267941
>
> Lei Zaakjyu has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 10 commits:
>
> - review
> - Merge branch 'master' of ht
> follow up 8267941
Lei Zaakjyu has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 10 commits:
- review
- Merge branch 'master' of https://git.openjdk.org/jdk into JDK-8330694
- restore
- Merge branch
On Tue, 21 May 2024 06:08:54 GMT, Chris Plummer wrote:
>> Lei Zaakjyu has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request co
> follow up 8267941
Lei Zaakjyu has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous content of the PR. The pull request contains one new commit
since the last revision:
rest
> follow up 8267941
Lei Zaakjyu has updated the pull request incrementally with one additional
commit since the last revision:
fix
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18871/files
- new: https://git.openjdk.org/jdk/pull/18871/files/65a4bbf9..dafdc775
Webr
On Sun, 12 May 2024 02:55:45 GMT, Lei Zaakjyu wrote:
>> follow up 8267941
>
> Lei Zaakjyu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> rename
Should we also rename 'HeapRegionType' to 'G1HeapR
> follow up 8267941
Lei Zaakjyu has updated the pull request incrementally with one additional
commit since the last revision:
rename
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18871/files
- new: https://git.openjdk.org/jdk/pull/18871/files/b007eb01..65a4b
On Mon, 6 May 2024 22:19:10 GMT, Chris Plummer wrote:
> In SA I see references to heapRegionIterate() that possibly should be renamed.
>
> I noticed that the HeapRegionManager and HeapRegionClosure classes were not
> renamed (in the hotspot source). Is this intentional or an oversite?
OK, I wi
> follow up 8267941
Lei Zaakjyu has updated the pull request incrementally with one additional
commit since the last revision:
review
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18871/files
- new: https://git.openjdk.org/jdk/pull/18871/files/80eeb443..b007e
> follow up 8267941
Lei Zaakjyu has updated the pull request incrementally with one additional
commit since the last revision:
review
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18871/files
- new: https://git.openjdk.org/jdk/pull/18871/files/4d175e27..80eeb
> follow up 8267941
Lei Zaakjyu has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains eight commits:
- rename
- Merge branch 'master' of https://git.openjdk.org/jdk into JDK-8330694
- review
- Merge branch 'master
On Thu, 2 May 2024 21:32:50 GMT, Chris Plummer wrote:
>> test/hotspot/jtreg/serviceability/sa/TestG1HeapRegion.java line 62:
>>
>>> 60: agent.attach(Integer.parseInt(pid));
>>> 61: G1CollectedHeap heap =
>>> (G1CollectedHeap)VM.getVM().getUniverse().heap();
>>> 62:
> follow up 8267941
Lei Zaakjyu has updated the pull request incrementally with one additional
commit since the last revision:
review
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18871/files
- new: https://git.openjdk.org/jdk/pull/18871/files/f4e066c4..92d0d
> follow up 8267941
Lei Zaakjyu has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains five commits:
- Merge branch 'master' into JDK-8330694
- fix indentation
- also tidy up
- tidy up
- rename
-
C
> follow up 8267941
Lei Zaakjyu has updated the pull request incrementally with one additional
commit since the last revision:
fix indentation
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18871/files
- new: https://git.openjdk.org/jdk/pull/18871/files/f0233
> follow up 8267941
Lei Zaakjyu has updated the pull request incrementally with one additional
commit since the last revision:
also tidy up
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18871/files
- new: https://git.openjdk.org/jdk/pull/18871/files/cae3efd0..f0233
> follow up 8267941
Lei Zaakjyu has updated the pull request incrementally with one additional
commit since the last revision:
tidy up
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18871/files
- new: https://git.openjdk.org/jdk/pull/18871/files/4fe5badc..cae3e
follow up 8267941
-
Commit messages:
- rename
Changes: https://git.openjdk.org/jdk/pull/18871/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18871&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8330694
Stats: 978 lines in 124 files changed: 0 ins; 0 del; 978 mod
On Fri, 12 Jan 2024 14:31:54 GMT, Lei Zaakjyu wrote:
> follow up 8234502.
This pull request has now been integrated.
Changeset: e66a76f5
Author: Lei Zaakjyu
Committer: Albert Mingkun Yang
URL:
https://git.openjdk.org/jdk/commit/e66a76f52410d8a4d6aadbd424679409650da9ae
Stats:
On Sat, 13 Jan 2024 02:21:37 GMT, Lei Zaakjyu wrote:
> see 'https://github.com/openjdk/jdk/pull/17398#pullrequestreview-1819022919'
This pull request has now been integrated.
Changeset: 922f8e44
Author: Lei Zaakjyu
Committer: David Holmes
URL:
https://git.openjdk.o
On Sat, 13 Jan 2024 02:21:37 GMT, Lei Zaakjyu wrote:
> see 'https://github.com/openjdk/jdk/pull/17398#pullrequestreview-1819022919'
thanks for the review.
-
PR Comment: https://git.openjdk.org/jdk/pull/17412#issuecomment-1891307949
On Sat, 13 Jan 2024 02:21:37 GMT, Lei Zaakjyu wrote:
> see 'https://github.com/openjdk/jdk/pull/17398#pullrequestreview-1819022919'
This patch seems trivial. I wonder if it needs two reviews.
-
PR Comment: https://git.openjdk.org/jdk/pull/17412#issuecomment-1890866200
> follow up 8234502.
Lei Zaakjyu has updated the pull request incrementally with one additional
commit since the last revision:
fix
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17398/files
- new: https://git.openjdk.org/jdk/pull/17398/files/ed54e312..c0e47a0c
Webr
see 'https://github.com/openjdk/jdk/pull/17398#pullrequestreview-1819022919'
-
Commit messages:
- update copyright
Changes: https://git.openjdk.org/jdk/pull/17412/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17412&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8323
On Fri, 12 Jan 2024 15:26:34 GMT, Lei Zaakjyu wrote:
>> follow up 8234502.
>
> Lei Zaakjyu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix
thanks for the review.
-
PR Comment: https://git.openj
On Fri, 12 Jan 2024 20:49:47 GMT, Chris Plummer wrote:
> SA change looks good. But...
>
> It looks like all the copyright updates to 2024 are missing from this PR and
> the previous PR. We may need another PR for that. Also, the two new files in
> that PR should have a copyright that just says
> follow up 8234502.
Lei Zaakjyu has updated the pull request incrementally with one additional
commit since the last revision:
fix
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17398/files
- new: https://git.openjdk.org/jdk/pull/17398/files/5c9a5e96..ed54e312
Webr
> follow up 8234502.
Lei Zaakjyu has updated the pull request incrementally with one additional
commit since the last revision:
fix indent
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17398/files
- new: https://git.openjdk.org/jdk/pull/17398/files/6d423eee..5c9a5
follow up 8234502.
-
Commit messages:
- fix header ordering
Changes: https://git.openjdk.org/jdk/pull/17398/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17398&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8323660
Stats: 33 lines in 4 files changed: 15 ins; 18 de
30 matches
Mail list logo
