On Fri, 6 Sep 2024 09:31:45 GMT, Yasumasa Suenaga wrote:
> This PR is successor of #20789 . I got some comments in there, then I needed
> to fix in many pooints. And also I have to fix branch name to kick GHA
> automatically (#20789 is named with `pr/`, it meets the condition to skip
> GHA). H
On Mon, 2 Sep 2024 14:50:10 GMT, Yasumasa Suenaga wrote:
> > Note how there is also special handling for (JNI) entry frames in the SA.
>
> Do you mean `JavaCallWrapper` (`X86Frame::senderForEntryFrame` in SA) ?
Yes. Internally it loads the fields of `JavaFrameAnchor`, which points at the
previ
On Mon, 2 Sep 2024 10:29:40 GMT, Yasumasa Suenaga wrote:
>> I attempted to check stack trace in the core generated by [SEGV example in
>> upcall](https://github.com/YaSuenag/garakuta/blob/841452d9176dab1ddbb552009c180530eb81190b/NativeSEGV/ffm/upcall/src/main/java/com/yasuenag/garakuta/nativeseg
On Fri, 26 Jan 2024 09:12:53 GMT, Alan Bateman wrote:
> The target class is transformed in such a way to call the auxiliary class,
> which necessitates the the aux-class to be in the same classloader as the
> target class. But because the aux-class is defined while the target class is
> still
On Sat, 15 Apr 2023 10:15:20 GMT, Kevin Walls wrote:
>> This test is failing often since 8304725 added a call to
>> Thread::current_in_asgct(). This can end up being called e.g. when
>> resolving calls, and then the OS last error value is lost.
>>
>> The test is reliable with a single warm-up
On Thu, 6 Apr 2023 08:11:45 GMT, Glavo wrote:
> os.arch is always the target architecture for JVM, even using 32-bit JVM on
> 64-bit system, its value remains x86.
Okay, I could have sworn we had to add the `ADDRESS_SIZE` check because of this
issue where a 32-bit VM running on x64 would erron
On Wed, 5 Apr 2023 21:18:43 GMT, Glavo wrote:
>> There should be no difference; I was hesitant to drop the ADDRESS_SIZE check
>> without knowing more about the foreign api dependencies. ADDRESS_SIZE is
>> computed (I think) from `UNSAFE.ADDRESS_SIZE * 8`.
>> But I can't think of how it can be
On Wed, 5 Apr 2023 19:20:08 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X8
On Tue, 21 Feb 2023 08:58:50 GMT, Johannes Bechberger wrote:
>> Extends the existing AsyncGetCallTrace test case and fixes the issue.
>
> Johannes Bechberger has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Update full name
Testing looks go
On Mon, 20 Feb 2023 09:18:46 GMT, Johannes Bechberger wrote:
>> Extends the existing AsyncGetCallTrace test case and fixes the issue.
>
> Johannes Bechberger has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Improve condition again
The new c
On Fri, 17 Feb 2023 14:13:04 GMT, Johannes Bechberger wrote:
> Could you be so kind to synthesize a comment for me? I'm slightly overwhelmed
> by the discussion.
Something like:
// Note: sp can be greater than unextended_sp in the case of
// interpreted -> interpreted calls that go through a
On Thu, 16 Feb 2023 14:25:15 GMT, Johannes Bechberger wrote:
>> Extends the existing AsyncGetCallTrace test case and fixes the issue by
>> modifying `MethodHandles` code.
>
> Johannes Bechberger has updated the pull request incrementally with one
> additional commit since the last revision:
>
On Wed, 15 Feb 2023 23:20:00 GMT, Richard Reingruber wrote:
> (Maybe too) long version:
Not at all :) I don't know much about the interpreter, so this is pretty
helpful.
Ok. I think the main point is that a MH linker method doesn't have a c2i
adapter, it instead has separate versions for inte
On Wed, 15 Feb 2023 21:22:48 GMT, Richard Reingruber wrote:
> If an ordinary interpreter entry is used for a call this means the callee
> will be interpreted
Maybe we're not talking about the same thing?
`Method` has a `from_interpreted_entry` and a `from_compiled_entry`, but which
one is use
On Wed, 15 Feb 2023 21:05:07 GMT, Richard Reingruber wrote:
> I don't think you can do that. Modifying the unextended_sp would break
> accesses to compiled frames (gc, locals).
This is for interpreter entries, so the caller is definitely interpreted. If
the callee is compiled, it shouldn't car
On Wed, 15 Feb 2023 09:01:29 GMT, Johannes Bechberger wrote:
>> Are you referring to the test in
>> test/hotspot/jtreg/serviceability/AsyncGetCallTrace/ ?
>
> Yes.
> I think `unextended_sp < sp` is possible on x86 when interpreter entries
> generated by `MethodHandles::generate_method_handle_i
On Wed, 23 Nov 2022 17:33:06 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Tue, 8 Nov 2022 18:14:21 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk
On Tue, 8 Nov 2022 16:30:14 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk
On Mon, 7 Nov 2022 15:00:02 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk
On Tue, 8 Nov 2022 13:28:58 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk
On Mon, 7 Nov 2022 14:59:27 GMT, Maurizio Cimadamore
wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Bring windows CallArranger in sync with panama repo
>
> I have incorporated additional API changes, descr
On Mon, 7 Nov 2022 09:40:03 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/jdk/internal/foreign/abi/x64/windows/CallArranger.java
>> line 165:
>>
>>> 163: assert forArguments : "no stack returns";
>>> 164: // stack
>>> 165: long a
On Fri, 4 Nov 2022 18:23:17 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk
24 matches
Mail list logo
