Re: RFR: 8345799: Update copyright year to 2024 for core-libs in files where it was missed [v3]

2024-12-11 Thread Hamlin Li
On Mon, 9 Dec 2024 15:42:57 GMT, Magnus Ihse Bursie wrote: >> Some files have been modified in 2024, but the copyright year has not been >> properly updated. This should be fixed. >> >> I have located these modified files using: >> >> git log --since="Jan 1" --name-only --pretty=format: | sor

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v51]

2024-10-25 Thread Hamlin Li
On Thu, 24 Oct 2024 14:05:40 GMT, Roman Kennke wrote: >> This is the main body of the JEP 450: Compact Object Headers (Experimental). >> >> It is also a follow-up to #20640, which now also includes (and supersedes) >> #20603 and #20605, plus the Tiny Class-Pointers parts that have been >> prev

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v43]

2024-10-17 Thread Hamlin Li
On Wed, 16 Oct 2024 13:42:42 GMT, Roman Kennke wrote: >> We're seeing failures in our nightly testing for tests >> runtime/cds/appcds/SharedBaseAddress.java and >> runtime/cds/SharedBaseAddress.java which I'm tracking in this bug >> [JDK-8340212](https://bugs.openjdk.org/browse/JDK-8340212) >>

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v23]

2024-10-15 Thread Hamlin Li
On Thu, 19 Sep 2024 15:01:26 GMT, Hamlin Li wrote: >> Roman Kennke has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'lilliput/JEP-450-temporary-fix-branch-2' >> i

Re: RFR: 8334305: Remove all code for nsk.share.Log verbose mode [v3]

2024-10-01 Thread Hamlin Li
On Tue, 1 Oct 2024 07:01:17 GMT, Ramkumar Sunderbabu wrote: >> Cleaning up nsk.share.Log code after the verbose mode was set always true. >> >> Tested all the vmTestbase/ tests. > > Ramkumar Sunderbabu has updated the pull request incrementally with one > additional commit since the last revis

Re: RFR: 8341168: Cleanup dead code after JDK-8322630 [v2]

2024-09-30 Thread Hamlin Li
On Mon, 30 Sep 2024 08:15:51 GMT, Axel Boldt-Christmas wrote: >> [JDK-8322630](https://bugs.openjdk.org/browse/JDK-8322630) / #17495 removed >> the the concept of ICStubs, InlineCache buffers and related safepoints. >> >> There are a handfull of references and auxiliary constructs still in the

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v23]

2024-09-19 Thread Hamlin Li
On Thu, 19 Sep 2024 12:08:46 GMT, Roman Kennke wrote: >> This is the main body of the JEP 450: Compact Object Headers (Experimental). >> >> It is also a follow-up to #20640, which now also includes (and supersedes) >> #20603 and #20605, plus the Tiny Class-Pointers parts that have been >> prev

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v21]

2024-09-19 Thread Hamlin Li
On Wed, 18 Sep 2024 13:23:44 GMT, Roman Kennke wrote: >> This is the main body of the JEP 450: Compact Object Headers (Experimental). >> >> It is also a follow-up to #20640, which now also includes (and supersedes) >> #20603 and #20605, plus the Tiny Class-Pointers parts that have been >> prev

Re: RFR: 8340213: jcmd VM.events ignores max argument [v2]

2024-09-17 Thread Hamlin Li
On Mon, 16 Sep 2024 19:54:38 GMT, Leonid Mesnik wrote: >> The inner 'int max;' declaration hide previous max. > > Leonid Mesnik has updated the pull request incrementally with two additional > commits since the last revision: > > - typo fixed. > - check added. Marked as reviewed by mli (Rev

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v6]

2024-09-10 Thread Hamlin Li
On Mon, 9 Sep 2024 14:08:53 GMT, Roman Kennke wrote: >> Yes, I'm interested in it. Thanks for raising the discussion. :) > > If anybody is doing it, please send me a patch, or we can do it as a > follow-up PR. Thanks. I'll send it to you if I finish it in time, otherwise I will do it in a sepa

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v6]

2024-08-27 Thread Hamlin Li
t; 170: // Todo UseCompactObjectHeaders >> >> Can I ask, will this pr fullly support riscv? > > @Hamlin-Li : AFAIK, porting to linux-riscv platform has NOT been started yet. > To avoid duplicate work, please let me know if anyone is interested or has > been worki

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v6]

2024-08-23 Thread Hamlin Li
On Thu, 22 Aug 2024 20:08:43 GMT, Roman Kennke wrote: >> This is the main body of the JEP 450: Compact Object Headers (Experimental). >> >> It is also a follow-up to #20640, which now also includes (and supersedes) >> #20603 and #20605, plus the Tiny Class-Pointers parts that have been >> prev

Re: RFR: 8318126: Refresh manpages

2023-10-16 Thread Hamlin Li
On Mon, 16 Oct 2023 01:18:52 GMT, David Holmes wrote: > The open nroff manpage files are out of sync with their closed markdown > sources and need to be refreshed. > > The changes to apply are coming from: > > - [JDK-8288158](https://bugs.openjdk.org/browse/JDK-8288158): Add an anchor > to ea

Re: RFR: 8312777: notifyJvmtiMount before notifyJvmtiUnmount

2023-10-15 Thread Hamlin Li
On Sat, 14 Oct 2023 18:07:45 GMT, Alan Bateman wrote: > JVMTI is notified after a virtual thread unmounts. Right not, this > notification is done after the virtual thread has finished parking or > yielding so it's possible for the virtual to continue, and be mounted on a > different carrier, b

Re: RFR: 8311000: missing @since info in jdk.management

2023-06-29 Thread Hamlin Li
On Thu, 29 Jun 2023 11:48:43 GMT, Kevin Walls wrote: > Simple addition of a doc tag. > > src/share/classes/com/sun/management/GarbageCollectionNotificationInfo.java > is introduced in jdk7 by > 7036199: Adding a notification to the implementation of > GarbageCollectorMXBeans Marked as revie

Re: RFR: 8310988: Missing @since tags in java.management.rmi

2023-06-29 Thread Hamlin Li
On Thu, 29 Jun 2023 16:08:15 GMT, Kevin Walls wrote: > Simple doc tag addition. > > These are files which describe an interface that has been with us since 1.5. > The files themselves were previously generated at build time, but have been > in the repo since jdk15. But the API is since 1.5.