Re: RFR: 8345684: OperatingSystemMXBean.getSystemCpuLoad() throws NPE [v3]

2024-12-09 Thread Fabian Meumertzheim
On Mon, 9 Dec 2024 12:27:21 GMT, Severin Gehwolf wrote: >> @kevinjwalls Thanks! Apologies in advance if this is not the right process, >> but could this be cherry-picked into JDK 21? > >> Apologies in advance if this is not the right process, but could this be >> cherry-picked into JDK 21? > >

Integrated: 8345684: OperatingSystemMXBean.getSystemCpuLoad() throws NPE

2024-12-09 Thread Fabian Meumertzheim
On Fri, 6 Dec 2024 17:05:42 GMT, Fabian Meumertzheim wrote: > The return value of Metrics#getCpuSetCpus may change over time, including > from non-null to null across the two calls in this method. This pull request has now been integrated. Changeset: d7ef3ac0 Author:Fabian Meumer

Re: RFR: 8345684: OperatingSystemMXBean.getSystemCpuLoad() throws NPE [v3]

2024-12-09 Thread Fabian Meumertzheim
On Mon, 9 Dec 2024 12:07:33 GMT, Kevin Walls wrote: >> Fabian Meumertzheim has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Empty commit to trigger CI checks > > I think we can consider that failure

Re: RFR: 8345684: OperatingSystemMXBean.getSystemCpuLoad() throws NPE [v3]

2024-12-09 Thread Fabian Meumertzheim
On Mon, 9 Dec 2024 10:07:14 GMT, Fabian Meumertzheim wrote: >> The return value of Metrics#getCpuSetCpus may change over time, including >> from non-null to null across the two calls in this method. > > Fabian Meumertzheim has updated the pull request incrementally with one &

Re: RFR: 8345684: OperatingSystemMXBean.getSystemCpuLoad() throws NPE [v3]

2024-12-09 Thread Fabian Meumertzheim
> The return value of Metrics#getCpuSetCpus may change over time, including > from non-null to null across the two calls in this method. Fabian Meumertzheim has updated the pull request incrementally with one additional commit since the last revision: Empty commit to trigger CI

Re: RFR: 8345684: OperatingSystemMXBean.getSystemCpuLoad() throws NPE [v2]

2024-12-06 Thread Fabian Meumertzheim
> The return value of Metrics#getCpuSetCpus may change over time, including > from non-null to null across the two calls in this method. Fabian Meumertzheim has updated the pull request incrementally with one additional commit since the last revision: Add comment - C

Re: RFR: 8345684: OperatingSystemMXBean.getSystemCpuLoad() throws NPE [v2]

2024-12-06 Thread Fabian Meumertzheim
On Fri, 6 Dec 2024 17:45:17 GMT, Roger Riggs wrote: >> Fabian Meumertzheim has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add comment > > src/jdk.management/unix/classes/com/sun/management/internal/Operat

RFR: 8345684: Prevent NPE in OperatingSystemImpl#isCpuSetSameAsHostCpuSet

2024-12-06 Thread Fabian Meumertzheim
The return value of Metrics#getCpuSetCpus may change over time, including from non-null to null across the two calls in this method. - Commit messages: - 8345684: Prevent NPE in OperatingSystemImpl#isCpuSetSameAsHostCpuSet Changes: https://git.openjdk.org/jdk/pull/22611/files Web

Re: RFR: 8240908: RetransformClass does not know about MethodParameters attribute [v3]

2024-01-12 Thread Fabian Meumertzheim
On Wed, 26 Jan 2022 16:38:41 GMT, Alex Menkov wrote: >> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Simplified the test, added comments > > Simplified the test (a lot of code was useful during development/debugging, > bu