On Mon, 12 Jun 2023 21:21:05 GMT, Justin Lu wrote:
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized changes next to the
On Mon, 12 Jun 2023 22:00:01 GMT, Justin Lu wrote:
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized changes next to the
On Mon, 20 Mar 2023 19:47:10 GMT, Eirik Bjorsnos wrote:
> Please review this PR which replaces the use of outdated JVM flags for
> setting up debugging in the test value004.java
>
> This is part of an ongoing effort to remove use of the outdated flag
> '-Djava.compiler&q
On Mon, 20 Mar 2023 20:53:41 GMT, Eirik Bjorsnos wrote:
> Please review this PR which removes the following outdated guard/check from
> SunCommandLineLauncher:
>
>
> if ((options.indexOf("-Djava.compiler=") != -1) &&
> (options.toLowerCase().i
On Mon, 20 Mar 2023 20:53:41 GMT, Eirik Bjorsnos wrote:
> Please review this PR which removes the following outdated guard/check from
> SunCommandLineLauncher:
>
>
> if ((options.indexOf("-Djava.compiler=") != -1) &&
> (options.toLowerCase().i
On Mon, 20 Mar 2023 19:47:10 GMT, Eirik Bjorsnos wrote:
> Please review this PR which replaces the use of outdated JVM flags for
> setting up debugging in the test value004.java
>
> This is part of an ongoing effort to remove use of the outdated flag
> '-Djava.compiler&q
On Tue, 21 Mar 2023 02:49:15 GMT, Chris Plummer wrote:
> Please make sure you run the jdk/com/sun/jdi tests and the jdb, jdwp, and jdi
> test under hotspot/jtreg/vmTestbase/nsk
Tests passed:
==
Test summary
==
TEST
On Mon, 20 Mar 2023 20:40:09 GMT, Eirik Bjorsnos wrote:
> I'll file a separate PR for SunCommandLineLauncher. Thanks for catching this,
> Chris!
Filed #13109. Since these are my first two PRs in the servicibility area, I
would appreciate an extra eye on the JBS issues to see tha
Please review this PR which removes the following outdated guard/check from
SunCommandLineLauncher:
if ((options.indexOf("-Djava.compiler=") != -1) &&
(options.toLowerCase().indexOf("-djava.compiler=none") == -1)) {
throw new IllegalConnectorArgumentsException("Cannot debug with a JIT
c
On Mon, 20 Mar 2023 20:34:19 GMT, Chris Plummer wrote:
> This is the first I've seen of this java.compiler setting w.r.t. debugging.
> Is this because at one point debugging required that the JIT be disabled, but
> no longer does? I found the following in
> com/sun/tools/jdi/SunCommandLineLaun
Please review this PR which replaces the use of outdated JVM flags for setting
up debugging in the test value004.java
This is part of an ongoing effort to remove use of the outdated flag
'-Djava.compiler" such that the option itself can eventually be removed.
-
Commit messages:
-
11 matches
Mail list logo
