Re: RFR: 8344187: Remove SecurityManager and related calls from java.instrument [v2]

2024-11-19 Thread Eirik Bjørsnøs
On Mon, 18 Nov 2024 10:50:24 GMT, Kevin Walls wrote: >> Remove redundant SecurityManager, AccessController references >> (following on from JDK-8338411: Implement JEP 486: Permanently Disable the >> Security Manager). >> >> test/jdk/java/lang/instrument/ still passing. > > Kevin Walls has updat

Re: RFR: 8344056: Use markdown format for man pages [v4]

2024-11-19 Thread Eirik Bjørsnøs
On Fri, 15 Nov 2024 14:50:21 GMT, Magnus Ihse Bursie wrote: >> Currently, the man pages are stored as troff (a text format) in the open >> repo, and a content-wise identical copy is stored as markdown (another text >> format) in the closed repo. >> >> Since markdown is preferred to troff in te

Re: RFR: 8344364: Remove unused SecurityManager-related imports from java.lang.instrument.ClassFileTransformer

2024-11-18 Thread Eirik Bjørsnøs
On Mon, 18 Nov 2024 06:56:12 GMT, Alan Bateman wrote: > JDK-8344187 has the changes for the java.instrument module, Kevin has a PR > coming with the changes. Thanks, withdrawing this PR. Added label `jep486` to JDK-8344187. - PR Comment: https://git.openjdk.org/jdk/pull/22184#issu

RFR: 8344364: Remove unused SecurityManager-related imports from java.lang.instrument.ClassFileTransformer

2024-11-18 Thread Eirik Bjørsnøs
Please review this trivial cleanup which removes unused imports of `java.security.AccessController` and `java.security.PrivilegedAction` from `java.lang.instrument.ClassFileTransformer`. History: These imports came with the new transform method introduced by the module system implementation in

Withdrawn: 8344364: Remove unused SecurityManager-related imports from java.lang.instrument.ClassFileTransformer

2024-11-18 Thread Eirik Bjørsnøs
On Sun, 17 Nov 2024 18:04:57 GMT, Eirik Bjørsnøs wrote: > Please review this trivial cleanup which removes unused imports of > `java.security.AccessController` and `java.security.PrivilegedAction` from > `java.lang.instrument.ClassFileTransformer`. > > History: These imports ca

RFD: Remove Hotspot-internal MBeans from sun.management

2024-03-19 Thread Eirik Bjørsnøs
Hi, Last September, Volker shared the observation that we have Hotspot-internal MBeans in sun.management which are strongly encapsulated and not used internally by OpenJDK besides their unit tests: https://www.mail-archive.com/core-libs-dev@openjdk.org/msg19878.html A summary of the email thread

Integrated: 8328341: Remove deprecated per-thread compiler stats in sun.management

2024-03-19 Thread Eirik Bjørsnøs
On Mon, 18 Mar 2024 09:42:13 GMT, Eirik Bjørsnøs wrote: > Please review this cleanup PR which removes per-thread compiler stats from > `sun.management` > > This removes: > > * The deprecated interface method > `HotspotCompilationMBean.getCompilerThreadSt

Re: RFR: 8328341: Remove deprecated per-thread compiler stats in sun.management

2024-03-19 Thread Eirik Bjørsnøs
On Mon, 18 Mar 2024 09:42:13 GMT, Eirik Bjørsnøs wrote: > Please review this cleanup PR which removes per-thread compiler stats from > `sun.management` > > This removes: > > * The deprecated interface method > `HotspotCompilationMBean.getCompilerThreadSt

RFR: 8328341: Remove deprecated per-thread compiler stats in sun.management

2024-03-18 Thread Eirik Bjørsnøs
Please review this cleanup PR which removes per-thread compiler stats from `sun.management` This removes: * The deprecated interface method `HotspotCompilationMBean.getCompilerThreadStats()` along with the implementation method in `HotspotCompilation` * The class returned by these methods, `Co

Re: [External] : Re: RFD: Can we remove per-thread compiler stats now?

2024-03-18 Thread Eirik Bjørsnøs
On Mon, Mar 18, 2024 at 2:31 PM Kevin Walls wrote: > Right, the existing Deprecated tag had me thinking this was a Java SE > interface that had begun the deprecation process. > > But it's not a published API. > Great, it seems we have consensus that we can go ahead and remove these deprecated me

Re: RFD: Can we remove per-thread compiler stats now?

2024-03-17 Thread Eirik Bjørsnøs
On Fri, Mar 15, 2024 at 7:54 PM Kevin Walls wrote: > https://openjdk.org/jeps/277 > > "An API element should not be removed from the Java SE specification > unless it has been delivered with an annotation of > @Deprecated(forRemoval=true) in a previous version of Java SE." > > > > So deprecation

RFD: Can we remove per-thread compiler stats now?

2024-03-14 Thread Eirik Bjørsnøs
Hello, Per-thread compiler performance counters were removed in JDK-8134607 [1] (JDK 9). The corresponding sun.management API was marked @Deprecated since it no longer returns any useful counter data. Has time come to remove this API now? My understanding is that since sun.management is an inter

Re: [External] : Re: JEP draft: Disallow the Dynamic Loading of Agents by Default

2023-05-01 Thread Eirik Bjørsnøs
> > Keep in mind two things: > > 1. Dynamically loaded agents are more limited in their capabilities than > agents loaded at startup because redefinition/retransformation is limited > to changing the body of existing methods. Redefinition can only fix issues > if you’re lucky. > > 2. Java offers no

Re: JEP draft: Disallow the Dynamic Loading of Agents by Default

2023-04-29 Thread Eirik Bjørsnøs
> > >Agents are used by profiling tools to instrument Java applications, > >but agents can also be misused to undermine the integrity of the > >Java Platform. > > I don't think it is fair to assume that profilers are the only "valid" > use case for agents and imply that all other use ca