Re: RFR: 8344562: Remove security manager dependency from module jdk.jdi

2024-11-20 Thread Brian Burkhalter
On Wed, 20 Nov 2024 13:33:27 GMT, Sean Mullan wrote: >> src/jdk.jdi/share/classes/com/sun/tools/jdi/VirtualMachineManagerImpl.java >> line 65: >> >>> 63: SecurityManager sm = System.getSecurityManager(); >>> 64: if (sm != null) { >>> 65: JDIPermission vmmPermission =

Integrated: 8344562: Remove security manager dependency from module jdk.jdi

2024-11-20 Thread Brian Burkhalter
On Tue, 19 Nov 2024 18:29:33 GMT, Brian Burkhalter wrote: > Trivial removal of the use of the `SecurityManager` from a single class. This pull request has now been integrated. Changeset: c4c6b1fe Author: Brian Burkhalter URL: https://git.openjdk.org/jdk/com

RFR: 8344562: Remove security manager dependency from module jdk.jdi

2024-11-19 Thread Brian Burkhalter
Trivial removal of the use of the `SecurityManager` from a single class. - Commit messages: - 8344562: Remove security manager dependency from module jdk.jdi Changes: https://git.openjdk.org/jdk/pull/22251/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22251&range=00 Iss

Re: RFR: 8338383: Implement JEP 491: Synchronize Virtual Threads without Pinning

2024-11-06 Thread Brian Burkhalter
On Thu, 17 Oct 2024 14:28:30 GMT, Patricio Chilano Mateo wrote: > This is the implementation of JEP 491: Synchronize Virtual Threads without > Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for > further details. > > In order to make the code review easier the changes hav

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v4]

2024-10-28 Thread Brian Burkhalter
On Mon, 28 Oct 2024 12:29:07 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338383: Implement JEP 491: Synchronize Virtual Threads without Pinning [v10]

2024-10-25 Thread Brian Burkhalter
On Fri, 25 Oct 2024 13:17:23 GMT, Patricio Chilano Mateo wrote: >> This is the implementation of JEP 491: Synchronize Virtual Threads without >> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for >> further details. >> >> In order to make the code review easier the change

Re: RFR: JDK-8327444: simplify RESTARTABLE macro usage in JDK codebase [v4]

2024-03-07 Thread Brian Burkhalter
On Thu, 7 Mar 2024 08:16:26 GMT, Matthias Baesken wrote: >> We define the RESTARTABLE macro again and again at a lot of places in the >> JDK native codebase. This could be centralized to avoid repeating it again >> and again ! > > Matthias Baesken has updated the pull request incrementally with

Re: RFR: JDK-8327444: simplify RESTARTABLE macro usage in JDK codebase [v3]

2024-03-06 Thread Brian Burkhalter
On Wed, 6 Mar 2024 16:30:23 GMT, Matthias Baesken wrote: >> We define the RESTARTABLE macro again and again at a lot of places in the >> JDK native codebase. This could be centralized to avoid repeating it again >> and again ! > > Matthias Baesken has updated the pull request incrementally with

Re: [jdk20] RFR: 8298888: ProblemList gc/g1/TestVerifyGCType.java on linux and macosx

2022-12-15 Thread Brian Burkhalter
On Thu, 15 Dec 2022 23:13:30 GMT, Daniel D. Daugherty wrote: > A batch of trivial fixes to ProblemList tests: > > [JDK-829](https://bugs.openjdk.org/browse/JDK-829) ProblemList > gc/g1/TestVerifyGCType.java on linux and macosx > [JDK-8298889](https://bugs.openjdk.org/browse/JDK-8298889

Re: RFR: 8293875: ProblemList sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 on linux-x64

2022-09-15 Thread Brian Burkhalter
On Thu, 15 Sep 2022 19:27:47 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 on linux-x64. Marked as reviewed by bpb (Reviewer). - PR: https://git.openjdk.org/jdk/pull/10293

Re: RFR: 8293512: ProblemList serviceability/tmtools/jstat/GcNewTest.java in -Xcomp mode

2022-09-07 Thread Brian Burkhalter
On Wed, 7 Sep 2022 21:53:06 GMT, Daniel D. Daugherty wrote: > Trivial fixes to ProblemList 4 tests that fail in the upper Tiers: > > [JDK-8293512](https://bugs.openjdk.org/browse/JDK-8293512) ProblemList > serviceability/tmtools/jstat/GcNewTest.java in -Xcomp mode > > [JDK-8293516](https://bug

Re: [jdk19] Integrated: 8290201: ProblemList com/sun/jdi/InvokeHangTest.java on macosx-x64 in vthread mode

2022-07-12 Thread Brian Burkhalter
On Tue, 12 Jul 2022 20:43:33 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList com/sun/jdi/InvokeHangTest.java on macosx-x64 in > vthread mode. > > The copyright header is missing in this ProblemList file and there is a > duplicate entry. > I'm fixing those also as long as I'm h

Re: [jdk19] RFR: 8289840: ProblemList vmTestbase/nsk/jdwp/ThreadReference/ForceEarlyReturn/forceEarlyReturn002/forceEarlyReturn002.java when run with vthread wrapper

2022-07-07 Thread Brian Burkhalter
On Wed, 6 Jul 2022 16:23:59 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > vmTestbase/nsk/jdwp/ThreadReference/ForceEarlyReturn/forceEarlyReturn002/forceEarlyReturn002.java > when run with vthread wrapper. Marked as reviewed by bpb (Reviewer). - PR: https://git.op

Re: [jdk19] RFR: 8289585: ProblemList sun/tools/jhsdb/JStackStressTest.java on linux-aarch64

2022-07-01 Thread Brian Burkhalter
On Fri, 1 Jul 2022 16:12:17 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList sun/tools/jhsdb/JStackStressTest.java on > linux-aarch64. Marked as reviewed by bpb (Reviewer). - PR: https://git.openjdk.org/jdk19/pull/100