On Tue, 25 Feb 2025 16:39:14 GMT, Thomas Stuefe wrote:
>>> > @robcasloz I identified and hopefully fixed a small issue that hit the
>>> > "disabled" path. Turns out we allocate arena chunks a lot more frequently
>>> > than I thought, and the new unconditional call to Thread::current() in
>>> >
On Tue, 25 Feb 2025 16:43:21 GMT, Thomas Stuefe wrote:
>> Greetings,
>>
>> This is a rewrite of the Compiler Memory Statistic. The primary new feature
>> is the capability to track allocations by C2 phases. This will allow for a
>> much faster, more thorough analysis of footprint issues.
>>
On Tue, 25 Feb 2025 16:13:48 GMT, Thomas Stuefe wrote:
>> src/hotspot/share/compiler/compilationMemStatInternals.hpp line 160:
>>
>>> 158: void init(T v){ start = cur = peak = v; }
>>> 159: void update(T v) { cur = v; if (v > peak) peak = v; }
>>> 160: dT end_delta() con
On Mon, 24 Feb 2025 09:58:47 GMT, SendaoYan wrote:
>> The tested address:port is hard code to '224.0.23.178:7095' by file
>> test/jdk/sun/management/jdp/ClientConnection.java. This address:port work
>> normally on most machines, but cannot work on machine which can not connect
>> to the intern
On Tue, 11 Feb 2025 09:03:24 GMT, SendaoYan wrote:
>> H all,
>>
>> This PR add `/native` keyword in the test header for virtual thread tests.
>> The `/native` keyword will make run the related tests by jtreg standalone
>> more friendly.
>>
>> I runed all the tests without -nativepath argument
> Cgroup V1 subsustem fails to initialize mounted controllers properly in
> certain cases, that may lead to controllers left undetected/inactive. We
> observed the behavior in CloudFoundry deployments, it affects also host
> systems.
>
> The relevant /proc/self/mountinfo line is
>
>
> 2207 21
On Tue, 25 Feb 2025 17:11:30 GMT, Severin Gehwolf wrote:
>>> This needs to explain exactly what is happening when. The current comment
>>> isn't even remotely explaining in detail what it does. What does "...
>>> handles the case when a process is moved between cgroups" mean exactly?
>>
>> Eit
On Tue, 25 Feb 2025 09:14:10 GMT, Matthias Baesken wrote:
> > I think you can optionally configure libjvm.so to be built for small size,
> > not performance
>
> Yes true for libjvm this is possible, it is the opt-size part of the minimal
> features set `JVM_FEATURES_minimal='compiler1 minimal
On Mon, 24 Feb 2025 23:33:01 GMT, Sergey Chernyshev
wrote:
>> `CgroupV1Controller::set_subsystem_path` needs high level comment update to
>> describe the logic happening.
>>
>> Testing:
And after the patch this would become this, right?
```
/sys/fs/cgroup/cpu,cpuacct/system.slice/g
On Tue, 25 Feb 2025 16:31:05 GMT, Sergey Chernyshev
wrote:
>> src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp line 42:
>>
>>> 40: * When runs in a container, the method handles the case
>>> 41: * when a process is moved between cgroups.
>>> 42: */
>>
>> This needs to explain exactly what i
On Tue, 25 Feb 2025 06:34:29 GMT, Ashutosh Mehra wrote:
>> Thomas Stuefe has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new c
On Tue, 25 Feb 2025 16:13:59 GMT, Thomas Stuefe wrote:
>> src/hotspot/share/compiler/compilationMemStatInternals.hpp line 92:
>>
>>> 90:
>>> 91: // A very simple fixed-width FIFO buffer, used for the phase timeline
>>> 92: template
>>
>> Would `size` be a better name than `max`?
>
> ok change
> Greetings,
>
> This is a rewrite of the Compiler Memory Statistic. The primary new feature
> is the capability to track allocations by C2 phases. This will allow for a
> much faster, more thorough analysis of footprint issues.
>
> Tracking Arena memory movement is not trivial since one needs
On Mon, 24 Feb 2025 08:56:51 GMT, Roberto Castañeda Lozano
wrote:
>>> @robcasloz I identified and hopefully fixed a small issue that hit the
>>> "disabled" path. Turns out we allocate arena chunks a lot more frequently
>>> than I thought, and the new unconditional call to Thread::current() in
On Tue, 25 Feb 2025 14:06:03 GMT, Severin Gehwolf wrote:
> This needs to explain exactly what is happening when. The current comment
> isn't even remotely explaining in detail what it does. What does "... handles
> the case when a process is moved between cgroups" mean exactly?
Either it shall
On Tue, 25 Feb 2025 06:03:21 GMT, Ashutosh Mehra wrote:
>> Thomas Stuefe has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new c
On Tue, 25 Feb 2025 05:57:28 GMT, Ashutosh Mehra wrote:
>> Thomas Stuefe has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new c
> Greetings,
>
> This is a rewrite of the Compiler Memory Statistic. The primary new feature
> is the capability to track allocations by C2 phases. This will allow for a
> much faster, more thorough analysis of footprint issues.
>
> Tracking Arena memory movement is not trivial since one needs
On Tue, 11 Feb 2025 15:56:39 GMT, Matthias Baesken wrote:
> The libjdwp is currently built with LOW optimization level, it could be built
> with SIZE optimization to lower the lib size by ~ 10 % on UNIX.
> On Windows LOW and SIZE currently translate to the same O1 optimization flag
> so no diff
On Tue, 11 Feb 2025 15:56:39 GMT, Matthias Baesken wrote:
> The libjdwp is currently built with LOW optimization level, it could be built
> with SIZE optimization to lower the lib size by ~ 10 % on UNIX.
> On Windows LOW and SIZE currently translate to the same O1 optimization flag
> so no diff
On Mon, 24 Feb 2025 23:33:01 GMT, Sergey Chernyshev
wrote:
>> `CgroupV1Controller::set_subsystem_path` needs high level comment update to
>> describe the logic happening.
>>
>> Testing:
And after the patch this would become this, right?
```
/sys/fs/cgroup/cpu,cpuacct/system.slice/g
On Mon, 24 Feb 2025 21:20:49 GMT, Sergey Chernyshev
wrote:
>> Cgroup V1 subsustem fails to initialize mounted controllers properly in
>> certain cases, that may lead to controllers left undetected/inactive. We
>> observed the behavior in CloudFoundry deployments, it affects also host
>> syste
On Tue, 25 Feb 2025 13:13:13 GMT, Julian Waters wrote:
> >
> > I am not sure if it is currently a good idea to set LTO for all JDK native
> > libs; but for some it might work well and be beneficial.
>
> Maybe I can prepare a changeset for this and send the diff just to get a
> cursory review
On Tue, 25 Feb 2025 13:09:08 GMT, Matthias Baesken wrote:
> > I'm not sure what that line in Flags.gmk has to do with LTO support, since
> > it's setting the optimization levels.
>
> We could offer there another option LTO, additionally to LOW, HIGH, HIGHEST,
> SIZE etc. .
>
> > I don't think
On Tue, 25 Feb 2025 09:33:58 GMT, Julian Waters wrote:
> I'm not sure what that line in Flags.gmk has to do with LTO support, since
> it's setting the optimization levels.
We could offer there another option LTO, additionally to LOW, HIGH, HIGHEST,
SIZE etc. .
> I don't think we should do it
On Mon, 24 Feb 2025 11:40:03 GMT, Kevin Walls wrote:
> Trivial removal of confusing "Tonga" references in comments within a few JMX
> tests.
This pull request has now been integrated.
Changeset: 8cfebc41
Author:Kevin Walls
URL:
https://git.openjdk.org/jdk/commit/8cfebc41dc8ec7b0d24
On Thu, 30 Jan 2025 12:12:29 GMT, Albert Mingkun Yang wrote:
> Here is an attempt to simplify GCLocker implementation for Serial and
> Parallel.
>
> GCLocker prevents GC when Java threads are in a critical region (i.e.,
> calling JNI critical APIs). JDK-7129164 introduces an optimization that
On Tue, 18 Feb 2025 09:20:57 GMT, Albert Mingkun Yang wrote:
>> Here is an attempt to simplify GCLocker implementation for Serial and
>> Parallel.
>>
>> GCLocker prevents GC when Java threads are in a critical region (i.e.,
>> calling JNI critical APIs). JDK-7129164 introduces an optimization
On Mon, 24 Feb 2025 10:19:42 GMT, Roberto Castañeda Lozano
wrote:
>> Thomas Stuefe has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains on
On Mon, 24 Feb 2025 10:10:50 GMT, Roberto Castañeda Lozano
wrote:
>> Thomas Stuefe has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains on
On Tue, 25 Feb 2025 09:12:30 GMT, Matthias Baesken wrote:
> > Absence of benchmarking and given the relatively small footprint savings, I
> > don't think we should switch to SIZE. LTO seems fine. I don't know of any
> > negative impacts with using it.
>
> @TheShermanTanker , @magicus what do
On Tue, 25 Feb 2025 02:31:29 GMT, Chris Plummer wrote:
> Absence of benchmarking and given the relatively small footprint savings, I
> don't think we should switch to SIZE. LTO seems fine. I don't know of any
> negative impacts with using it.
@TheShermanTanker , @magicus what do you think ?
32 matches
Mail list logo
