Re: RFR: 8349638: Build libjdwp with SIZE optimization

2025-02-20 Thread Matthias Baesken
On Thu, 20 Feb 2025 21:39:17 GMT, Chris Plummer wrote: > I just don't feel comfortable tinkering with the flags in this manner when we > aren't sure of the potential performance impact. The footprint improvement is > somewhat negligible in the big picture. Without good benchmarks it is hard to

Re: RFR: 8347433: Deprecate XML interchange in java.management/javax/management/modelmbean/DescriptorSupport for removal [v2]

2025-02-20 Thread Serguei Spitsyn
On Thu, 13 Feb 2025 12:30:32 GMT, Kevin Walls wrote: >> DescriptorSupport has a constructor and a method providing creation from, >> and export to, XML. >> >> These are unused in the JDK and have no practical known examples of usage. >> XML parsing is best done by an independent implementatio

Re: RFR: 8347433: Deprecate XML interchange in java.management/javax/management/modelmbean/DescriptorSupport for removal [v2]

2025-02-20 Thread Serguei Spitsyn
On Thu, 13 Feb 2025 12:30:32 GMT, Kevin Walls wrote: >> DescriptorSupport has a constructor and a method providing creation from, >> and export to, XML. >> >> These are unused in the JDK and have no practical known examples of usage. >> XML parsing is best done by an independent implementatio

Re: RFR: 8280682: Refactor AOT code source validation checks [v4]

2025-02-20 Thread Calvin Cheung
On Thu, 20 Feb 2025 00:35:51 GMT, Vladimir Kozlov wrote: > Passing by comment. We touched it on recent Leyden meeting. The name > "AOTCodeSource" is very confusing. Especially when we start caching AOT > compiled code. Can we rename it to avoid confusion? Per our discussions, I've renamed "AOT

Re: RFR: 8280682: Refactor AOT code source validation checks [v5]

2025-02-20 Thread Calvin Cheung
On Thu, 20 Feb 2025 07:29:07 GMT, David Holmes wrote: >> How about adding the vm_exit in >> `ClassLoaderDataShared::ensure_module_entry_table_exist()` instead of assert? >> >> >> void ClassLoaderDataShared::ensure_module_entry_table_exist(oop >> class_loader) { >> Handle h_loader(JavaThread

Re: RFR: 8280682: Refactor AOT code source validation checks [v5]

2025-02-20 Thread Calvin Cheung
> This changset refactors CDS class paths and module paths validation code into > a new class `AOTCodeSource` and related class `AOTCodeSourceConfig`. Code has > been moved from filemap.[c|h]pp, classLoader.[c|h]pp, and > classLoaderExt.[c|h]pp to aotCodeSource.[c|h]pp. CDS dependencies have bee

Re: RFR: 8350287: Cleanup SA's support for CodeBlob subclasses [v2]

2025-02-20 Thread Serguei Spitsyn
On Wed, 19 Feb 2025 05:49:56 GMT, Chris Plummer wrote: >> There is a lot of subclassing of CodeBlob types done in SA to mimic hotspot, >> but most of it is unnecessary. The generic CodeBlob class can handle all >> support needed by most of the subclasses. The only subclasses we need to >> keep

Re: RFR: 8349638: Build libjdwp with SIZE optimization

2025-02-20 Thread Chris Plummer
On Tue, 11 Feb 2025 15:56:39 GMT, Matthias Baesken wrote: > The libjdwp is currently built with LOW optimization level, it could be built > with SIZE optimization to lower the lib size by ~ 10 % on UNIX. > On Windows LOW and SIZE currently translate to the same O1 optimization flag > so no diff

RFR: 8261669: Add lint warning for widening primitive conversions that lose information

2025-02-20 Thread Archie Cobbs
This PR is a prototype to stimulate discussion of [JDK-8261669](https://bugs.openjdk.org/browse/JDK-8261669), which seeks to add more warnings when an implicit cast of a primitive value might lose information. This can possibly happen when converting an `int` to `float`, or when converting a `l

Re: RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v13]

2025-02-20 Thread Sergey Chernyshev
> Cgroup V1 subsustem fails to initialize mounted controllers properly in > certain cases, that may lead to controllers left undetected/inactive. We > observed the behavior in CloudFoundry deployments, it affects also host > systems. > > The relevant /proc/self/mountinfo line is > > > 2207 21

Re: RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v11]

2025-02-20 Thread Sergey Chernyshev
On Mon, 17 Feb 2025 15:48:51 GMT, Matthias Baesken wrote: >> Sergey Chernyshev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> added details in the log message > > src/java.base/linux/classes/jdk/internal/platform/cgroupv2/CgroupV2Subsys

Re: RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v11]

2025-02-20 Thread Sergey Chernyshev
On Mon, 17 Feb 2025 11:09:12 GMT, Severin Gehwolf wrote: >> Sergey Chernyshev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> added details in the log message > > src/java.base/linux/classes/jdk/internal/platform/cgroupv1/CgroupV1Subsyst

Re: RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v12]

2025-02-20 Thread Sergey Chernyshev
> Cgroup V1 subsustem fails to initialize mounted controllers properly in > certain cases, that may lead to controllers left undetected/inactive. We > observed the behavior in CloudFoundry deployments, it affects also host > systems. > > The relevant /proc/self/mountinfo line is > > > 2207 21

Re: RFR: 8328866: Add raw monitor rank support to the debug agent [v13]

2025-02-20 Thread Chris Plummer
> This PR adds ranked monitor support to the debug agent. The debug agent has a > large number of monitors, and it's really hard to know which order to grab > them in, and for that matter which monitors might already be held at any > given moment. By imposing a rank on each monitor, we can check

Re: RFR: 8336881: [Linux] Support for hierarchical limits for Metrics [v16]

2025-02-20 Thread Severin Gehwolf
> Please review this fix for cgroups-based metrics reporting in the > `jdk.internal.platform` package. This fix is supposed to address wrong > reporting of certain limits if the limits aren't set at the leaf nodes. > > For example, on cg v2, the memory limit interface file is `memory.max`. > Co

Re: RFR: 8344009: Improve compiler memory statistics

2025-02-20 Thread Roberto Castañeda Lozano
On Wed, 19 Feb 2025 09:49:54 GMT, Roberto Castañeda Lozano wrote: >>> > Hi Thomas, this looks very useful, thanks! I will run some >>> > Oracle-internal functional and performance testing and come back with the >>> > results next week. >>> >>> Functional test results (Oracle internal tier1-ti

Re: RFR: 8344009: Improve compiler memory statistics

2025-02-20 Thread Thomas Stuefe
On Wed, 19 Feb 2025 09:49:54 GMT, Roberto Castañeda Lozano wrote: >>> > Hi Thomas, this looks very useful, thanks! I will run some >>> > Oracle-internal functional and performance testing and come back with the >>> > results next week. >>> >>> Functional test results (Oracle internal tier1-ti

Re: RFR: 8349638: Build libjdwp with SIZE optimization

2025-02-20 Thread Matthias Baesken
On Wed, 19 Feb 2025 17:12:55 GMT, Chris Plummer wrote: > I'm not sure how the decision was made to go with LOW for libjdwp. >From what I heard from Magnus, those settings were done ages ago , before >recent compiler switches and even before the current build system was >introduced. We switch

Re: RFR: 8344009: Improve compiler memory statistics [v4]

2025-02-20 Thread Thomas Stuefe
> Greetings, > > This is a rewrite of the Compiler Memory Statistic. The primary new feature > is the capability to track allocations by C2 phases. This will allow for a > much faster, more thorough analysis of footprint issues. > > Tracking Arena memory movement is not trivial since one needs

Re: RFR: 8344009: Improve compiler memory statistics [v3]

2025-02-20 Thread Thomas Stuefe
> Greetings, > > This is a rewrite of the Compiler Memory Statistic. The primary new feature > is the capability to track allocations by C2 phases. This will allow for a > much faster, more thorough analysis of footprint issues. > > Tracking Arena memory movement is not trivial since one needs