On Thu, 20 Feb 2025 07:11:19 GMT, Calvin Cheung wrote:
>> I don't see anything there that does a vm_exit if something has gone wrong.
>> ??
>
> How about adding the vm_exit in
> `ClassLoaderDataShared::ensure_module_entry_table_exist()` instead of assert?
>
>
> void ClassLoaderDataShared::ens
On Thu, 20 Feb 2025 02:15:01 GMT, David Holmes wrote:
>> It is now being handled in
>> `ClassLoaderDataShared::ensure_module_entry_tables_exist()` and
>> `AOTCodeSourceConfig::dumptime_init_helper()`.
>
> I don't see anything there that does a vm_exit if something has gone wrong. ??
How about
On Wed, 19 Feb 2025 22:37:48 GMT, Calvin Cheung wrote:
>> src/hotspot/share/runtime/threads.cpp line 809:
>>
>>> 807:
>>> vm_exit_during_initialization("ClassLoader::initialize_module_path() failed
>>> unexpectedly");
>>> 808: }
>>> 809: #endif
>>
>> Not obvious where this functionality
> This changset refactors CDS class paths and module paths validation code into
> a new class `AOTCodeSource` and related class `AOTCodeSourceConfig`. Code has
> been moved from filemap.[c|h]pp, classLoader.[c|h]pp, and
> classLoaderExt.[c|h]pp to aotCodeSource.[c|h]pp. CDS dependencies have bee
On Thu, 20 Feb 2025 00:18:36 GMT, Calvin Cheung wrote:
>> This changset refactors CDS class paths and module paths validation code
>> into a new class `AOTCodeSource` and related class `AOTCodeSourceConfig`.
>> Code has been moved from filemap.[c|h]pp, classLoader.[c|h]pp, and
>> classLoaderEx
On Wed, 19 Feb 2025 22:37:57 GMT, Calvin Cheung wrote:
>> test/hotspot/jtreg/runtime/cds/appcds/BootClassPathMismatch.java line 243:
>>
>>> 241: * No error - bootclasspath can be appended during runtime if no
>>> -cp is specified.
>>> 242: */
>>> 243: public void testBootClassPath
On Tue, 18 Feb 2025 07:22:00 GMT, David Holmes wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @ashu-mehra and @dholmes-ora comments
>
> src/hotspot/share/runtime/threads.cpp line 809:
>
>> 807:
>> vm_exit_d
On Tue, 18 Feb 2025 05:21:09 GMT, Ashutosh Mehra wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @iklam and @ashu-mehra comment
>
> src/hotspot/share/runtime/threads.cpp line 27:
>
>> 25: */
>> 26:
>> 27: #incl
On Tue, 18 Feb 2025 07:08:07 GMT, David Holmes wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @iklam and @ashu-mehra comment
>
> src/hotspot/share/cds/aotCodeSource.cpp line 2:
>
>> 1: /*
>> 2: * Copyright (c)
> This changset refactors CDS class paths and module paths validation code into
> a new class `AOTCodeSource` and related class `AOTCodeSourceConfig`. Code has
> been moved from filemap.[c|h]pp, classLoader.[c|h]pp, and
> classLoaderExt.[c|h]pp to aotCodeSource.[c|h]pp. CDS dependencies have bee
On Wed, 19 Feb 2025 15:27:25 GMT, Matthias Baesken wrote:
> So what's the opinion, should we go for SIZE optimization for libjdwp?
> My idea was that the current setting LOW indicates that the lib is not super
> performance critical; so SIZE might be a nice option ?
I'm not sure how the decisio
On Wed, 19 Feb 2025 05:49:56 GMT, Chris Plummer wrote:
>> There is a lot of subclassing of CodeBlob types done in SA to mimic hotspot,
>> but most of it is unnecessary. The generic CodeBlob class can handle all
>> support needed by most of the subclasses. The only subclasses we need to
>> keep
On Tue, 18 Feb 2025 23:38:35 GMT, Chris Plummer wrote:
>> When doing a STEP_OVER, the debug agent does a NotifyFramePop() on the
>> current frame as a safety net. After the STEP_OVER completes, the
>> NotifyFramePop() is usually still in place. This keeps the thread in
>> interp_only mode, wh
On Tue, 18 Feb 2025 09:20:57 GMT, Albert Mingkun Yang wrote:
>> Here is an attempt to simplify GCLocker implementation for Serial and
>> Parallel.
>>
>> GCLocker prevents GC when Java threads are in a critical region (i.e.,
>> calling JNI critical APIs). JDK-7129164 introduces an optimization
On Tue, 11 Feb 2025 15:56:39 GMT, Matthias Baesken wrote:
> The libjdwp is currently built with LOW optimization level, it could be built
> with SIZE optimization to lower the lib size by ~ 10 % on UNIX.
> On Windows LOW and SIZE currently translate to the same O1 optimization flag
> so no diff
On Tue, 18 Feb 2025 09:20:57 GMT, Albert Mingkun Yang wrote:
>> Here is an attempt to simplify GCLocker implementation for Serial and
>> Parallel.
>>
>> GCLocker prevents GC when Java threads are in a critical region (i.e.,
>> calling JNI critical APIs). JDK-7129164 introduces an optimization
On Tue, 18 Feb 2025 23:06:42 GMT, Ian Myers wrote:
>> make/common/Modules.gmk line 95:
>>
>>> 93: SPEC_SUBDIRS += share/specs
>>> 94:
>>> 95: MAN_SUBDIRS += share/man windows/man
>>
>> Hm, normally I'd say you should use `$(TARGET_OS)/man`, but we typically
>> generate docs for all platforms
On Wed, 19 Feb 2025 06:35:38 GMT, Thomas Stuefe wrote:
> > > Hi Thomas, this looks very useful, thanks! I will run some
> > > Oracle-internal functional and performance testing and come back with the
> > > results next week.
> >
> >
> > Functional test results (Oracle internal tier1-tier5) lo
On Tue, 18 Feb 2025 23:38:35 GMT, Chris Plummer wrote:
>> When doing a STEP_OVER, the debug agent does a NotifyFramePop() on the
>> current frame as a safety net. After the STEP_OVER completes, the
>> NotifyFramePop() is usually still in place. This keeps the thread in
>> interp_only mode, wh
19 matches
Mail list logo
