Re: RFR: 8280682: Refactor AOT code source validation checks [v2]

2025-02-17 Thread David Holmes
On Fri, 14 Feb 2025 19:21:32 GMT, Calvin Cheung wrote: >> This changset refactors CDS class paths and module paths validation code >> into a new class `AOTCodeSource` and related class `AOTCodeSourceConfig`. >> Code has been moved from filemap.[c|h]pp, classLoader.[c|h]pp, and >> classLoaderEx

Re: RFR: 8280682: Refactor AOT code source validation checks [v2]

2025-02-17 Thread Ashutosh Mehra
On Fri, 14 Feb 2025 19:21:32 GMT, Calvin Cheung wrote: >> This changset refactors CDS class paths and module paths validation code >> into a new class `AOTCodeSource` and related class `AOTCodeSourceConfig`. >> Code has been moved from filemap.[c|h]pp, classLoader.[c|h]pp, and >> classLoaderEx

Re: RFR: 8349088: De-virtualize Codeblob and nmethod [v10]

2025-02-17 Thread Chris Plummer
On Sat, 15 Feb 2025 06:34:56 GMT, Vladimir Kozlov wrote: >> Remove virtual methods from CodeBlob and nmethod to simplify >> saving/restoring in Leyden AOT cache. It avoids the need to patch hidden >> VPTR pointer to class's virtual table. >> >> Added C++ static asserts to make sure no virtual

Re: RFR: 8229012: When single stepping, the debug agent can cause the thread to remain in interpreter mode after single stepping completes [v4]

2025-02-17 Thread Chris Plummer
On Mon, 17 Feb 2025 09:14:12 GMT, Kevin Walls wrote: >> Chris Plummer has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix white space errors. > > src/jdk.jdwp.agent/share/native/libjdwp/stepControl.c line 899: > >> 897: } >> 898: >

Re: RFR: 8192647: GClocker induced GCs can starve threads requiring memory leading to OOME [v2]

2025-02-17 Thread David Holmes
On Sat, 15 Feb 2025 11:49:53 GMT, Albert Mingkun Yang wrote: > I have removed the new API, and switched to use the original in_critical(). You still need it to be an atomic load together with whatever compiler barriers that implies, otherwise it can be hoisted out of the spin-loop: while (cur-

Re: RFR: 8192647: GClocker induced GCs can starve threads requiring memory leading to OOME [v3]

2025-02-17 Thread David Holmes
On Sat, 15 Feb 2025 11:44:44 GMT, Albert Mingkun Yang wrote: >> Here is an attempt to simplify GCLocker implementation for Serial and >> Parallel. >> >> GCLocker prevents GC when Java threads are in a critical region (i.e., >> calling JNI critical APIs). JDK-7129164 introduces an optimization

Re: RFR: 8349638: Build libjdwp with SIZE optimization

2025-02-17 Thread Chris Plummer
On Mon, 17 Feb 2025 09:04:55 GMT, Matthias Baesken wrote: > btw for libjdwp with lto enabled (have to modify the make settings because > this is not supported out of the box) I get > > 1.8M ./lib/libjdwp.debuginfo 280K ./lib/libjdwp.so > > This looks pretty good compared to HIGH or standard (L

Re: RFR: 8347123: Add missing @serial tags to other modules [v2]

2025-02-17 Thread Alan Bateman
On Fri, 24 Jan 2025 10:58:24 GMT, Hannes Wallnöfer wrote: >> Please review a doc-only change to mostly add missing `@serial` javadoc >> tags. This is a sub-task of [JDK-8286931] to allow us to re-enable the >> javadoc `-serialwarn` option in the JDK doc build, which has been disabled >> since

Re: RFR: 8349088: De-virtualize Codeblob and nmethod [v10]

2025-02-17 Thread Vladimir Kozlov
On Mon, 17 Feb 2025 06:24:35 GMT, Axel Boldt-Christmas wrote: >> Vladimir Kozlov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove commented lines left by mistake > > src/hotspot/share/code/codeBlob.hpp line 308: > >> 306: >> 307

Re: RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v11]

2025-02-17 Thread Matthias Baesken
On Thu, 12 Dec 2024 01:11:33 GMT, Sergey Chernyshev wrote: >> Cgroup V1 subsustem fails to initialize mounted controllers properly in >> certain cases, that may lead to controllers left undetected/inactive. We >> observed the behavior in CloudFoundry deployments, it affects also host >> syste

Integrated: 8347123: Add missing @serial tags to other modules

2025-02-17 Thread Hannes Wallnöfer
On Wed, 8 Jan 2025 20:13:50 GMT, Hannes Wallnöfer wrote: > Please review a doc-only change to mostly add missing `@serial` javadoc tags. > This is a sub-task of [JDK-8286931] to allow us to re-enable the javadoc > `-serialwarn` option in the JDK doc build, which has been disabled since JDK > 1

Re: RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v11]

2025-02-17 Thread Severin Gehwolf
On Thu, 12 Dec 2024 01:11:33 GMT, Sergey Chernyshev wrote: >> Cgroup V1 subsustem fails to initialize mounted controllers properly in >> certain cases, that may lead to controllers left undetected/inactive. We >> observed the behavior in CloudFoundry deployments, it affects also host >> syste

Re: RFR: 8344009: Improve compiler memory statistics

2025-02-17 Thread Johan Sjölen
On Fri, 14 Feb 2025 06:37:55 GMT, Thomas Stuefe wrote: > We also save a copy of the counters to a global table that contains the N > most expensive compilations. That table will be printed when one uses jcmd > Compiler.memory. We also print it into the hs-err file. This is a new tool for me,

Re: RFR: 8229012: When single stepping, the debug agent can cause the thread to remain in interpreter mode after single stepping completes [v4]

2025-02-17 Thread Kevin Walls
On Mon, 27 Jan 2025 19:41:19 GMT, Chris Plummer wrote: >> When doing a STEP_OVER, the debug agent does a NotifyFramePop() on the >> current frame as a safety net. After the STEP_OVER completes, the >> NotifyFramePop() is usually still in place. This keeps the thread in >> interp_only mode, wh

Re: RFR: 8229012: When single stepping, the debug agent can cause the thread to remain in interpreter mode after single stepping completes [v4]

2025-02-17 Thread Kevin Walls
On Mon, 27 Jan 2025 19:41:19 GMT, Chris Plummer wrote: >> When doing a STEP_OVER, the debug agent does a NotifyFramePop() on the >> current frame as a safety net. After the STEP_OVER completes, the >> NotifyFramePop() is usually still in place. This keeps the thread in >> interp_only mode, wh

Re: RFR: 8349638: Build libjdwp with SIZE optimization

2025-02-17 Thread Matthias Baesken
On Tue, 11 Feb 2025 15:56:39 GMT, Matthias Baesken wrote: > The libjdwp is currently built with LOW optimization level, it could be built > with SIZE optimization to lower the lib size by ~ 10 % on UNIX. > On Windows LOW and SIZE currently translate to the same O1 optimization flag > so no diff