Re: RFR: 8349689: Several virtual thread tests missing /native keyword [v2]

2025-02-10 Thread SendaoYan
On Tue, 11 Feb 2025 07:26:04 GMT, Alan Bateman wrote: >> SendaoYan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add --enable-native-access=ALL-UNNAMED for >> test/jdk/java/lang/management/ThreadMXBean/VirtualThreads.java#default > >

Re: RFR: 8349689: Several virtual thread tests missing /native keyword [v2]

2025-02-10 Thread SendaoYan
> H all, > > This PR add `/native` keyword in the test header for virtual thread tests. > The `/native` keyword will make run the related tests by jtreg standalone > more friendly. > > I runed all the tests without -nativepath argument and find the fail tests. > This will find all the virtual

Re: RFR: 8349689: Several virtual thread tests missing /native keyword

2025-02-10 Thread Alan Bateman
On Tue, 11 Feb 2025 02:45:11 GMT, SendaoYan wrote: > H all, > > This PR add `/native` keyword in the test header for virtual thread tests. > The `/native` keyword will make run the related tests by jtreg standalone > more friendly. > > I runed all the tests without -nativepath argument and fi

Re: RFR: 8349689: Several virtual thread tests missing /native keyword

2025-02-10 Thread Alan Bateman
On Tue, 11 Feb 2025 02:45:11 GMT, SendaoYan wrote: > H all, > > This PR add `/native` keyword in the test header for virtual thread tests. > The `/native` keyword will make run the related tests by jtreg standalone > more friendly. > > I runed all the tests without -nativepath argument and fi

Re: RFR: 8280682: Refactor AOT code source validation checks

2025-02-10 Thread Ioi Lam
On Wed, 5 Feb 2025 22:32:58 GMT, Calvin Cheung wrote: > This changset refactors CDS class paths and module paths validation code into > a new class `AOTCodeSource` and related class `AOTCodeSourceConfig`. Code has > been moved from filemap.[c|h]pp, classLoader.[c|h]pp, and > classLoaderExt.[c|

RFR: 8349689: Several virtual thread tests missing /native keyword

2025-02-10 Thread SendaoYan
H all, This PR add `/native` keyword in the test header for virtual thread tests. The `/native` keyword will make run the related tests by jtreg standalone more friendly. I runed all the tests without -nativepath argument and find the fail tests. This will find all the virtual thread tests whi

RFR: 8349723: Problemlist jdp tests for macosx-x64

2025-02-10 Thread Kevin Walls
Trivial problemlist update. Problemlist should be expanded for macosx, from just aarch64 to all, for these JDP tests, as x64 has occasional failures. - ### Progress - [ ] Change must be properly reviewed (1 review required, with at least 1 [Reviewer](https://openjdk.org/bylaws#reviewer

Re: RFR: 8319055: JCMD should not buffer the whole output of commands [v3]

2025-02-10 Thread Johan Sjölen
On Tue, 4 Feb 2025 20:12:44 GMT, Alex Menkov wrote: > > I didn't really understand what makes this streaming. The old protocol > > first sent out the result, and then the data, has this changed? > > The protocol works as before. All command handlers are updated to set the > result code earlier

Re: RFR: 8348347: Cleanup JavaThread subclass support in SA [v2]

2025-02-10 Thread Chris Plummer
On Mon, 10 Feb 2025 17:49:11 GMT, Kevin Walls wrote: > I think we need a HiddenJavaThread class, and "visibility" cannot just be a > boolean field in JavaThread, because virtualConstructor.addMapping wants a > mapping to a class that will already know whether it's hidden. > As I just learned f

Re: RFR: 8348347: Cleanup JavaThread subclass support in SA [v2]

2025-02-10 Thread Kevin Walls
On Thu, 6 Feb 2025 22:44:48 GMT, Chris Plummer wrote: >> Cleanup SA JavaThread support. Details in first comment: >> >> Testing: >> - Tier1 >> - Tier2 svc >> - Tier3 >> - Tier5 svc >> - Local testing of debuggee using graal java compiler threads. Verified that >> the compiler threads shows up i

Re: RFR: 8349088: De-virtualize Codeblob and nmethod [v2]

2025-02-10 Thread Vladimir Kozlov
On Mon, 10 Feb 2025 16:23:53 GMT, Stefan Karlsson wrote: >> Vladimir Kozlov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix Zero and Minimal VM builds > > We have a similar situation with oopDesc that are not allowed to have a > vta

Re: RFR: 8349088: De-virtualize Codeblob and nmethod [v2]

2025-02-10 Thread Vladimir Kozlov
On Mon, 10 Feb 2025 03:25:30 GMT, Chris Plummer wrote: >> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/CodeCache.java line >> 38: >> >>> 36: public class CodeCache { >>> 37: private static GrowableArray heapArray; >>> 38: private static VirtualConstructor virtualConstructor; >>

Re: RFR: 8349088: De-virtualize Codeblob and nmethod [v2]

2025-02-10 Thread Stefan Karlsson
On Sun, 9 Feb 2025 19:43:29 GMT, Vladimir Kozlov wrote: >> Remove virtual methods from CodeBlob and nmethod to simplify >> saving/restoring in Leyden AOT cache. It avoids the need to patch hidden >> VPTR pointer to class's virtual table. >> >> Added C++ static asserts to make sure no virtual m

Re: RFR: 8349088: De-virtualize Codeblob and nmethod [v2]

2025-02-10 Thread Vladimir Kozlov
On Mon, 10 Feb 2025 11:04:38 GMT, Andrew Dinn wrote: >> Vladimir Kozlov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix Zero and Minimal VM builds > > src/hotspot/share/code/codeBlob.cpp line 58: > >> 56: #include >> 57: >> 58: //

Re: RFR: 8346567: Make Class.getModifiers() non-native [v7]

2025-02-10 Thread Coleen Phillimore
On Fri, 7 Feb 2025 12:34:40 GMT, Coleen Phillimore wrote: >> The Class.getModifiers() method is implemented as a native method in >> java.lang.Class to access a field that we've calculated when creating the >> mirror. The field is final after that point. The VM doesn't need it >> anymore, so

Integrated: 8346567: Make Class.getModifiers() non-native

2025-02-10 Thread Coleen Phillimore
On Mon, 9 Dec 2024 19:26:53 GMT, Coleen Phillimore wrote: > The Class.getModifiers() method is implemented as a native method in > java.lang.Class to access a field that we've calculated when creating the > mirror. The field is final after that point. The VM doesn't need it anymore, > so ther

Re: RFR: 8349088: De-virtualize Codeblob and nmethod [v2]

2025-02-10 Thread Andrew Dinn
On Sun, 9 Feb 2025 19:43:29 GMT, Vladimir Kozlov wrote: >> Remove virtual methods from CodeBlob and nmethod to simplify >> saving/restoring in Leyden AOT cache. It avoids the need to patch hidden >> VPTR pointer to class's virtual table. >> >> Added C++ static asserts to make sure no virtual m

Re: RFR: 8349088: De-virtualize Codeblob and nmethod

2025-02-10 Thread Doug Simon
On Sun, 9 Feb 2025 19:36:28 GMT, Vladimir Kozlov wrote: > @dougxc and @tkrodriguez, please look if it affects Graal. I'm pretty sure JVMCI does not care about the virtual-ness of these C++ classes. Running tier9 in mach5 is a good way to be sure. - PR Comment: https://git.openjdk.

Re: RFR: 8346567: Make Class.getModifiers() non-native [v7]

2025-02-10 Thread Yudi Zheng
On Fri, 7 Feb 2025 12:34:40 GMT, Coleen Phillimore wrote: >> The Class.getModifiers() method is implemented as a native method in >> java.lang.Class to access a field that we've calculated when creating the >> mirror. The field is final after that point. The VM doesn't need it >> anymore, so