Re: Proposal to change the behavior of the timestamp place holder (%t) in log file paths

2025-01-30 Thread David Holmes
On 31/01/2025 4:03 am, Laurence Cable wrote: On 1/30/25 9:42 AM, Kemper, William wrote: Thank you all for your comments. We've gotten by using the pid (%p) as a means of grouping log files from a process. The log messages themselves include the uptime, so having the start time of the JVM in

Re: RFR: 8347123: Add missing @serial tags to other modules [v2]

2025-01-30 Thread Nizar Benalla
On Fri, 24 Jan 2025 10:58:24 GMT, Hannes Wallnöfer wrote: >> Please review a doc-only change to mostly add missing `@serial` javadoc >> tags. This is a sub-task of [JDK-8286931] to allow us to re-enable the >> javadoc `-serialwarn` option in the JDK doc build, which has been disabled >> since

[jdk24] Integrated: 8348975: Broken links in the JDK 24 JavaDoc API documentation, build 33

2025-01-30 Thread Nizar Benalla
On Thu, 30 Jan 2025 10:42:43 GMT, Nizar Benalla wrote: > Hi all, > > This pull request contains a backport of commit > [22069ff4](https://github.com/openjdk/jdk/commit/22069ff42b7e5c3058415ef9b6e0b50b9d2c16ef) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit be

Re: [jdk24] RFR: 8348975: Broken links in the JDK 24 JavaDoc API documentation, build 33

2025-01-30 Thread Nizar Benalla
On Thu, 30 Jan 2025 10:42:43 GMT, Nizar Benalla wrote: > Hi all, > > This pull request contains a backport of commit > [22069ff4](https://github.com/openjdk/jdk/commit/22069ff42b7e5c3058415ef9b6e0b50b9d2c16ef) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit be

Re: RFR: 8349039: Adjust exception No type named in database

2025-01-30 Thread Chris Plummer
On Thu, 30 Jan 2025 10:22:17 GMT, Matthias Baesken wrote: > We should the exception message from > Caused by: java.lang.RuntimeException: No type named > "DeoptimizeObjectsALotThread" in database > to > Caused by: java.lang.RuntimeException: No type named > "DeoptimizeObjectsALotThread" present

Re: Proposal to change the behavior of the timestamp place holder (%t) in log file paths

2025-01-30 Thread Laurence Cable
On 1/30/25 9:42 AM, Kemper, William wrote: Thank you all for your comments. We've gotten by using the pid (%p) as a means of grouping log files from a process. The log messages themselves include the uptime, so having the start time of the JVM in the file name has not been useful (and it w

Re: Proposal to change the behavior of the timestamp place holder (%t) in log file paths

2025-01-30 Thread Kemper, William
Thank you all for your comments. We've gotten by using the pid (%p) as a means of grouping log files from a process. The log messages themselves include the uptime, so having the start time of the JVM in the file name has not been useful (and it would be trivial to add in from startup scripts).

Re: Proposal to change the behavior of the timestamp place holder (%t) in log file paths

2025-01-30 Thread Laurence Cable
On 1/29/25 5:56 PM, David Holmes wrote: Adding back serviceability-dev David On 30/01/2025 11:55 am, David Holmes wrote: Plus one to what Kevin says. The current specified behaviour seems to me to be what would be generally desired. If there is a desire for a different kind of timestamp t

Re: [jdk24] RFR: 8348975: Broken links in the JDK 24 JavaDoc API documentation, build 33

2025-01-30 Thread Chen Liang
On Thu, 30 Jan 2025 10:42:43 GMT, Nizar Benalla wrote: > Hi all, > > This pull request contains a backport of commit > [22069ff4](https://github.com/openjdk/jdk/commit/22069ff42b7e5c3058415ef9b6e0b50b9d2c16ef) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit be

Re: RFR: 8349039: Adjust exception No type named in database

2025-01-30 Thread Kevin Walls
On Thu, 30 Jan 2025 10:22:17 GMT, Matthias Baesken wrote: > We should the exception message from > Caused by: java.lang.RuntimeException: No type named > "DeoptimizeObjectsALotThread" in database > to > Caused by: java.lang.RuntimeException: No type named > "DeoptimizeObjectsALotThread" present

RFR: 8192647: GClocker induced GCs can starve threads requiring memory leading to OOME

2025-01-30 Thread Albert Mingkun Yang
Here is an attempt to simplify GCLocker implementation for Serial and Parallel. GCLocker prevents GC when Java threads are in a critical region (i.e., calling JNI critical APIs). JDK-7129164 introduces an optimization that updates a shared variable (used to track the number of threads in the cri

[jdk24] RFR: 8348975: Broken links in the JDK 24 JavaDoc API documentation, build 33

2025-01-30 Thread Nizar Benalla
Hi all, This pull request contains a backport of commit [22069ff4](https://github.com/openjdk/jdk/commit/22069ff42b7e5c3058415ef9b6e0b50b9d2c16ef) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Nizar Benalla on 30 Jan 2025 and was re

RFR: 8349039: Adjust exception No type named in database

2025-01-30 Thread Matthias Baesken
We should the exception message from Caused by: java.lang.RuntimeException: No type named "DeoptimizeObjectsALotThread" in database to Caused by: java.lang.RuntimeException: No type named "DeoptimizeObjectsALotThread" present in type database (like we have in some other exceptions in the same cl

Integrated: 8348975: Broken links in the JDK 24 JavaDoc API documentation, build 33

2025-01-30 Thread Nizar Benalla
On Wed, 29 Jan 2025 16:03:38 GMT, Nizar Benalla wrote: > Two groups of broken links appeared in the latest JDK docs, broken links to > man pages and broken ietf links. > > - The windows tools markdown files were not being converted to HTML because > they were placed under `windows/man` rather

Re: RFR: 8348975: Broken links in the JDK 24 JavaDoc API documentation, build 33

2025-01-30 Thread Nizar Benalla
On Wed, 29 Jan 2025 16:03:38 GMT, Nizar Benalla wrote: > Two groups of broken links appeared in the latest JDK docs, broken links to > man pages and broken ietf links. > > - The windows tools markdown files were not being converted to HTML because > they were placed under `windows/man` rather

Integrated: 8300708: Some nsk jvmti tests fail with virtual thread wrapper due to jvmti missing some virtual thread support

2025-01-30 Thread Serguei Spitsyn
On Mon, 27 Jan 2025 11:24:33 GMT, Serguei Spitsyn wrote: > Some `nsk.jvmti` tests are failed with the `-testThreadFactory:Virtual`, so > they are listed in the `test/hotspot/jtreg/ProblemList-Virtual.txt`. > > The fix is to adjust tests expectations regarding tested virtual threads to > expect

Re: RFR: 8300708: Some nsk jvmti tests fail with virtual thread wrapper due to jvmti missing some virtual thread support [v3]

2025-01-30 Thread Serguei Spitsyn
On Tue, 28 Jan 2025 14:08:26 GMT, Serguei Spitsyn wrote: >> Some `nsk.jvmti` tests are failed with the `-testThreadFactory:Virtual`, so >> they are listed in the `test/hotspot/jtreg/ProblemList-Virtual.txt`. >> >> The fix is to adjust tests expectations regarding tested virtual threads to >> e

Re: RFR: 8348567: [ASAN] Memory access partially overflows by NativeCallStack

2025-01-30 Thread SendaoYan
On Fri, 24 Jan 2025 09:53:43 GMT, SendaoYan wrote: > Hi all, > This PR fix a undefined behaviour in 'CollisionsReceiveDifferentIndexes' > testcase > locate in 'test/hotspot/gtest/nmt/test_nmt_nativecallstackstorage.cpp' file > when call `NativeCallStack::NativeCallStack` function. Before this

Integrated: 8348567: [ASAN] Memory access partially overflows by NativeCallStack

2025-01-30 Thread SendaoYan
On Fri, 24 Jan 2025 09:53:43 GMT, SendaoYan wrote: > Hi all, > This PR fix a undefined behaviour in 'CollisionsReceiveDifferentIndexes' > testcase > locate in 'test/hotspot/gtest/nmt/test_nmt_nativecallstackstorage.cpp' file > when call `NativeCallStack::NativeCallStack` function. Before this

Integrated: 8347779: sun/tools/jhsdb/HeapDumpTestWithActiveProcess.java fails with Unable to deduce type of thread from address

2025-01-30 Thread Matthias Baesken
On Tue, 21 Jan 2025 13:24:41 GMT, Matthias Baesken wrote: > We were running into this error : > sun/tools/jhsdb/HeapDumpTestWithActiveProcess.java on Linux aarch64, jdk25 > > stderr: [java.lang.RuntimeException: Unable to deduce type of thread from > address 0x34144e30 (expected type Ja

Re: RFR: 8347779: sun/tools/jhsdb/HeapDumpTestWithActiveProcess.java fails with Unable to deduce type of thread from address [v4]

2025-01-30 Thread Matthias Baesken
On Wed, 29 Jan 2025 12:46:29 GMT, Matthias Baesken wrote: >> We were running into this error : >> sun/tools/jhsdb/HeapDumpTestWithActiveProcess.java on Linux aarch64, jdk25 >> >> stderr: [java.lang.RuntimeException: Unable to deduce type of thread from >> address 0x34144e30 (expected ty