On Thu, 16 Jan 2025 17:53:48 GMT, Leonid Mesnik wrote:
>> test/lib/jdk/test/lib/hprof/parser/ReadBuffer.java line 46:
>>
>>> 44: public int getInt(long pos) throws IOException;
>>> 45: public long getLong(long pos) throws IOException;
>>> 46: public void close() throws IOExceptio
On Thu, 16 Jan 2025 18:18:15 GMT, Leonid Mesnik wrote:
>> There few compiler warning disabled in the testlibary build.
>> They should be fixed or localized and removed from build to prevent new
>> possible issues.
>>
>> The main goal is to avoid new such issues in the testlibrary.
>> Tested wi
On Thu, 16 Jan 2025 16:48:02 GMT, Coleen Phillimore wrote:
> Please review this change to replace SIZE_FORMAT with %zu in the runtime
> code. The second and third commits are hand editing for fixing up formats of
> the code, not the output. After this, there'll be a separate change to
> remo
On Thu, 16 Jan 2025 16:48:02 GMT, Coleen Phillimore wrote:
> Please review this change to replace SIZE_FORMAT with %zu in the runtime
> code. The second and third commits are hand editing for fixing up formats of
> the code, not the output. After this, there'll be a separate change to
> remo
On Fri, 17 Jan 2025 01:07:29 GMT, Zhengyu Gu wrote:
> It leaks _frames array and frames stored inside the array
Looks good.
-
Marked as reviewed by sspitsyn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23169#pullrequestreview-2557904693
On Thu, 16 Jan 2025 13:05:58 GMT, Kevin Walls wrote:
> Remove the System Property "jmx.tabular.data.hash.map" which was introduced
> historically for JMX compatibility with JDK 1.3 clients.
Marked as reviewed by sspitsyn (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/23
On Thu, 16 Jan 2025 10:31:09 GMT, Kevin Walls wrote:
> jmx.remote.x.buffer.size was a previous and incorrect name for the
> jmx.remote.x.notification.buffer.size property.
>
> The old name was still recognised to aid compatibility.
> That was 2004. We should only recognise the correct name a
On Thu, 16 Jan 2025 12:20:14 GMT, Kevin Walls wrote:
> Classes should not override
> javax.management.openmbean.OpenType.getClassName(), and this was made illegal
> (caused an Exception) in JDK6. A System Property jmx.extend.open.types was
> introduced to allow such an override, for compatibi
On Thu, 16 Jan 2025 09:31:11 GMT, Kevin Walls wrote:
>> Remove the System Property "jmx.mxbean.multiname" which was introduced in
>> JDK-7 for compatibility with code which may have depended on previous
>> incorrect behaviour. Removal is long overdue.
>
> Kevin Walls has updated the pull reque
> The test lacks a synchronization, so it is added by this fix.
>
> Testing:
> - Ran the failing test `vmTestbase/nsk/jvmti/GetThreadCpuTime/thrcputime002`
> - TBD: submit mach5 tiers 1-5
Serguei Spitsyn has updated the pull request incrementally with one additional
commit since the last revis
On Fri, 17 Jan 2025 01:07:29 GMT, Zhengyu Gu wrote:
> It leaks _frames array and frames stored inside the array
Marked as reviewed by amenkov (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/23169#pullrequestreview-2557823941
On Thu, 16 Jan 2025 22:39:48 GMT, Chris Plummer wrote:
>> The test lacks a synchronization, so it is added by this fix.
>>
>> Testing:
>> - Ran the failing test `vmTestbase/nsk/jvmti/GetThreadCpuTime/thrcputime002`
>> - TBD: submit mach5 tiers 1-5
>
> test/hotspot/jtreg/vmTestbase/nsk/jvmti/Ge
It leaks _frames array and frames stored inside the array
-
Commit messages:
- 8347959: ThreadDumper leaks memory
Changes: https://git.openjdk.org/jdk/pull/23169/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23169&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8347
On Thu, 16 Jan 2025 09:15:28 GMT, Serguei Spitsyn wrote:
> The test lacks a synchronization, so it is added by this fix.
>
> Testing:
> - Ran the failing test `vmTestbase/nsk/jvmti/GetThreadCpuTime/thrcputime002`
> - TBD: submit mach5 tiers 1-5
test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetThrea
On Thu, 16 Jan 2025 12:20:14 GMT, Kevin Walls wrote:
> Classes should not override
> javax.management.openmbean.OpenType.getClassName(), and this was made illegal
> (caused an Exception) in JDK6. A System Property jmx.extend.open.types was
> introduced to allow such an override, for compatibi
On Thu, 16 Jan 2025 10:31:09 GMT, Kevin Walls wrote:
> jmx.remote.x.buffer.size was a previous and incorrect name for the
> jmx.remote.x.notification.buffer.size property.
>
> The old name was still recognised to aid compatibility.
> That was 2004. We should only recognise the correct name a
On Thu, 16 Jan 2025 09:31:11 GMT, Kevin Walls wrote:
>> Remove the System Property "jmx.mxbean.multiname" which was introduced in
>> JDK-7 for compatibility with code which may have depended on previous
>> incorrect behaviour. Removal is long overdue.
>
> Kevin Walls has updated the pull reque
On Thu, 16 Jan 2025 09:15:28 GMT, Serguei Spitsyn wrote:
> The test lacks a synchronization, so it is added by this fix.
>
> Testing:
> - Ran the failing test `vmTestbase/nsk/jvmti/GetThreadCpuTime/thrcputime002`
> - TBD: submit mach5 tiers 1-5
Marked as reviewed by amenkov (Reviewer).
-
On Thu, 16 Jan 2025 12:20:14 GMT, Kevin Walls wrote:
> Classes should not override
> javax.management.openmbean.OpenType.getClassName(), and this was made illegal
> (caused an Exception) in JDK6. A System Property jmx.extend.open.types was
> introduced to allow such an override, for compatibi
Please review this change to replace SIZE_FORMAT with %zu in the runtime code.
The second and third commits are hand editing for fixing up formats of the
code, not the output. After this, there'll be a separate change to remove
SIZE_FORMAT. Note that SIZE_FORMAT_X_0 depends on LP64 so that ma
On Thu, 16 Jan 2025 13:05:58 GMT, Kevin Walls wrote:
> Remove the System Property "jmx.tabular.data.hash.map" which was introduced
> historically for JMX compatibility with JDK 1.3 clients.
Marked as reviewed by cjplummer (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/2
On Thu, 16 Jan 2025 18:14:39 GMT, Leonid Mesnik wrote:
>> There few compiler warning disabled in the testlibary build.
>> They should be fixed or localized and removed from build to prevent new
>> possible issues.
>>
>> The main goal is to avoid new such issues in the testlibrary.
>> Tested wi
On Thu, 16 Jan 2025 07:09:46 GMT, Alan Bateman wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> revert change
>
> test/lib/jdk/test/lib/thread/VThreadPinner.java line 97:
>
>> 95: * virtual thread then it inv
> There few compiler warning disabled in the testlibary build.
> They should be fixed or localized and removed from build to prevent new
> possible issues.
>
> The main goal is to avoid new such issues in the testlibrary.
> Tested with tier1-5 to ensure that all tests were passed.
Leonid Mesnik
On Thu, 16 Jan 2025 05:31:44 GMT, David Holmes wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> revert change
>
> test/lib/jdk/test/lib/format/ArrayDiff.java line 110:
>
>> 108: * @return an ArrayDiff instanc
> There few compiler warning disabled in the testlibary build.
> They should be fixed or localized and removed from build to prevent new
> possible issues.
>
> The main goal is to avoid new such issues in the testlibrary.
> Tested with tier1-5 to ensure that all tests were passed.
Leonid Mesnik
Remove the System Property "jmx.tabular.data.hash.map" which was introduced
historically for JMX compatibility with JDK 1.3 clients.
-
Commit messages:
- 8345049: Remove the jmx.tabular.data.hash.map compatibility property
Changes: https://git.openjdk.org/jdk/pull/23153/files
Web
Classes should not override javax.management.openmbean.OpenType.getClassName(),
and this was made illegal (caused an Exception) in JDK6. A System Property
jmx.extend.open.types was introduced to allow such an override, for
compatibility reasons.
This was not documented but was mentioned in the
jmx.remote.x.buffer.size was a previous and incorrect name for the
jmx.remote.x.notification.buffer.size property.
The old name was still recognised to aid compatibility.
That was 2004. We should only recognise the correct name at this point.
-
Commit messages:
- 8345045: Remove
> Remove the System Property "jmx.mxbean.multiname" which was introduced in
> JDK-7 for compatibility with code which may have depended on previous
> incorrect behaviour. Removal is long overdue.
Kevin Walls has updated the pull request incrementally with one additional
commit since the last r
On Thu, 16 Jan 2025 01:04:39 GMT, Alex Menkov wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> test update/simplification
>
> test/jdk/javax/management/mxbean/SameObjectTwoNamesTest.java line 43:
>
>> 41:
>> 42:
The test lacks a synchronization, so it is added by this fix.
Testing:
- Ran the failing test `vmTestbase/nsk/jvmti/GetThreadCpuTime/thrcputime002`
- TBD: submit mach5 tiers 1-5
-
Commit messages:
- 8332857: Test
vmTestbase/nsk/jvmti/GetThreadCpuTime/thrcputime002/TestDescription
32 matches
Mail list logo
