Re: RFR: 8346123: [REDO] NMT should not use ThreadCritical [v15]

2025-01-12 Thread Thomas Stuefe
On Thu, 9 Jan 2025 14:27:56 GMT, Robert Toyonaga wrote: >> This is a redo of [JDK-8304824](https://bugs.openjdk.org/browse/JDK-8304824) >> which was backed out by >> [JDK-8343726](https://bugs.openjdk.org/browse/JDK-8343726) due to problems >> documented in [JDK-8343244](https://bugs.openjdk.o

Re: RFR: 8346990: Remove INTX_FORMAT and UINTX_FORMAT macros [v5]

2025-01-12 Thread David Holmes
On Tue, 7 Jan 2025 12:51:33 GMT, Coleen Phillimore wrote: >> There are a lot of format modifiers that are noisy and unnecessary in the >> code. This change removes the INTX variants. It's not that disruptive even >> for backporting because %z modifier has been available for a long time so >>

Re: RFR: 8346383: Cannot use DllMain in libdt_socket for static builds

2025-01-12 Thread David Holmes
On Tue, 17 Dec 2024 11:10:01 GMT, Magnus Ihse Bursie wrote: > To be able to properly support static builds on Windows in > [JDK-8346377](https://bugs.openjdk.org/browse/JDK-8346377), we cannot use > `DllMain`, for two reasons: > > 1) This is not called for statically linked libraries, and > 2)

Re: RFR: 8346123: [REDO] NMT should not use ThreadCritical [v15]

2025-01-12 Thread David Holmes
On Fri, 10 Jan 2025 19:15:29 GMT, Robert Toyonaga wrote: > For JavaThreads: In attach_current_thread, create_stack_guard_pages() and register_thread_stack_with_NMT() are called before Threads::add. You can't attach to a VM until a certain point deep into initialization has been reached. > For

Integrated: 8346717: serviceability/dcmd/vm/SystemDumpMapTest.java failing on Windows with "Stack base not yet set for thread id"

2025-01-12 Thread Simon Tooke
On Mon, 23 Dec 2024 18:43:07 GMT, Simon Tooke wrote: > This test fixes an issue with incomplete Windows threads not yet having a > stack. A test for a null stack_base is added to guard against the potential > null dereference. An additional test using ZGC is added to the jtreg > SystemMapTes

Re: RFR: 8342682: Errors related to unused code on Windows after 8339120 in dt_shmem jdwp security and jpackage [v7]

2025-01-12 Thread Julian Waters
On Mon, 11 Nov 2024 09:51:35 GMT, Julian Waters wrote: >> After 8339120, gcc began catching many different instances of unused code in >> the Windows specific codebase. Some of these seem to be bugs. I've taken the >> effort to mark out all the relevant globals and locals that trigger the >> u