On Thu, 2 Jan 2025 13:20:20 GMT, Coleen Phillimore wrote:
>> Please review this change that makes AccessFlags and modifier_flags u2 types
>> and removes the last remnants of Hotspot adding internal access flags. This
>> change moves AccessFlags and modifier_flags in Klass to alignment gaps
>>
The fix updates client side of OSX implementation to support Attach API v2.
Server side is shared with Linux and was updated by #3.
The changes are identical to client-side changes for Linux from #3.
Testing: tier1,tier2,tier3,tier4,hs-tier5-svc
-
Commit messages:
- attach_v
On Wed, 25 Dec 2024 02:34:16 GMT, Qizheng Xing wrote:
>> This patch fixes unmatched brackets in some files, mostly in comments, docs
>> and man pages.
>
> Qizheng Xing has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert fix in the CTW M
On Wed, 25 Dec 2024 02:34:16 GMT, Qizheng Xing wrote:
>> This patch fixes unmatched brackets in some files, mostly in comments, docs
>> and man pages.
>
> Qizheng Xing has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert fix in the CTW M
On Thu, 2 Jan 2025 13:20:20 GMT, Coleen Phillimore wrote:
>> Please review this change that makes AccessFlags and modifier_flags u2 types
>> and removes the last remnants of Hotspot adding internal access flags. This
>> change moves AccessFlags and modifier_flags in Klass to alignment gaps
>>
> This test fixes an issue with incomplete Windows threads not yet having a
> stack. A test for a null stack_base is added to guard against the potential
> null dereference. An additional test using ZGC is added to the jtreg
> SystemMapTest.
Simon Tooke has updated the pull request incrementa
On Wed, 25 Dec 2024 02:34:16 GMT, Qizheng Xing wrote:
>> This patch fixes unmatched brackets in some files, mostly in comments, docs
>> and man pages.
>
> Qizheng Xing has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert fix in the CTW M
On Thu, 2 Jan 2025 13:05:10 GMT, Coleen Phillimore wrote:
>> src/hotspot/cpu/ppc/templateInterpreterGenerator_ppc.cpp line 149:
>>
>>> 147: // _access_flags must be a 16 bit value.
>>> 148: assert(sizeof(AccessFlags) == 2, "wrong size");
>>> 149: __ lha(R11_scratch1/*access_flags*/,
> Please review this change that makes AccessFlags and modifier_flags u2 types
> and removes the last remnants of Hotspot adding internal access flags. This
> change moves AccessFlags and modifier_flags in Klass to alignment gaps saving
> 16 bytes. From pahole: so it's a bit better.
>
> befor
On Thu, 2 Jan 2025 13:08:12 GMT, Coleen Phillimore wrote:
>> Please review this change that makes AccessFlags and modifier_flags u2 types
>> and removes the last remnants of Hotspot adding internal access flags. This
>> change moves AccessFlags and modifier_flags in Klass to alignment gaps
>>
> Please review this change that makes AccessFlags and modifier_flags u2 types
> and removes the last remnants of Hotspot adding internal access flags. This
> change moves AccessFlags and modifier_flags in Klass to alignment gaps saving
> 16 bytes. From pahole: so it's a bit better.
>
> befor
Hi all,
sadebugd and related options in jhsdb have been deprecated by JDK-8338894 since
JDK 24. I agree with RMI removal from SA, but I'd like to keep remote debugger
feature for some cases.
For example, sadebugd can be used to debug in distroless container on
Kubernetes. As you know distrole
On Wed, 25 Dec 2024 16:40:19 GMT, Martin Doerr wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Restore ACC in comment.
>
> src/hotspot/cpu/ppc/templateInterpreterGenerator_ppc.cpp line 149:
>
>> 147: // _
> Please review this change that makes AccessFlags and modifier_flags u2 types
> and removes the last remnants of Hotspot adding internal access flags. This
> change moves AccessFlags and modifier_flags in Klass to alignment gaps saving
> 16 bytes. From pahole: so it's a bit better.
>
> befor
> Please review this change that makes AccessFlags and modifier_flags u2 types
> and removes the last remnants of Hotspot adding internal access flags. This
> change moves AccessFlags and modifier_flags in Klass to alignment gaps saving
> 16 bytes. From pahole: so it's a bit better.
>
> befor
On Fri, 20 Dec 2024 21:34:58 GMT, Dean Long wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Restore ACC in comment.
>
> src/hotspot/share/oops/method.cpp line 1655:
>
>> 1653: return;
>> 1654: }
>> 1655
On Thu, 2 Jan 2025 12:34:59 GMT, Coleen Phillimore wrote:
>> The instruction looks still correct. We are checking the same bit of the 64
>> bit register as before. (Using `testbitdi` would also work.)
>
> I changed this to testbitdi.
Ok.
-
PR Review Comment: https://git.openjdk.or
On Wed, 25 Dec 2024 16:34:27 GMT, Martin Doerr wrote:
>> It wasn't the logic. When I went through I didn't know if this instruction
>> needed fixing because we loaded an unsigned short instead of an int. So I
>> left myself a note to look at it again that you noticed and I didn't in my
>> fi
18 matches
Mail list logo
