Re: RFR: 8345422: Fix JNI Checker "in native method" warnings in the debug agent and debugger tests

2024-12-03 Thread David Holmes
On Tue, 3 Dec 2024 20:16:33 GMT, Chris Plummer wrote: > The root cause of [JDK-8344804](https://bugs.openjdk.org/browse/JDK-8344804) > seems to be some JNI Checker warnings. I decided to resolve all the warnings > in the debug agent and debugger tests that start with "in native method". > This

Re: RFR: 8345422: Fix JNI Checker "in native method" warnings in the debug agent and debugger tests

2024-12-03 Thread Chris Plummer
On Wed, 4 Dec 2024 05:38:14 GMT, David Holmes wrote: >> That might be nice, but we don't do it in other places where we have this >> pattern. This call should never fail, thus the "fatal error" approach. > > Sure but when it does fail because of a bug the person trying to debug it > will lament

Re: RFR: 8345422: Fix JNI Checker "in native method" warnings in the debug agent and debugger tests

2024-12-03 Thread David Holmes
On Wed, 4 Dec 2024 04:53:08 GMT, Chris Plummer wrote: >> src/jdk.jdwp.agent/share/native/libjdwp/ModuleReferenceImpl.c line 56: >> >>> 54: JNI_FUNC_PTR(env,ExceptionClear)(env); // keep -Xcheck:jni happy >>> 55: ERROR_MESSAGE(("JNI Exception occurred calling >>> Module.getName()

Re: RFR: 8305010: Test vmTestbase/nsk/jvmti/scenarios/sampling/SP05/sp05t003/TestDescription.java timed out: thread not suspended

2024-12-03 Thread Chris Plummer
On Wed, 4 Dec 2024 03:07:46 GMT, Alex Menkov wrote: > The PR fixes race in the test between ThreadStart/ThreadEnd callbacks and > agent thread: > The callbacks increments event counter and then do self-suspend; > Agent thread waits when expected number of events is received, then performs > ver

Re: RFR: 8345422: Fix JNI Checker "in native method" warnings in the debug agent and debugger tests

2024-12-03 Thread Chris Plummer
On Wed, 4 Dec 2024 02:07:13 GMT, David Holmes wrote: >> The root cause of [JDK-8344804](https://bugs.openjdk.org/browse/JDK-8344804) >> seems to be some JNI Checker warnings. I decided to resolve all the warnings >> in the debug agent and debugger tests that start with "in native method". >> T

RFR: 8305010: Test vmTestbase/nsk/jvmti/scenarios/sampling/SP05/sp05t003/TestDescription.java timed out: thread not suspended

2024-12-03 Thread Alex Menkov
The PR fixes race in the test between ThreadStart/ThreadEnd callbacks and agent thread: The callbacks increments event counter and then do self-suspend; Agent thread waits when expected number of events is received, then performs verification and resumes the thread, but expected counter value doe

Re: RFR: 8345422: Fix JNI Checker "in native method" warnings in the debug agent and debugger tests

2024-12-03 Thread David Holmes
On Tue, 3 Dec 2024 20:16:33 GMT, Chris Plummer wrote: > The root cause of [JDK-8344804](https://bugs.openjdk.org/browse/JDK-8344804) > seems to be some JNI Checker warnings. I decided to resolve all the warnings > in the debug agent and debugger tests that start with "in native method". > This

Re: RFR: 8343957: Rename ObjectMonitor::owner_from() and JavaThread::_lock_id

2024-12-03 Thread David Holmes
On Tue, 3 Dec 2024 19:10:55 GMT, Patricio Chilano Mateo wrote: > Please review this small renaming patch. During the review of JDK-8338383 > there were some comments about improving the naming for > `ObjectMonitor::owner_from()` and `JavaThread::_lock_id`. These originate > from the changes i

Integrated: 8345341: Fix incorrect log message in JDI stop002t test

2024-12-03 Thread Chris Plummer
On Mon, 2 Dec 2024 21:49:59 GMT, Chris Plummer wrote: > The log message is wrong. Copy-n-paste bug from another part of the test. > > I'd like to push this as a trivial change. This pull request has now been integrated. Changeset: 42378970 Author:Chris Plummer URL: https://git.open

Re: RFR: 8345341: Fix incorrect log message in JDI stop002t test

2024-12-03 Thread Chris Plummer
On Mon, 2 Dec 2024 21:49:59 GMT, Chris Plummer wrote: > The log message is wrong. Copy-n-paste bug from another part of the test. > > I'd like to push this as a trivial change. Thanks Alex and Leonid! - PR Comment: https://git.openjdk.org/jdk/pull/22499#issuecomment-2515851469

Re: RFR: 8343957: Rename ObjectMonitor::owner_from() and JavaThread::_lock_id

2024-12-03 Thread Coleen Phillimore
On Tue, 3 Dec 2024 19:10:55 GMT, Patricio Chilano Mateo wrote: > Please review this small renaming patch. During the review of JDK-8338383 > there were some comments about improving the naming for > `ObjectMonitor::owner_from()` and `JavaThread::_lock_id`. These originate > from the changes i

Re: RFR: 8345341: Fix incorrect log message in JDI stop002t test

2024-12-03 Thread Leonid Mesnik
On Mon, 2 Dec 2024 21:49:59 GMT, Chris Plummer wrote: > The log message is wrong. Copy-n-paste bug from another part of the test. > > I'd like to push this as a trivial change. Marked as reviewed by lmesnik (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/22499#pullreques

Re: RFR: 8345422: Fix JNI Checker "in native method" warnings in the debug agent and debugger tests

2024-12-03 Thread Chris Plummer
On Tue, 3 Dec 2024 20:16:33 GMT, Chris Plummer wrote: > The root cause of [JDK-8344804](https://bugs.openjdk.org/browse/JDK-8344804) > seems to be some JNI Checker warnings. I decided to resolve all the warnings > in the debug agent and debugger tests that start with "in native method". > This

Integrated: 8344987: Test serviceability/sa/TestJhsdbJstackPrintVMLocks.java fails: NoClassDefFoundError: jdk/test/lib/Utils

2024-12-03 Thread Leonid Mesnik
On Wed, 27 Nov 2024 02:13:41 GMT, Leonid Mesnik wrote: > The real bug is > https://bugs.openjdk.org/browse/CODETOOLS-7902847 Class directory of a test > case should not be used to compile a library > > and the following workaround just excludes the testing group where it fails > often. > > T

RFR: 8345422: Fix JNI Checker "in native method" warnings in the debug agent and debugger tests

2024-12-03 Thread Chris Plummer
The root cause of [JDK-8344804](https://bugs.openjdk.org/browse/JDK-8344804) seems to be some JNI Checker warnings. I decided to resolve all the warnings in the debug agent and debugger tests that start with "in native method". This seems to have resolved [JDK-8344804](https://bugs.openjdk.org/

Re: RFR: 8345341: Fix incorrect log message in JDI stop002t test

2024-12-03 Thread Alex Menkov
On Mon, 2 Dec 2024 21:49:59 GMT, Chris Plummer wrote: > The log message is wrong. Copy-n-paste bug from another part of the test. > > I'd like to push this as a trivial change. Looks good and trivial - Marked as reviewed by amenkov (Reviewer). PR Review: https://git.openjdk.org/j

RFR: 8343957: Rename ObjectMonitor::owner_from() and JavaThread::_lock_id

2024-12-03 Thread Patricio Chilano Mateo
Please review this small renaming patch. During the review of JDK-8338383 there were some comments about improving the naming for `ObjectMonitor::owner_from()` and `JavaThread::_lock_id`. These originate from the changes introduced to inflated monitors, where we now record the `java.lang.Thread.

Re: RFR: 8345148: Fix for JDK-8337317 is incomplete

2024-12-03 Thread Chris Plummer
On Thu, 28 Nov 2024 01:30:58 GMT, Alex Menkov wrote: > Fix for JDK-8337317 (#20699) updated serviceability/jvmti/HiddenClass and > serviceability/jvmti/VMObjectAlloc tests adding guards against > JVMTI_ERROR_WRONG_PHASE errors, but missed to enable JVMTI_EVENT_VM_DEATH > events. > This fix add

Re: RFR: 8344987: Test serviceability/sa/TestJhsdbJstackPrintVMLocks.java fails: NoClassDefFoundError: jdk/test/lib/Utils

2024-12-03 Thread Chris Plummer
On Wed, 27 Nov 2024 02:13:41 GMT, Leonid Mesnik wrote: > The real bug is > https://bugs.openjdk.org/browse/CODETOOLS-7902847 Class directory of a test > case should not be used to compile a library > > and the following workaround just excludes the testing group where it fails > often. > > T

RFR: 8345341: Fix incorrect log message in JDI stop002t test

2024-12-03 Thread Chris Plummer
The log message is wrong. Copy-n-paste bug from another part of the test. I'd like to push this as a trivial change. - Commit messages: - fix log message Changes: https://git.openjdk.org/jdk/pull/22499/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22499&range=00 Issue:

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v8]

2024-12-03 Thread Daniel Fuchs
On Tue, 3 Dec 2024 06:14:31 GMT, Jaikiran Pai wrote: >> src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemController.java >> line 68: >> >>> 66: try (Stream lines = Files.lines(filePath)) { >>> 67: Optional firstLine = lines.findFirst(); >>> 68: re

Re: RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v8]

2024-12-03 Thread Sergey Chernyshev
On Sat, 30 Nov 2024 00:30:02 GMT, Sergey Chernyshev wrote: >> Cgroup V1 subsustem fails to initialize mounted controllers properly in >> certain cases, that may lead to controllers left undetected/inactive. We >> observed the behavior in CloudFoundry deployments, it affects also host >> syste

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v9]

2024-12-03 Thread Jaikiran Pai
On Tue, 3 Dec 2024 06:12:13 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which removes usages of >> SecurityManager related APIs and some leftover related to SecurityManager >> changes? >> >> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these >>

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v9]

2024-12-03 Thread Alan Bateman
On Tue, 3 Dec 2024 06:12:13 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which removes usages of >> SecurityManager related APIs and some leftover related to SecurityManager >> changes? >> >> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these >>