Re: RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v3]

2024-11-29 Thread Severin Gehwolf
On Fri, 29 Nov 2024 14:47:13 GMT, Sergey Chernyshev wrote: > > Right. I'm still not convinced this extra reduction buys us much. The > > adjust controller logic will handle it if kept as is in the Metrics version. > > The adjust controller logic won't handle it, because it reduces the path fro

Re: RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v3]

2024-11-29 Thread Sergey Chernyshev
On Wed, 27 Nov 2024 11:07:18 GMT, Severin Gehwolf wrote: > Right. I'm still not convinced this extra reduction buys us much. The adjust > controller logic will handle it if kept as is in the Metrics version. The adjust controller logic won't handle it, because it reduces the path from child to

Re: RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v6]

2024-11-29 Thread Severin Gehwolf
On Wed, 27 Nov 2024 09:11:22 GMT, Sergey Chernyshev wrote: >> Cgroup V1 subsustem fails to initialize mounted controllers properly in >> certain cases, that may lead to controllers left undetected/inactive. We >> observed the behavior in CloudFoundry deployments, it affects also host >> syste

Re: RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v3]

2024-11-29 Thread Severin Gehwolf
On Wed, 27 Nov 2024 10:56:57 GMT, Sergey Chernyshev wrote: >>> Version specific code can be had in `set_subsystem_path()` of the >>> corresponding impl (like an earlier version of your patch). `lowest_limit` >>> and `limit_cg_path` fixes are version agnostic and can and should be fixed >>> in

Re: RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v6]

2024-11-29 Thread Sergey Chernyshev
On Wed, 27 Nov 2024 10:18:24 GMT, Severin Gehwolf wrote: >> Sergey Chernyshev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> adjust path suffix in cgroup (v1) version specific code, when root != >> cgroup > > src/hotspot/os/linux/cgrou

Re: RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v8]

2024-11-29 Thread Sergey Chernyshev
> Cgroup V1 subsustem fails to initialize mounted controllers properly in > certain cases, that may lead to controllers left undetected/inactive. We > observed the behavior in CloudFoundry deployments, it affects also host > systems. > > The relevant /proc/self/mountinfo line is > > > 2207 21

Integrated: 8337511: Implement JEP 404: Generational Shenandoah (Experimental)

2024-11-29 Thread William Kemper
On Mon, 30 Sep 2024 22:02:45 GMT, William Kemper wrote: > This PR merges JEP 404, a generational mode for the Shenandoah garbage > collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We would > like to target JDK24 with this PR. This pull request has now been integrated. Chan

Re: RFR: 8319875: Add macOS implementation for jcmd System.map [v9]

2024-11-29 Thread Simon Tooke
> This is a port of #16301 to macOS. > > System.map and System.dump_map are implemented using the macOS API and > provide roughly the same information in the same format. Most of the heavy > lifting was implemented by @tstuefe in > https://github.com/openjdk/jdk/pull/16301 - this PR adds the m

Re: RFR: 8337511: Implement JEP 404: Generational Shenandoah (Experimental) [v12]

2024-11-29 Thread Roman Kennke
On Fri, 29 Nov 2024 16:00:52 GMT, William Kemper wrote: >> This PR merges JEP 404, a generational mode for the Shenandoah garbage >> collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We >> would like to target JDK24 with this PR. > > William Kemper has updated the pull reques

Re: RFR: 8337511: Implement JEP 404: Generational Shenandoah (Experimental) [v12]

2024-11-29 Thread Aleksey Shipilev
On Fri, 29 Nov 2024 16:00:52 GMT, William Kemper wrote: >> This PR merges JEP 404, a generational mode for the Shenandoah garbage >> collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We >> would like to target JDK24 with this PR. > > William Kemper has updated the pull reques

Re: RFR: 8337511: Implement JEP 404: Generational Shenandoah (Experimental) [v12]

2024-11-29 Thread William Kemper
> This PR merges JEP 404, a generational mode for the Shenandoah garbage > collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We would > like to target JDK24 with this PR. William Kemper has updated the pull request with a new target base due to a merge or a rebase. The pull r

Re: RFR: 8337199: Add jcmd Thread.vthread_scheduler and Thread.vthread_pollers diagnostic commands [v2]

2024-11-29 Thread Alan Bateman
On Fri, 29 Nov 2024 04:48:57 GMT, David Holmes wrote: > The two new `execute` methods differ only in the Symbol naming the method to > call. Can we not at least define a static helper in the file so that we don't > need to duplicate everything? Okay, esp. as we'll likely add more. At some poin

Re: RFR: 8337199: Add jcmd Thread.vthread_scheduler and Thread.vthread_pollers diagnostic commands [v3]

2024-11-29 Thread Alan Bateman
> Adds `jcmd Thread.vthread_scheduler` to print the virtual thread > scheduler and `jcmd Thread.vthread_pollers` to print the I/O pollers > that support virtual threads doing blocking network I/O operations. > > This is a subset of the diagnostics that we've had in the loom repo for a > long