Re: RFR: 8334733: Remove obsolete @enablePreview from tests after JDK-83324714

2024-11-27 Thread Chen Liang
On Wed, 27 Nov 2024 23:10:15 GMT, Chen Liang wrote: > Remove the redundant `@enablePreview` and `--enable-preview` flags for > enabling ClassFile API in the tests. The remainder of these flags in all > tests seem to serve preview APIs (such as ScopedValue) or language features > (primitive pa

Re: RFR: 8334733: Remove obsolete @enablePreview from tests after JDK-83324714

2024-11-27 Thread Adam Sotona
On Wed, 27 Nov 2024 23:10:15 GMT, Chen Liang wrote: > Remove the redundant `@enablePreview` and `--enable-preview` flags for > enabling ClassFile API in the tests. The remainder of these flags in all > tests seem to serve preview APIs (such as ScopedValue) or language features > (primitive pa

Re: RFR: 8345148: Fix for JDK-8337317 is incomplete

2024-11-27 Thread Leonid Mesnik
On Thu, 28 Nov 2024 01:30:58 GMT, Alex Menkov wrote: > Fix for JDK-8337317 (#20699) updated serviceability/jvmti/HiddenClass and > serviceability/jvmti/VMObjectAlloc tests adding guards against > JVMTI_ERROR_WRONG_PHASE errors, but missed to enable JVMTI_EVENT_VM_DEATH > events. > This fix add

Integrated: 8343703: Symbol name cleanups after JEP 479

2024-11-27 Thread David Holmes
On Tue, 26 Nov 2024 06:36:44 GMT, David Holmes wrote: > After JEP 479 ([JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783) was > integrated, the handling of certain symbol lookup code can be simplified. The > old code needed to support 32-bit Windows, where names had a trailing > `@`. W

Re: RFR: 8343703: Symbol name cleanups after JEP 479 [v3]

2024-11-27 Thread David Holmes
On Thu, 28 Nov 2024 02:21:55 GMT, David Holmes wrote: >> After JEP 479 ([JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783) >> was integrated, the handling of certain symbol lookup code can be >> simplified. The old code needed to support 32-bit Windows, where names had a >> trailing `@

Re: RFR: 8343703: Symbol name cleanups after JEP 479 [v3]

2024-11-27 Thread Kim Barrett
On Thu, 28 Nov 2024 02:21:55 GMT, David Holmes wrote: >> After JEP 479 ([JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783) >> was integrated, the handling of certain symbol lookup code can be >> simplified. The old code needed to support 32-bit Windows, where names had a >> trailing `@

Re: RFR: 8343703: Symbol name cleanups after JEP 479 [v2]

2024-11-27 Thread David Holmes
On Thu, 28 Nov 2024 01:54:10 GMT, Kim Barrett wrote: >> David Holmes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update src/java.base/share/native/libjava/NativeLibraries.c >> >> Co-authored-by: Alex Menkov <69548902+alexmen...@

Re: RFR: 8343703: Symbol name cleanups after JEP 479 [v3]

2024-11-27 Thread David Holmes
> After JEP 479 ([JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783) was > integrated, the handling of certain symbol lookup code can be simplified. The > old code needed to support 32-bit Windows, where names had a trailing > `@`. When this special case now is removed, some streamlining

Re: RFR: 8343703: Symbol name cleanups after JEP 479 [v2]

2024-11-27 Thread Kim Barrett
On Wed, 27 Nov 2024 05:20:16 GMT, David Holmes wrote: >> After JEP 479 ([JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783) >> was integrated, the handling of certain symbol lookup code can be >> simplified. The old code needed to support 32-bit Windows, where names had a >> trailing `@

RFR: 8345148: Fix for JDK-8337317 is incomplete

2024-11-27 Thread Alex Menkov
Fix for JDK-8337317 (#20699) updated serviceability/jvmti/HiddenClass and serviceability/jvmti/VMObjectAlloc tests adding guards against JVMTI_ERROR_WRONG_PHASE errors, but missed to enable JVMTI_EVENT_VM_DEATH events. This fix adds the missed part. Testing: hotspot/jtreg/serviceability/jvmti o

RFR: 8334733: Remove obsolete @enablePreview from tests after JDK-83324714

2024-11-27 Thread Chen Liang
Remove the redundant `@enablePreview` and `--enable-preview` flags for enabling ClassFile API in the tests. The remainder of these flags in all tests seem to serve preview APIs (such as ScopedValue) or language features (primitive pattern, module imports, etc.), or testing the enable preview fl

Re: RFR: 8337511: Implement JEP 404: Generational Shenandoah (Experimental) [v11]

2024-11-27 Thread Paul Hohensee
On Tue, 26 Nov 2024 00:37:32 GMT, William Kemper wrote: >> This PR merges JEP 404, a generational mode for the Shenandoah garbage >> collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We >> would like to target JDK24 with this PR. > > William Kemper has updated the pull reques

Re: RFR: 8343703: Symbol name cleanups after JEP 479 [v2]

2024-11-27 Thread Alex Menkov
On Wed, 27 Nov 2024 05:20:16 GMT, David Holmes wrote: >> After JEP 479 ([JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783) >> was integrated, the handling of certain symbol lookup code can be >> simplified. The old code needed to support 32-bit Windows, where names had a >> trailing `@

Re: RFR: 8334493: Remove SecurityManager Permissions infrastructure from DiagnosticCommands [v2]

2024-11-27 Thread Leonid Mesnik
On Tue, 26 Nov 2024 21:31:52 GMT, Kevin Walls wrote: >> Remove redundant SecurityManager Permission references >> (following on from JDK-8338411: Implement JEP 486: Permanently Disable the >> Security Manager). > > Kevin Walls has updated the pull request incrementally with one additional > co

Re: RFR: 8334493: Remove SecurityManager Permissions infrastructure from DiagnosticCommands [v2]

2024-11-27 Thread Alan Bateman
On Tue, 26 Nov 2024 21:31:52 GMT, Kevin Walls wrote: >> Remove redundant SecurityManager Permission references >> (following on from JDK-8338411: Implement JEP 486: Permanently Disable the >> Security Manager). > > Kevin Walls has updated the pull request incrementally with one additional > co

Re: RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v6]

2024-11-27 Thread Severin Gehwolf
On Wed, 27 Nov 2024 09:11:22 GMT, Sergey Chernyshev wrote: >> Cgroup V1 subsustem fails to initialize mounted controllers properly in >> certain cases, that may lead to controllers left undetected/inactive. We >> observed the behavior in CloudFoundry deployments, it affects also host >> syste

Re: RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v3]

2024-11-27 Thread Sergey Chernyshev
On Wed, 27 Nov 2024 09:08:30 GMT, Sergey Chernyshev wrote: > Done. Please see the updated PR. The metrics part still needs the update - in the cgroup version specific `setPath()`. - PR Review Comment: https://git.openjdk.org/jdk/pull/21808#discussion_r1860451322

Re: RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v7]

2024-11-27 Thread Sergey Chernyshev
> Cgroup V1 subsustem fails to initialize mounted controllers properly in > certain cases, that may lead to controllers left undetected/inactive. We > observed the behavior in CloudFoundry deployments, it affects also host > systems. > > The relevant /proc/self/mountinfo line is > > > 2207 21

Re: RFR: 8334493: Remove SecurityManager Permissions infrastructure from DiagnosticCommands

2024-11-27 Thread Kevin Walls
On Sat, 23 Nov 2024 06:37:23 GMT, Alan Bateman wrote: >> Remove redundant SecurityManager Permission references >> (following on from JDK-8338411: Implement JEP 486: Permanently Disable the >> Security Manager). > > This is a change to the spec of a JDK specific API so I think should be > trac

Re: RFR: 8337511: Implement JEP 404: Generational Shenandoah (Experimental) [v11]

2024-11-27 Thread Martin Doerr
On Tue, 26 Nov 2024 00:37:32 GMT, William Kemper wrote: >> This PR merges JEP 404, a generational mode for the Shenandoah garbage >> collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We >> would like to target JDK24 with this PR. > > William Kemper has updated the pull reques

Re: RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v5]

2024-11-27 Thread Sergey Chernyshev
On Mon, 25 Nov 2024 09:44:33 GMT, Severin Gehwolf wrote: > ``` > "echo '+memory' > /sys/fs/cgroup/memory/cgroup.subtree_control ; " > ``` > > ... relies on the user in the container image to be `root`. So depending on > which base image is being used - by means of > `-Djdk.test.docker.image.na

Re: RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v3]

2024-11-27 Thread Sergey Chernyshev
On Mon, 25 Nov 2024 09:40:03 GMT, Severin Gehwolf wrote: > Version specific code can be had in `set_subsystem_path()` of the > corresponding impl (like an earlier version of your patch). `lowest_limit` > and `limit_cg_path` fixes are version agnostic and can and should be fixed in > `CgroupUti

Re: RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v6]

2024-11-27 Thread Sergey Chernyshev
> Cgroup V1 subsustem fails to initialize mounted controllers properly in > certain cases, that may lead to controllers left undetected/inactive. We > observed the behavior in CloudFoundry deployments, it affects also host > systems. > > The relevant /proc/self/mountinfo line is > > > 2207 21