On Fri, 15 Nov 2024 05:48:27 GMT, Ioi Lam wrote:
>> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://openjdk.org/jeps/483).
>>
>>
>> Note: this is a combined PR of the following individual PRs
>> - https://github.com/openjdk/jdk/pull/20516
>> - https
> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
> Linking](https://openjdk.org/jeps/483).
>
>
> Note: this is a combined PR of the following individual PRs
> - https://github.com/openjdk/jdk/pull/20516
> - https://github.com/openjdk/jdk/pull/20517
> - https://github.co
On Fri, 15 Nov 2024 05:23:13 GMT, David Holmes wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updated the test with some comments.
>
> test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineVerifyErr
On Thu, 14 Nov 2024 21:35:52 GMT, Coleen Phillimore wrote:
>> This change adds a couple of comments, removes some ancient bootstrapping
>> code, and adds an old test that we call the verifier for redefining a class,
>> even one in the bootclass path.
>> Tested with tier1-4.
>
> Coleen Phillimor
On Thu, 7 Nov 2024 17:25:40 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> previ
On Thu, 14 Nov 2024 16:02:56 GMT, Coleen Phillimore wrote:
>> Remove Hotspot code that passes protection_domain around class loading so
>> that checkPackageAccess can be called and the result stored. With the
>> removal of the Security Manager in JEP 486, this code no longer does
>> anything.
Sorry, didn't noticed the message before.
Yes, this is oversight.
Filed https://bugs.openjdk.org/browse/JDK-8344262
Thank you for the finding Julian.
--alex
On 14.11.2024 0:28, David Holmes wrote:
> That didn't work so cc'ing serviceability-dev
>
> I think it was just an oversight.
>
> David
>
On Thu, 14 Nov 2024 11:11:54 GMT, Magnus Ihse Bursie wrote:
>> Currently, the man pages are stored as troff (a text format) in the open
>> repo, and a content-wise identical copy is stored as markdown (another text
>> format) in the closed repo.
>>
>> Since markdown is preferred to troff in te
On Thu, 14 Nov 2024 19:16:30 GMT, Aleksey Shipilev wrote:
>> See, with current code, default Shenandoah prints this:
>>
>>
>> [0.025s][info][gc] GC(0) Concurrent reset (NON-GENERATIONAL) (unload
>> classes) 0.135ms
>> [0.025s][info][gc] GC(0) Pause Init Mark (NON-GENERATIONAL) (unload classes)
On Thu, 14 Nov 2024 19:26:12 GMT, Aleksey Shipilev wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 510 commits:
>>
>> - Merge branch 'merge-latest' into great-genshen-pr-redux
>> - Use new CompactHeader
On Thu, 14 Nov 2024 11:11:54 GMT, Magnus Ihse Bursie wrote:
>> Currently, the man pages are stored as troff (a text format) in the open
>> repo, and a content-wise identical copy is stored as markdown (another text
>> format) in the closed repo.
>>
>> Since markdown is preferred to troff in te
On Thu, 14 Nov 2024 23:39:08 GMT, Martin Doerr wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 510 commits:
>>
>> - Merge branch 'merge-latest' into great-genshen-pr-redux
>> - Use new CompactHeader forw
On Thu, 14 Nov 2024 15:23:35 GMT, Jonathan Gibbons wrote:
> The policy has long been to use Classpath Exception in the src and make
> directories, but not in the test directories. If you're changing the policy,
> you might want to check and update any documentation where the policy might
> be
On Wed, 13 Nov 2024 19:32:53 GMT, William Kemper wrote:
>> This PR merges JEP 404, a generational mode for the Shenandoah garbage
>> collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We
>> would like to target JDK24 with this PR.
>
> William Kemper has updated the pull reques
Small follow-up change after JDK-8338383. This moves the `objectWaiter` field
from the stackChunk to the VirtualThread instance. Only the top stackChunk uses
this field so we could save some memory by just saving it in the virtual thread
instance instead. Also, related methods
`stackChunkOopDes
These two tests both do stack dumps with one or more active threads. This can
result in SA throwing an exception if the thread is in a bad state. However, SA
will still generate stack traces for all other threads, and the tests should
still pass all the output checks, so we can safely ignore the
> This is a port of #16301 to macOS.
>
> System.map and System.dump_map are implemented using the macOS API and
> provide roughly the same information in the same format. Most of the heavy
> lifting was implemented by @tstuefe in
> https://github.com/openjdk/jdk/pull/16301 - this PR adds the m
The test is checking to make sure SA will use what is in the bcp register to
determine the current line number rather than just use frame->bcp, which often
is not up to date. It spawns a debuggee that sits in a loop that is 10 lines of
source. The test executes jstack on the debuggee and determi
On Thu, 14 Nov 2024 21:31:53 GMT, Coleen Phillimore wrote:
>> test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineVerifyError.java
>> line 124:
>>
>>> 122: try {
>>> 123: RedefineClassHelper.redefineClass(verifyErrorMirror,
>>> dump());
>>> 124: Veri
On Thu, 14 Nov 2024 20:28:01 GMT, Chris Plummer wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updated the test with some comments.
>
> test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineVerifyEr
> This change adds a couple of comments, removes some ancient bootstrapping
> code, and adds an old test that we call the verifier for redefining a class,
> even one in the bootclass path.
> Tested with tier1-4.
Coleen Phillimore has updated the pull request incrementally with one
additional co
On Thu, 14 Nov 2024 19:03:18 GMT, Coleen Phillimore wrote:
> This change adds a couple of comments, removes some ancient bootstrapping
> code, and adds an old test that we call the verifier for redefining a class,
> even one in the bootclass path.
> Tested with tier1-4.
test/hotspot/jtreg/serv
On Wed, 13 Nov 2024 19:32:53 GMT, William Kemper wrote:
>> This PR merges JEP 404, a generational mode for the Shenandoah garbage
>> collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We
>> would like to target JDK24 with this PR.
>
> William Kemper has updated the pull reques
On Thu, 14 Nov 2024 19:12:25 GMT, Aleksey Shipilev wrote:
>> No objections here. @ysramakrishna , @kdnilsen ?
>
> See, with current code, default Shenandoah prints this:
>
>
> [0.025s][info][gc] GC(0) Concurrent reset (NON-GENERATIONAL) (unload classes)
> 0.135ms
> [0.025s][info][gc] GC(0) Pau
On Wed, 13 Nov 2024 23:17:44 GMT, William Kemper wrote:
>> src/hotspot/share/gc/shenandoah/shenandoahUtils.hpp line 50:
>>
>>> 48: switch (generation_type) {
>>> \
>>> 49: case NON_GEN:
>>>
This change adds a couple of comments, removes some ancient bootstrapping code,
and adds an old test that we call the verifier for redefining a class, even one
in the bootclass path.
Tested with tier1-4.
-
Commit messages:
- 8330606: Redefinition doesn't but should verify the new k
On Thu, 14 Nov 2024 11:11:54 GMT, Magnus Ihse Bursie wrote:
>> Currently, the man pages are stored as troff (a text format) in the open
>> repo, and a content-wise identical copy is stored as markdown (another text
>> format) in the closed repo.
>>
>> Since markdown is preferred to troff in te
On Thu, 14 Nov 2024 07:53:32 GMT, David Holmes wrote:
> > > To be fair I'm unclear what role PD still plays on the JDK side and would
> > > not be surprised if it is destined for removal at some point.
> >
> >
> > PD is not deprecated as PD::getCodeSource is widely used. It may be that an
> >
On Thu, 14 Nov 2024 14:42:30 GMT, Alan Bateman wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> More obsolete code. Fix trace_class_resolution (doesn't throw exception -
>> shouldn't take TRAPS).
>
> I see a
On Fri, 8 Nov 2024 15:20:00 GMT, Nizar Benalla wrote:
> Can I please get a review for this PR that add tests to verify the value of
> `@since` tags to the Serviceability area modules. The test is described in
> this
> [email](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html)
On Thu, 14 Nov 2024 00:53:08 GMT, Nizar Benalla wrote:
>> Can I please get a review for this PR that add tests to verify the value of
>> `@since` tags to the Serviceability area modules. The test is described in
>> this
>> [email](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.
> Remove Hotspot code that passes protection_domain around class loading so
> that checkPackageAccess can be called and the result stored. With the
> removal of the Security Manager in JEP 486, this code no longer does anything.
>
> Tested with tier1-4.
Coleen Phillimore has updated the pull r
On Thu, 14 Nov 2024 12:22:36 GMT, Magnus Ihse Bursie wrote:
> In several (most? all?) of the build system files, the copyright header
> includes the classpath exception. This makes no sense, and should be removed.
>
> I have removed the classpath exception from makefiles, autoconf, shell
> sc
On Thu, 14 Nov 2024 14:03:50 GMT, Coleen Phillimore wrote:
>> Remove Hotspot code that passes protection_domain around class loading so
>> that checkPackageAccess can be called and the result stored. With the
>> removal of the Security Manager in JEP 486, this code no longer does
>> anything.
On Mon, 4 Nov 2024 14:04:58 GMT, Thomas Stuefe wrote:
>>> Looking good, small nits remain. Could you share an example output (maybe
>>> one run with G1, one with ZGC?)
>>
>> @tstuefe, Sample output for G1 and ZGC has been attached to the description
>> (and I fixed the ZGC test)
>
> Hi @stooke
On Thu, 14 Nov 2024 13:40:22 GMT, Coleen Phillimore wrote:
>> Remove Hotspot code that passes protection_domain around class loading so
>> that checkPackageAccess can be called and the result stored. With the
>> removal of the Security Manager in JEP 486, this code no longer does
>> anything.
> Remove Hotspot code that passes protection_domain around class loading so
> that checkPackageAccess can be called and the result stored. With the
> removal of the Security Manager in JEP 486, this code no longer does anything.
>
> Tested with tier1-4.
Coleen Phillimore has updated the pull r
> Remove Hotspot code that passes protection_domain around class loading so
> that checkPackageAccess can be called and the result stored. With the
> removal of the Security Manager in JEP 486, this code no longer does anything.
>
> Tested with tier1-4.
Coleen Phillimore has updated the pull r
On Thu, 14 Nov 2024 12:22:36 GMT, Magnus Ihse Bursie wrote:
> In several (most? all?) of the build system files, the copyright header
> includes the classpath exception. This makes no sense, and should be removed.
>
> I have removed the classpath exception from makefiles, autoconf, shell
> sc
On Thu, 14 Nov 2024 13:20:23 GMT, Alan Bateman wrote:
>> hotspot/share/include/jvm.h:JVM_GetClassContext(JNIEnv *env);
>>
>> I think this is obsolete too.
>
>> hotspot/share/include/jvm.h:JVM_GetClassContext(JNIEnv *env);
>>
>> I think this is obsolete too.
>
> As part of the JEP 486 work, I c
On Thu, 14 Nov 2024 13:07:55 GMT, Coleen Phillimore wrote:
> hotspot/share/include/jvm.h:JVM_GetClassContext(JNIEnv *env);
>
> I think this is obsolete too.
As part of the JEP 486 work, I changed SecurityManager::getClassContext to use
StackWalker, the native method that called into JVM_GetCla
On Thu, 14 Nov 2024 08:28:14 GMT, Alan Bateman wrote:
>> Remove Hotspot code that passes protection_domain around class loading so
>> that checkPackageAccess can be called and the result stored. With the
>> removal of the Security Manager in JEP 486, this code no longer does
>> anything.
>>
On Thu, 14 Nov 2024 13:02:22 GMT, Coleen Phillimore wrote:
>> Remove Hotspot code that passes protection_domain around class loading so
>> that checkPackageAccess can be called and the result stored. With the
>> removal of the Security Manager in JEP 486, this code no longer does
>> anything.
> Remove Hotspot code that passes protection_domain around class loading so
> that checkPackageAccess can be called and the result stored. With the
> removal of the Security Manager in JEP 486, this code no longer does anything.
>
> Tested with tier1-4.
Coleen Phillimore has updated the pull r
On Thu, 14 Nov 2024 12:29:38 GMT, Christian Stein wrote:
> Now `CheckManPageOptions` finds the `.md` file (good) and its checks fail
> (bad).
*sigh*
> A candidate for an ignore list as fixing it is out of scope of this PR?
Let me have a look at it first. It seems the test has the indention t
On Thu, 14 Nov 2024 11:11:54 GMT, Magnus Ihse Bursie wrote:
>> Currently, the man pages are stored as troff (a text format) in the open
>> repo, and a content-wise identical copy is stored as markdown (another text
>> format) in the closed repo.
>>
>> Since markdown is preferred to troff in te
In several (most? all?) of the build system files, the copyright header
includes the classpath exception. This makes no sense, and should be removed.
I have removed the classpath exception from makefiles, autoconf, shell scripts,
properties files, configuration files, IDE support files, build t
On Thu, 14 Nov 2024 05:42:51 GMT, David Holmes wrote:
>> Remove Hotspot code that passes protection_domain around class loading so
>> that checkPackageAccess can be called and the result stored. With the
>> removal of the Security Manager in JEP 486, this code no longer does
>> anything.
>>
On Thu, 14 Nov 2024 08:28:14 GMT, Alan Bateman wrote:
> Do you plan a follow-up to purge the remaining refs to AccessController and
> AccessControlContext?
I was unclear if they were still needed in the places they appear. Maybe I
should do a follow-up.
-
PR Comment: https://git
On Wed, 13 Nov 2024 11:42:11 GMT, Coleen Phillimore wrote:
> Remove Hotspot code that passes protection_domain around class loading so
> that checkPackageAccess can be called and the result stored. With the
> removal of the Security Manager in JEP 486, this code no longer does anything.
>
> T
On Wed, 13 Nov 2024 21:55:53 GMT, Iris Clark wrote:
>> src/java.base/share/man/java.md line 9:
>>
>>> 7: # published by the Free Software Foundation. Oracle designates this
>>> 8: # particular file as subject to the "Classpath" exception as provided
>>> 9: # by Oracle in the LICENSE file that a
> Currently, the man pages are stored as troff (a text format) in the open
> repo, and a content-wise identical copy is stored as markdown (another text
> format) in the closed repo.
>
> Since markdown is preferred to troff in terms of editing, we make changes to
> the man pages in markdown and
On Wed, 13 Nov 2024 23:07:02 GMT, William Kemper wrote:
>> test/hotspot/jtreg/gc/shenandoah/oom/TestThreadFailure.java line 61:
>>
>>> 59: // case that the previously instantiated NastyThread
>>> accumulated more than SheanndoahNoProgressThreshold
>>> 60: // unpr
On Wed, 13 Nov 2024 17:05:25 GMT, Magnus Ihse Bursie wrote:
> Currently, the man pages are stored as troff (a text format) in the open
> repo, and a content-wise identical copy is stored as markdown (another text
> format) in the closed repo.
>
> Since markdown is preferred to troff in terms o
On Wed, 13 Nov 2024 11:42:11 GMT, Coleen Phillimore wrote:
> Remove Hotspot code that passes protection_domain around class loading so
> that checkPackageAccess can be called and the result stored. With the
> removal of the Security Manager in JEP 486, this code no longer does anything.
>
> T
That didn't work so cc'ing serviceability-dev
I think it was just an oversight.
David
On 14/11/2024 6:24 pm, David Holmes wrote:
It was added by JDK-8339289 so cc'ing Alex.
David
On 14/11/2024 5:33 pm, Julian Waters wrote:
Bumping, I'm still curious about this issue
best regards,
Julian
On Wed, 13 Nov 2024 11:53:26 GMT, Kevin Walls wrote:
> Remove redundant SecurityManager, AccessController references
> (following on from JDK-8338411: Implement JEP 486: Permanently Disable the
> Security Manager).
Thanks for the reviews. Tier1 - 3 completed, and local jtreg testing of tests
57 matches
Mail list logo
